From patchwork Sat Apr 10 01:33:06 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aurelien Jarno X-Patchwork-Id: 49890 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 1409BB7CFA for ; Sat, 10 Apr 2010 12:06:49 +1000 (EST) Received: from localhost ([127.0.0.1]:38675 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O0Q5S-0000gl-0A for incoming@patchwork.ozlabs.org; Fri, 09 Apr 2010 22:06:18 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O0Pa2-0004tM-Tm for qemu-devel@nongnu.org; Fri, 09 Apr 2010 21:33:51 -0400 Received: from [140.186.70.92] (port=49617 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O0PZx-0004oQ-N9 for qemu-devel@nongnu.org; Fri, 09 Apr 2010 21:33:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O0PZp-0007L4-BU for qemu-devel@nongnu.org; Fri, 09 Apr 2010 21:33:45 -0400 Received: from hall.aurel32.net ([88.191.82.174]:35064) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O0PZo-0007Kn-Sh for qemu-devel@nongnu.org; Fri, 09 Apr 2010 21:33:37 -0400 Received: from [10.243.122.2] (helo=volta.aurel32.net) by hall.aurel32.net with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1O0PZk-0005NA-Is; Sat, 10 Apr 2010 03:33:36 +0200 Received: from aurel32 by volta.aurel32.net with local (Exim 4.71) (envelope-from ) id 1O0PZV-0004ku-DX; Sat, 10 Apr 2010 03:33:17 +0200 From: Aurelien Jarno To: qemu-devel@nongnu.org Date: Sat, 10 Apr 2010 03:33:06 +0200 Message-Id: <1270863186-10180-19-git-send-email-aurelien@aurel32.net> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1270863186-10180-1-git-send-email-aurelien@aurel32.net> References: <1270863186-10180-1-git-send-email-aurelien@aurel32.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: Andrzej Zaborowski , Aurelien Jarno Subject: [Qemu-devel] [PATCH v2 18/18] tcg/arm: don't try to load constants using pc X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org There is statistically almost 0 chances to use this code, so remove it. Signed-off-by: Aurelien Jarno --- tcg/arm/tcg-target.c | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 1e2028f..33c780b 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/arm/tcg-target.c @@ -396,19 +396,12 @@ static inline void tcg_out_dat_imm(TCGContext *s, static inline void tcg_out_movi32(TCGContext *s, int cond, int rd, int32_t arg) { - int offset = (uint32_t) arg - ((uint32_t) s->code_ptr + 8); - /* TODO: This is very suboptimal, we can easily have a constant * pool somewhere after all the instructions. */ if (arg < 0 && arg > -0x100) return tcg_out_dat_imm(s, cond, ARITH_MVN, rd, 0, (~arg) & 0xff); - if (offset < 0x100 && offset > -0x100) - return offset >= 0 ? - tcg_out_dat_imm(s, cond, ARITH_ADD, rd, 15, offset) : - tcg_out_dat_imm(s, cond, ARITH_SUB, rd, 15, -offset); - if (use_armv7_instructions) { /* use movw/movt */ /* movw */