From patchwork Fri Apr 9 20:49:50 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Weil X-Patchwork-Id: 49868 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2FBAAB7CF7 for ; Sat, 10 Apr 2010 07:15:24 +1000 (EST) Received: from localhost ([127.0.0.1]:44326 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O0LLy-0002il-TB for incoming@patchwork.ozlabs.org; Fri, 09 Apr 2010 17:03:02 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O0LJm-0002cl-5o for qemu-devel@nongnu.org; Fri, 09 Apr 2010 17:00:46 -0400 Received: from [140.186.70.92] (port=42135 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O0LJj-0002aQ-OF for qemu-devel@nongnu.org; Fri, 09 Apr 2010 17:00:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O0L9M-0002uY-3g for qemu-devel@nongnu.org; Fri, 09 Apr 2010 16:50:03 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]:55087) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O0L9L-0002uM-Md for qemu-devel@nongnu.org; Fri, 09 Apr 2010 16:50:00 -0400 Received: from flocke.weilnetz.de (p54ADF948.dip.t-dialin.net [84.173.249.72]) by mrelayeu.kundenserver.de (node=mreu1) with ESMTP (Nemesis) id 0M53xy-1NaPpw1LR8-00z056; Fri, 09 Apr 2010 22:49:58 +0200 Received: from stefan by flocke.weilnetz.de with local (Exim 4.71) (envelope-from ) id 1O0L9J-0001U2-GF; Fri, 09 Apr 2010 22:49:57 +0200 From: Stefan Weil To: QEMU Developers Date: Fri, 9 Apr 2010 22:49:50 +0200 Message-Id: <1270846193-5667-2-git-send-email-weil@mail.berlios.de> X-Mailer: git-send-email 1.7.0 In-Reply-To: <1270846193-5667-1-git-send-email-weil@mail.berlios.de> References: <1270846193-5667-1-git-send-email-weil@mail.berlios.de> X-Provags-ID: V01U2FsdGVkX1/1+1iY69Dg9KIbCINidkTkKpyZjpv1JvAz75o N0gBDGGIzB0gYHpfeR3Ph7YQB4MC2ZYzStLJhMV7Nyp+qDZPHc lstDbM23I/sPOkD88eBN+0GuimGEwqPwVfsLiW5NQn6VYWgxd2 qag== X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: Subject: [Qemu-devel] [PATCH] arm: Fix compiler warning (fprintf format string) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org When argument checking is enabled, gcc throws this error: error: format not a string literal and no format arguments The patch rewrites the statement to satisfy the compiler. Signed-off-by: Stefan Weil --- arm-dis.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arm-dis.c b/arm-dis.c index 4fb899e..5028555 100644 --- a/arm-dis.c +++ b/arm-dis.c @@ -3149,14 +3149,14 @@ print_insn_thumb16 (bfd_vma pc, struct disassemble_info *info, long given) if (started) func (stream, ", "); started = 1; - func (stream, arm_regnames[14] /* "lr" */); + func (stream, "%s", arm_regnames[14] /* "lr" */); } if (domaskpc) { if (started) func (stream, ", "); - func (stream, arm_regnames[15] /* "pc" */); + func (stream, "%s", arm_regnames[15] /* "pc" */); } func (stream, "}"); @@ -3699,7 +3699,7 @@ print_insn_thumb32 (bfd_vma pc, struct disassemble_info *info, long given) } else { - func (stream, psr_name (given & 0xff)); + func (stream, "%s", psr_name (given & 0xff)); } break; @@ -3707,7 +3707,7 @@ print_insn_thumb32 (bfd_vma pc, struct disassemble_info *info, long given) if ((given & 0xff) == 0) func (stream, "%cPSR", (given & 0x100000) ? 'S' : 'C'); else - func (stream, psr_name (given & 0xff)); + func (stream, "%s", psr_name (given & 0xff)); break; case '0': case '1': case '2': case '3': case '4':