From patchwork Wed Feb 24 17:55:15 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 46199 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0C4C4B7CBB for ; Thu, 25 Feb 2010 06:27:52 +1100 (EST) Received: from localhost ([127.0.0.1]:45800 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NkMtZ-0005GD-JA for incoming@patchwork.ozlabs.org; Wed, 24 Feb 2010 14:27:41 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NkLlq-0005my-IC for qemu-devel@nongnu.org; Wed, 24 Feb 2010 13:15:38 -0500 Received: from [199.232.76.173] (port=53653 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NkLlp-0005mY-TY for qemu-devel@nongnu.org; Wed, 24 Feb 2010 13:15:37 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NkLlo-0002MG-Ao for qemu-devel@nongnu.org; Wed, 24 Feb 2010 13:15:37 -0500 Received: from mx20.gnu.org ([199.232.41.8]:5461) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NkLln-0002Lv-Va for qemu-devel@nongnu.org; Wed, 24 Feb 2010 13:15:36 -0500 Received: from oxygen.pond.sub.org ([213.239.205.148]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NkLln-0001Pp-1g for qemu-devel@nongnu.org; Wed, 24 Feb 2010 13:15:35 -0500 Received: from blackfin.pond.sub.org (pD9E38C12.dip.t-dialin.net [217.227.140.18]) by oxygen.pond.sub.org (Postfix) with ESMTPA id D6B90276D5A for ; Wed, 24 Feb 2010 18:56:01 +0100 (CET) Received: by blackfin.pond.sub.org (Postfix, from userid 500) id DBD77D1; Wed, 24 Feb 2010 18:56:00 +0100 (CET) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Wed, 24 Feb 2010 18:55:15 +0100 Message-Id: <1267034160-3517-4-git-send-email-armbru@redhat.com> X-Mailer: git-send-email 1.6.6 In-Reply-To: <1267034160-3517-1-git-send-email-armbru@redhat.com> References: <1267034160-3517-1-git-send-email-armbru@redhat.com> X-detected-operating-system: by mx20.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: [Qemu-devel] [PATCH RFC 03/48] usb: Remove disabled monitor_printf() in usb_read_file() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The monitor_printf() reports failure. Printing is wrong, because the caller tries various arguments, and expects the function to fail for some or all. Disabled since commit 26a9e82a. Remove it. Signed-off-by: Markus Armbruster --- usb-linux.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index a9c15c6..d0d7cff 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -1188,9 +1188,6 @@ static int usb_host_scan_dev(void *opaque, USBScanFunc *func) */ static int usb_host_read_file(char *line, size_t line_size, const char *device_file, const char *device_name) { -#if 0 - Monitor *mon = cur_mon; -#endif FILE *f; int ret = 0; char filename[PATH_MAX]; @@ -1201,11 +1198,6 @@ static int usb_host_read_file(char *line, size_t line_size, const char *device_f if (f) { ret = fgets(line, line_size, f) != NULL; fclose(f); -#if 0 - } else { - if (mon) - monitor_printf(mon, "husb: could not open %s\n", filename); -#endif } return ret;