From patchwork Sun Dec 6 13:00:26 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Andreas_F=C3=A4rber?= X-Patchwork-Id: 40421 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 212B1B7BC3 for ; Mon, 7 Dec 2009 00:03:17 +1100 (EST) Received: from localhost ([127.0.0.1]:33304 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NHGle-00087W-Bq for incoming@patchwork.ozlabs.org; Sun, 06 Dec 2009 08:03:14 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NHGjB-0006nG-Kl for qemu-devel@nongnu.org; Sun, 06 Dec 2009 08:00:41 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NHGj6-0006kL-Rg for qemu-devel@nongnu.org; Sun, 06 Dec 2009 08:00:40 -0500 Received: from [199.232.76.173] (port=54176 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NHGj6-0006kG-Bq for qemu-devel@nongnu.org; Sun, 06 Dec 2009 08:00:36 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]:34939) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NHGj4-0001wq-Eo for qemu-devel@nongnu.org; Sun, 06 Dec 2009 08:00:35 -0500 Received: from smtp08.web.de (fmsmtp08.dlan.cinetic.de [172.20.5.216]) by fmmailgate02.web.de (Postfix) with ESMTP id 29F4F146F7B97; Sun, 6 Dec 2009 14:00:33 +0100 (CET) Received: from [84.148.107.181] (helo=localhost.localdomain) by smtp08.web.de with asmtp (WEB.DE 4.110 #314) id 1NHGj2-0001KO-01; Sun, 06 Dec 2009 14:00:32 +0100 From: Andreas Faerber To: qemu-devel@nongnu.org Date: Sun, 6 Dec 2009 14:00:26 +0100 Message-Id: <1260104426-725-3-git-send-email-andreas.faerber@web.de> X-Mailer: git-send-email 1.6.5.3 In-Reply-To: <1260104426-725-2-git-send-email-andreas.faerber@web.de> References: <1260104426-725-1-git-send-email-andreas.faerber@web.de> <1260104426-725-2-git-send-email-andreas.faerber@web.de> X-Sender: Andreas.Faerber@web.de X-Provags-ID: V01U2FsdGVkX1/RMkgCOUZV3OW3e/Lml1nh5To5R4x/7UtP7d5n WCijHCskI5ojzzqjEN83aLHhP4N5/WBHEOmaR1bukNSqHwAygr CBL/83kWKb+qFBfHFHmg== X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 Cc: John Arbuckle , Andreas Faerber Subject: [Qemu-devel] [PATCH v2 3/3] Cocoa: Silence warnings X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Missing static for cocoa_keycode_to_qemu. Missing const for character constant. __LITTLE_ENDIAN__ is undefined on Big Endian host. Signed-off-by: Andreas Faerber Cc: John Arbuckle --- cocoa.m | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cocoa.m b/cocoa.m index 7062571..05f507d 100644 --- a/cocoa.m +++ b/cocoa.m @@ -229,7 +229,7 @@ int keymap[] = */ }; -int cocoa_keycode_to_qemu(int keycode) +static int cocoa_keycode_to_qemu(int keycode) { if((sizeof(keymap)/sizeof(int)) <= keycode) { @@ -315,7 +315,7 @@ int cocoa_keycode_to_qemu(int keycode) screen.bitsPerComponent, //bitsPerComponent screen.bitsPerPixel, //bitsPerPixel (screen.width * (screen.bitsPerComponent/2)), //bytesPerRow -#if __LITTLE_ENDIAN__ +#ifdef __LITTLE_ENDIAN__ CGColorSpaceCreateWithName(kCGColorSpaceGenericRGB), //colorspace for OS X >= 10.4 kCGBitmapByteOrder32Little | kCGImageAlphaNoneSkipFirst, #else @@ -783,7 +783,7 @@ int cocoa_keycode_to_qemu(int keycode) if(returnCode == NSCancelButton) { exit(0); } else if(returnCode == NSOKButton) { - char *bin = "qemu"; + const char *bin = "qemu"; char *img = (char*)[ [ sheet filename ] cStringUsingEncoding:NSASCIIStringEncoding]; char **argv = (char**)malloc( sizeof(char*)*3 );