From patchwork Fri Nov 13 04:29:53 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Isaku Yamahata X-Patchwork-Id: 38326 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 75CACB7BC0 for ; Fri, 13 Nov 2009 15:53:26 +1100 (EST) Received: from localhost ([127.0.0.1]:49304 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N8o9z-0007CT-SL for incoming@patchwork.ozlabs.org; Thu, 12 Nov 2009 23:53:23 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N8ntU-0000Ll-Q9 for qemu-devel@nongnu.org; Thu, 12 Nov 2009 23:36:21 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N8ntL-0000Fg-Sc for qemu-devel@nongnu.org; Thu, 12 Nov 2009 23:36:16 -0500 Received: from [199.232.76.173] (port=50456 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N8ntL-0000FK-9K for qemu-devel@nongnu.org; Thu, 12 Nov 2009 23:36:11 -0500 Received: from mail.valinux.co.jp ([210.128.90.3]:35521) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N8ntK-0002e4-KE for qemu-devel@nongnu.org; Thu, 12 Nov 2009 23:36:10 -0500 Received: from nm.local.valinux.co.jp (vagw.valinux.co.jp [210.128.90.14]) by mail.valinux.co.jp (Postfix) with ESMTP id 5349A4A420; Fri, 13 Nov 2009 13:36:04 +0900 (JST) Received: from yamahata by nm.local.valinux.co.jp with local (Exim 4.69) (envelope-from ) id 1N8nnJ-0000ww-6l; Fri, 13 Nov 2009 13:29:57 +0900 From: Isaku Yamahata To: qemu-devel@nongnu.org, mst@redhat.com Date: Fri, 13 Nov 2009 13:29:53 +0900 Message-Id: <1258086596-3584-18-git-send-email-yamahata@valinux.co.jp> X-Mailer: git-send-email 1.6.0.2 In-Reply-To: <1258086596-3584-1-git-send-email-yamahata@valinux.co.jp> References: <1258086596-3584-1-git-send-email-yamahata@valinux.co.jp> X-Virus-Scanned: clamav-milter 0.95.2 at va-mail.local.valinux.co.jp X-Virus-Status: Clean X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: yamahata@valinux.co.jp Subject: [Qemu-devel] [PATCH V2 17/20] pci: remove magic number, 256 in pci.c X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This patch replaces magic number, 256, with ARRAY_SIZE(). Signed-off-by: Isaku Yamahata Acked-by: Michael S. Tsirkin --- hw/pci.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 24345b0..72b60a7 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -487,7 +487,8 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus, uint8_t header_type) { if (devfn < 0) { - for(devfn = bus->devfn_min ; devfn < 256; devfn += 8) { + for(devfn = bus->devfn_min ; devfn < ARRAY_SIZE(bus->devices); + devfn += 8) { if (!bus->devices[devfn]) goto found; } @@ -1034,7 +1035,7 @@ static void pci_for_each_device_under_bus(PCIBus *bus, PCIDevice *d; int devfn; - for(devfn = 0; devfn < 256; devfn++) { + for(devfn = 0; devfn < ARRAY_SIZE(bus->devices); devfn++) { d = bus->devices[devfn]; if (d) fn(bus, d);