From patchwork Wed Oct 7 16:32:00 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 35317 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 76163B7B81 for ; Thu, 8 Oct 2009 03:38:44 +1100 (EST) Received: from localhost ([127.0.0.1]:37287 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvZXE-0000Uw-Q4 for incoming@patchwork.ozlabs.org; Wed, 07 Oct 2009 12:38:40 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvZRS-0006vt-KC for qemu-devel@nongnu.org; Wed, 07 Oct 2009 12:32:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvZRN-0006t4-Ag for qemu-devel@nongnu.org; Wed, 07 Oct 2009 12:32:41 -0400 Received: from [199.232.76.173] (port=48034 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvZRN-0006sx-0L for qemu-devel@nongnu.org; Wed, 07 Oct 2009 12:32:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21195) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvZRL-0003sU-B1 for qemu-devel@nongnu.org; Wed, 07 Oct 2009 12:32:36 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n97GWYkH028151; Wed, 7 Oct 2009 12:32:34 -0400 Received: from localhost (vpn-12-190.rdu.redhat.com [10.11.12.190]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n97GWXWg029885; Wed, 7 Oct 2009 12:32:33 -0400 From: Luiz Capitulino To: qemu-devel@nongnu.org Date: Wed, 7 Oct 2009 13:32:00 -0300 Message-Id: <1254933135-21888-4-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1254933135-21888-1-git-send-email-lcapitulino@redhat.com> References: <1254933135-21888-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.18 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: aliguori@us.ibm.com, avi@redhat.com Subject: [Qemu-devel] [PATCH 03/18] Introduce QList unit-tests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This suite contains tests to assure that QList API works as expected. To execute it you should have check installed and build QEMU with check support enabled (--enable-check-utests) and then run: $ ./check-qlist Signed-off-by: Luiz Capitulino --- Makefile | 1 + check-qlist.c | 153 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ configure | 2 +- 3 files changed, 155 insertions(+), 1 deletions(-) create mode 100644 check-qlist.c diff --git a/Makefile b/Makefile index 17bcbe4..d96fb4b 100644 --- a/Makefile +++ b/Makefile @@ -187,6 +187,7 @@ qemu-img-cmds.h: $(SRC_PATH)/qemu-img-cmds.hx check-qint: check-qint.o qint.o qemu-malloc.o check-qstring: check-qstring.o qstring.o qemu-malloc.o check-qdict: check-qdict.o qdict.o qint.o qstring.o qemu-malloc.o +check-qlist: check-qlist.o qlist.o qint.o qemu-malloc.o clean: # avoid old build problems by removing potentially incorrect old files diff --git a/check-qlist.c b/check-qlist.c new file mode 100644 index 0000000..0117ef3 --- /dev/null +++ b/check-qlist.c @@ -0,0 +1,153 @@ +/* + * QList unit-tests. + * + * Copyright (C) 2009 Red Hat Inc. + * + * Authors: + * Luiz Capitulino + * + * This work is licensed under the terms of the GNU GPL, version 2. See + * the COPYING file in the top-level directory. + */ +#include + +#include "qint.h" +#include "qlist.h" + +/* + * Public Interface test-cases + * + * (with some violations to access 'private' data) + */ + +START_TEST(qlist_new_test) +{ + QList *qlist; + + qlist = qlist_new(); + fail_unless(qlist != NULL); + fail_unless(qlist->base.refcnt == 1); + fail_unless(qobject_type(QOBJECT(qlist)) == QTYPE_QLIST); + + // destroy doesn't exist yet + qemu_free(qlist); +} +END_TEST + +START_TEST(qlist_append_test) +{ + QInt *qi; + QList *qlist; + QListEntry *entry; + + qi = qint_from_int(42); + + qlist = qlist_new(); + qlist_append(qlist, qi); + + entry = QTAILQ_FIRST(&qlist->head); + fail_unless(entry != NULL); + fail_unless(entry->value == QOBJECT(qi)); + + // destroy doesn't exist yet + QDECREF(qi); + qemu_free(entry); + qemu_free(qlist); +} +END_TEST + +START_TEST(qobject_to_qlist_test) +{ + QList *qlist; + + qlist = qlist_new(); + + fail_unless(qobject_to_qlist(QOBJECT(qlist)) == qlist); + + // destroy doesn't exist yet + qemu_free(qlist); +} +END_TEST + +START_TEST(qlist_destroy_test) +{ + int i; + QList *qlist; + + qlist = qlist_new(); + + for (i = 0; i < 42; i++) + qlist_append(qlist, qint_from_int(i)); + + QDECREF(qlist); +} +END_TEST + +static int iter_called; +static const int iter_max = 42; + +static void iter_func(QObject *obj, void *opaque) +{ + QInt *qi; + + fail_unless(opaque == NULL); + + qi = qobject_to_qint(obj); + fail_unless(qi != NULL); + fail_unless((qint_get_int(qi) >= 0) && (qint_get_int(qi) <= iter_max)); + + iter_called++; +} + +START_TEST(qlist_iter_test) +{ + int i; + QList *qlist; + + qlist = qlist_new(); + + for (i = 0; i < iter_max; i++) + qlist_append(qlist, qint_from_int(i)); + + iter_called = 0; + qlist_iter(qlist, iter_func, NULL); + + fail_unless(iter_called == iter_max); + + QDECREF(qlist); +} +END_TEST + +static Suite *QList_suite(void) +{ + Suite *s; + TCase *qlist_public_tcase; + + s = suite_create("QList suite"); + + qlist_public_tcase = tcase_create("Public Interface"); + suite_add_tcase(s, qlist_public_tcase); + tcase_add_test(qlist_public_tcase, qlist_new_test); + tcase_add_test(qlist_public_tcase, qlist_append_test); + tcase_add_test(qlist_public_tcase, qobject_to_qlist_test); + tcase_add_test(qlist_public_tcase, qlist_destroy_test); + tcase_add_test(qlist_public_tcase, qlist_iter_test); + + return s; +} + +int main(void) +{ + int nf; + Suite *s; + SRunner *sr; + + s = QList_suite(); + sr = srunner_create(s); + + srunner_run_all(sr, CK_NORMAL); + nf = srunner_ntests_failed(sr); + srunner_free(sr); + + return (nf == 0) ? EXIT_SUCCESS : EXIT_FAILURE; +} diff --git a/configure b/configure index ad04880..4ea5483 100755 --- a/configure +++ b/configure @@ -2017,7 +2017,7 @@ if test `expr "$target_list" : ".*softmmu.*"` != 0 ; then if [ "$linux" = "yes" ] ; then tools="qemu-nbd\$(EXESUF) qemu-io\$(EXESUF) $tools" if [ "$check_utests" = "yes" ]; then - tools="check-qint check-qstring check-qdict $tools" + tools="check-qint check-qstring check-qdict check-qlist $tools" fi elif test "$mingw32" = "yes" ; then tools="qemu-io\$(EXESUF) $tools"