From patchwork Tue Oct 6 11:17:02 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark McLoughlin X-Patchwork-Id: 35088 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id AF8D7B7BFB for ; Tue, 6 Oct 2009 22:45:31 +1100 (EST) Received: from localhost ([127.0.0.1]:50320 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mv8Tw-0007s3-MV for incoming@patchwork.ozlabs.org; Tue, 06 Oct 2009 07:45:28 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mv84M-0006un-SL for qemu-devel@nongnu.org; Tue, 06 Oct 2009 07:19:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mv84F-0006qd-Du for qemu-devel@nongnu.org; Tue, 06 Oct 2009 07:18:59 -0400 Received: from [199.232.76.173] (port=40405 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mv84E-0006q7-Do for qemu-devel@nongnu.org; Tue, 06 Oct 2009 07:18:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17012) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mv84D-0007sH-Dq for qemu-devel@nongnu.org; Tue, 06 Oct 2009 07:18:53 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n96BIqSR015875 for ; Tue, 6 Oct 2009 07:18:52 -0400 Received: from blaa.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n96BIqBg016386; Tue, 6 Oct 2009 07:18:52 -0400 Received: by blaa.localdomain (Postfix, from userid 500) id D8D284ED60; Tue, 6 Oct 2009 12:17:18 +0100 (IST) From: Mark McLoughlin To: qemu-devel@nongnu.org Date: Tue, 6 Oct 2009 12:17:02 +0100 Message-Id: <1254827836-11021-13-git-send-email-markmc@redhat.com> In-Reply-To: <1254827783.2720.42.camel@blaa> References: <1254827783.2720.42.camel@blaa> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.18 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Mark McLoughlin Subject: [Qemu-devel] [PATCH] Make qemu_opts_parse() handle empty strings X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Rather than making callers explicitly handle empty strings by using qemu_opts_create(), we can easily have qemu_opts_parse() handle empty parameter strings. Signed-off-by: Mark McLoughlin --- qemu-option.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 293f94c..735259f 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -712,8 +712,7 @@ int qemu_opts_do_parse(QemuOpts *opts, const char *params, const char *firstname char option[128], value[128]; const char *p,*pe,*pc; - p = params; - for(;;) { + for (p = params; *p != '\0'; p++) { pe = strchr(p, '='); pc = strchr(p, ','); if (!pe || (pc && pc < pe)) { @@ -750,7 +749,6 @@ int qemu_opts_do_parse(QemuOpts *opts, const char *params, const char *firstname if (*p != ',') { break; } - p++; } return 0; }