From patchwork Thu Oct 1 15:50:42 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 34746 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id CA111B7BCA for ; Fri, 2 Oct 2009 02:18:25 +1000 (EST) Received: from localhost ([127.0.0.1]:57629 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MtOMI-0002bG-6M for incoming@patchwork.ozlabs.org; Thu, 01 Oct 2009 12:18:22 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MtNwT-0007mH-2L for qemu-devel@nongnu.org; Thu, 01 Oct 2009 11:51:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MtNwP-0007fd-1e for qemu-devel@nongnu.org; Thu, 01 Oct 2009 11:51:40 -0400 Received: from [199.232.76.173] (port=54696 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MtNwO-0007fG-Mf for qemu-devel@nongnu.org; Thu, 01 Oct 2009 11:51:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54316) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MtNwO-0003fG-4a for qemu-devel@nongnu.org; Thu, 01 Oct 2009 11:51:36 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n91FpZdH011014; Thu, 1 Oct 2009 11:51:35 -0400 Received: from localhost (vpn-12-143.rdu.redhat.com [10.11.12.143]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n91FpYJq008795; Thu, 1 Oct 2009 11:51:35 -0400 From: Luiz Capitulino To: qemu-devel@nongnu.org Date: Thu, 1 Oct 2009 12:50:42 -0300 Message-Id: <1254412245-10452-12-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1254412245-10452-1-git-send-email-lcapitulino@redhat.com> References: <1254412245-10452-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.18 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: aliguori@us.ibm.com, avi@redhat.com Subject: [Qemu-devel] [PATCH 11/14] monitor: Convert do_balloon() to QObject X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org It is important to observe that it never fails, as big refactoring of the virtio code would be needed to get the proper error code. Signed-off-by: Luiz Capitulino --- monitor.c | 7 +++++-- qemu-monitor.hx | 4 ++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 87fd91c..852e558 100644 --- a/monitor.c +++ b/monitor.c @@ -1636,8 +1636,11 @@ static void do_info_status(Monitor *mon) monitor_printf(mon, "VM status: paused\n"); } - -static void do_balloon(Monitor *mon, const QDict *qdict) +/** + * do_balloon(): Request VM to change its memory allocation + */ +static void do_balloon(Monitor *mon, const QDict *qdict, QObject **ret_data, + MonitorError *error) { int value = qdict_get_int(qdict, "value"); ram_addr_t target = value; diff --git a/qemu-monitor.hx b/qemu-monitor.hx index e848b1d..7cde9d9 100644 --- a/qemu-monitor.hx +++ b/qemu-monitor.hx @@ -936,8 +936,8 @@ ETEXI .name = "balloon", .args_type = "value:i", .handler = do_balloon, - .user_print = NULL, - .user_error = NULL, + .user_print = monitor_user_noop, + .user_error = monitor_error_noop, .params = "target", .help = "request VM to change it's memory allocation (in MB)" },