From patchwork Thu Oct 27 07:57:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 687501 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3t4K5p5HPMz9s2G for ; Thu, 27 Oct 2016 18:58:54 +1100 (AEDT) Received: from localhost ([::1]:39597 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzfaO-0001RK-6T for incoming@patchwork.ozlabs.org; Thu, 27 Oct 2016 03:58:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzfZW-00010C-Nd for qemu-devel@nongnu.org; Thu, 27 Oct 2016 03:57:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzfZR-0007qF-TX for qemu-devel@nongnu.org; Thu, 27 Oct 2016 03:57:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57294) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bzfZR-0007pR-Ln; Thu, 27 Oct 2016 03:57:53 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7E270804EF; Thu, 27 Oct 2016 07:57:52 +0000 (UTC) Received: from [10.36.112.20] (ovpn-112-20.ams2.redhat.com [10.36.112.20]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9R7vleL013319 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 27 Oct 2016 03:57:49 -0400 To: Alexey Kardashevskiy , qemu-devel@nongnu.org References: <1477539023-16503-1-git-send-email-aik@ozlabs.ru> From: Paolo Bonzini Message-ID: <0f42682c-2595-36ce-baa7-e874324cbe4f@redhat.com> Date: Thu, 27 Oct 2016 09:57:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1477539023-16503-1-git-send-email-aik@ozlabs.ru> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 27 Oct 2016 07:57:52 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] "block: use aio_bh_schedule_oneshot" breaks ibm-vscsi X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-ppc@nongnu.org, Stefan Hajnoczi , David Gibson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" On 27/10/2016 05:30, Alexey Kardashevskiy wrote: > Hi, > > I just discovered that fffb6e12233002c26c0ee9ff92fa87927cd779f2 broke > ibm-vscsi, the guest booting stops (I waited for a minute) at: > > [ 0.809286] ibmvscsi 71000001: SRP_VERSION: 16.a > [ 0.809766] ibmvscsi 71000001: Maximum ID: 64 Maximum LUN: 32 Maximum Channel: 3 > [ 0.810059] scsi host0: IBM POWER Virtual SCSI Adapter 1.5.9 > [ 0.810634] ibmvscsi 71000001: partner initialization complete > [ 0.810999] ibmvscsi 71000001: host srp version: 16.a, host partition qemu (0), OS 2, max io 2097152 > [ 0.811507] ibmvscsi 71000001: sent SRP login > [ 0.811705] ibmvscsi 71000001: SRP_LOGIN succeeded > [ 0.824062] scsi 0:0:0:0: Direct-Access QEMU QEMU HARDDISK 2.5+ PQ: 0 ANSI: 5 > [ 1.018526] sd 0:0:0:0: Attached scsi generic sg0 type 0 > [ 1.019352] sd 0:0:0:0: [sda] 67108864 512-byte logical blocks: (34.4 GB/32.0 GiB) > [ 1.020274] sd 0:0:0:0: [sda] Write Protect is off > [ 1.020667] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA > [ 1.023390] sda: sda1 sda2 sda3 > [ 1.025819] sd 0:0:0:0: [sda] Attached SCSI disk > > > When I switch to virtio-vscsi, I get a bit further: > > Begin: Loading essential drivers ... done. > Begin: Running /scripts/init-premount ... done. > Begin: Mounting root file system ... Begin: Running /scripts/local-top ... done. > Begin: Running /scripts/local-premount ... done. > Begin: Will now check root file system ... fsck from util-linux 2.27.1 > [/sbin/fsck.ext4 (1) -- /dev/sda2] fsck.ext4 -a -C0 /dev/sda2 > fsck.ext4: Read-only file system while trying to open /dev/sda2 > Disk write-protected; use the -n option to do a read-only > check of the device. > fsck exited with status code 8 > done. > Warning: File system check failed but did not detect errors > > and then I get login prompt. > > > With reverted fffb6e12233002c26c0ee9ff92fa87927cd779f2, virtio-vscsi behaves > the same (so I assume fffb6e122 does not affect it) and ibm-vscsi behaves nicely: > > Begin: Loading essential drivers ... done. > Begin: Running /scripts/init-premount ... done. > Begin: Mounting root file system ... Begin: Running /scripts/local-top ... done. > Begin: Running /scripts/local-premount ... done. > Begin: Will now check root file system ... fsck from util-linux 2.27.1 > [/sbin/fsck.ext4 (1) -- /dev/sda2] fsck.ext4 -a -C0 /dev/sda2 > /dev/sda2: clean, 66846/2011296 files, 574929/8034048 blocks > done. > [ 0.996954] EXT4-fs (sda2): mounted filesystem with ordered data mode. Opts: (null) > done. > > and then I get login prompt. > > > fffb6e12233002c26c0ee9ff92fa87927cd779f2 is: > === > block: use aio_bh_schedule_oneshot > > This simplifies bottom half handlers by removing calls to qemu_bh_delete and > thus removing the need to stash the bottom half pointer in the opaque > datum. > === > > Any clues what is wrong? Thanks. Hi, it turns out that the fix is already included in the 20-patch series "dataplane: remove RFifoLock". It's in patch 17. Thanks, Paolo diff --git a/async.c b/async.c index f30d011..fb37b03 100644 --- a/async.c +++ b/async.c @@ -61,6 +61,7 @@ void aio_bh_schedule_oneshot(AioContext *ctx, QEMUBHFunc *cb, void *opaque) smp_wmb(); ctx->first_bh = bh; qemu_mutex_unlock(&ctx->bh_lock); + aio_notify(ctx); } QEMUBH *aio_bh_new(AioContext *ctx, QEMUBHFunc *cb, void *opaque)