From patchwork Mon Apr 22 03:42:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Cameron Esfahani via X-Patchwork-Id: 1088562 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=nongnu.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=me.com header.i=@me.com header.b="YVctx1dg"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44nXV457Wgz9s3q for ; Mon, 22 Apr 2019 13:43:03 +1000 (AEST) Received: from localhost ([127.0.0.1]:60093 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIPrA-0007YY-Fk for incoming@patchwork.ozlabs.org; Sun, 21 Apr 2019 23:43:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIPql-0007YS-Kx for qemu-devel@nongnu.org; Sun, 21 Apr 2019 23:42:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIPqk-0003kT-Of for qemu-devel@nongnu.org; Sun, 21 Apr 2019 23:42:35 -0400 Received: from pv50p00im-ztdg10011301.me.com ([17.58.6.40]:54072) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hIPqk-0003kA-Io for qemu-devel@nongnu.org; Sun, 21 Apr 2019 23:42:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=04042017; t=1555904552; bh=q0jctMQZFKKqPnqr0q44tB9DYOQ48pyAL+pluOJjiNQ=; h=From:Content-Type:Mime-Version:Subject:Message-Id:Date:To; b=YVctx1dgHavsIiqY9bianXPBN6iCggJspKUvlVEmAs4n12k5F53nT7JXoylBLzbvh NIcZpllI3rXYQFz+qV/FTOgHIfLEQC7W6CgZvcfT70swdF3hajbSZew3z5V9AXGqzq Ykw5OcK3psbEFD0/ity8q7Q9L4B+KZo2NMiNHXbBmPIGYoZHADTBRsSpq52palLt+V hhyB/x0qC9P9scqVtAKGtEtdXWGJS6YxizyREN/EydzzQ5rCKKX86Pjnpd4UzRvVec iR0wUUsrvmEb6rLt9C3r0diKuz2MfLmEUaX9mSJnseZay3CODdHNWVKx5QEX0WM5BB mh2GwF573+6+A== Received: from [172.18.2.102] (unknown [36.106.167.46]) by pv50p00im-ztdg10011301.me.com (Postfix) with ESMTPSA id 638F4640054; Mon, 22 Apr 2019 03:42:31 +0000 (UTC) Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Message-Id: <087F1D9C-109D-41D1-BE2C-CE5D840C981B@me.com> Date: Mon, 22 Apr 2019 11:42:25 +0800 To: Paolo Bonzini , Richard Henderson , Eduardo Habkost X-Mailer: Apple Mail (2.3445.102.3) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-21_08:, , signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 mlxscore=0 mlxlogscore=682 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1812120000 definitions=main-1904220025 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 17.58.6.40 Subject: [Qemu-devel] [PATCH] hvf: Add missing break statement X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Chen Zhang via Qemu-devel From: Cameron Esfahani via Reply-To: Chen Zhang Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" In target/i386/hvf/hvf.c, a break statement was probably missing in `hvf_vcpu_exec()`, in handling EXIT_REASON_HLT. These lines seemed to be equivalent to `kvm_handle_halt()`. Signed-off-by: Chen Zhang Reviewed-by: Philippe Mathieu-Daudé --- target/i386/hvf/hvf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 42f9447303..2751c8125c 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -708,6 +708,7 @@ int hvf_vcpu_exec(CPUState *cpu) !(idtvec_info & VMCS_IDT_VEC_VALID)) { cpu->halted = 1; ret = EXCP_HLT; + break; } ret = EXCP_INTERRUPT; break;