diff mbox

[3/3] block: Update the x-blockdev-del documentation

Message ID 07c19103660708d7b728f9521686b07c7a021645.1454940776.git.berto@igalia.com
State New
Headers show

Commit Message

Alberto Garcia Feb. 8, 2016, 2:14 p.m. UTC 
Explain what happens if the user tries to delete a BlockBackend that
contains media that was added separately using blockdev-add.

Signed-off-by: Alberto Garcia <berto@igalia.com>
---
 qapi/block-core.json | 5 ++++-
 qmp-commands.hx      | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

Comments

Eric Blake Feb. 9, 2016, 3:38 p.m. UTC | #1 
On 02/08/2016 07:14 AM, Alberto Garcia wrote:
> Explain what happens if the user tries to delete a BlockBackend that
> contains media that was added separately using blockdev-add.
> 
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>  qapi/block-core.json | 5 ++++-
>  qmp-commands.hx      | 5 ++++-
>  2 files changed, 8 insertions(+), 2 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>
diff mbox

Patch

diff --git a/qapi/block-core.json b/qapi/block-core.json
index 33012b8..cc59ab9 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2089,7 +2089,10 @@ 
 #
 # In the former case the backend will be destroyed, along with its
 # inserted medium if there's any. The command will fail if the backend
-# or its medium are in use.
+# or its medium are in use. If the medium was also created with
+# blockdev-add then the command will succeed, the backend will be
+# destroyed but the medium will remain until it is deleted with
+# x-blockdev-del.
 #
 # In the latter case the node will be destroyed. The command will fail
 # if the node is attached to a block backend or is otherwise being
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 020e5ee..9710686 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -4151,7 +4151,10 @@  The selected device can be either a block backend or a graph node.
 
 In the former case the backend will be destroyed, along with its
 inserted medium if there's any. The command will fail if the backend
-or its medium are in use.
+or its medium are in use. If the medium was also created with
+blockdev-add then the command will succeed, the backend will be
+destroyed but the medium will remain until it is deleted with
+x-blockdev-del.
 
 In the latter case the node will be destroyed. The command will fail
 if the node is attached to a block backend or is otherwise being