| Message ID | 04df3f47-c93b-1d02-d250-f9bda8dbc0fa@nirf.de |
|---|---|
| State | New |
| Headers | show |
| Series | vhost-vsock: fix error message output | expand |
On a Sunday in 2020, Nick Erdmann wrote: >error_setg_errno takes a positive error number, so we should not invert >errno's sign. > >Signed-off-by: Nick Erdmann <n@nirf.de> >--- > hw/virtio/vhost-vsock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano
Le 01/03/2020 à 13:03, Nick Erdmann a écrit : > error_setg_errno takes a positive error number, so we should not invert > errno's sign. > > Signed-off-by: Nick Erdmann <n@nirf.de> > --- > hw/virtio/vhost-vsock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/virtio/vhost-vsock.c b/hw/virtio/vhost-vsock.c > index 66da96583b..9f9093e196 100644 > --- a/hw/virtio/vhost-vsock.c > +++ b/hw/virtio/vhost-vsock.c > @@ -325,7 +325,7 @@ static void vhost_vsock_device_realize(DeviceState > *dev, Error **errp) > } else { > vhostfd = open("/dev/vhost-vsock", O_RDWR); > if (vhostfd < 0) { > - error_setg_errno(errp, -errno, > + error_setg_errno(errp, errno, > "vhost-vsock: failed to open vhost device"); > return; > } > -- > 2.25.1 > Fixes: fc0b9b0e1cbb ("vhost-vsock: add virtio sockets device") Reviewed-by: Laurent Vivier <laurent@vivier.eu>
On Sun, Mar 01, 2020 at 01:03:06PM +0100, Nick Erdmann wrote: > error_setg_errno takes a positive error number, so we should not invert > errno's sign. > > Signed-off-by: Nick Erdmann <n@nirf.de> > --- > hw/virtio/vhost-vsock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/virtio/vhost-vsock.c b/hw/virtio/vhost-vsock.c > index 66da96583b..9f9093e196 100644 > --- a/hw/virtio/vhost-vsock.c > +++ b/hw/virtio/vhost-vsock.c > @@ -325,7 +325,7 @@ static void vhost_vsock_device_realize(DeviceState *dev, Error **errp) > } else { > vhostfd = open("/dev/vhost-vsock", O_RDWR); > if (vhostfd < 0) { > - error_setg_errno(errp, -errno, > + error_setg_errno(errp, errno, > "vhost-vsock: failed to open vhost device"); > return; > } Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> Thanks, Stefano
On Sun, Mar 01, 2020 at 01:03:06PM +0100, Nick Erdmann wrote: > error_setg_errno takes a positive error number, so we should not invert > errno's sign. > > Signed-off-by: Nick Erdmann <n@nirf.de> > --- > hw/virtio/vhost-vsock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
diff --git a/hw/virtio/vhost-vsock.c b/hw/virtio/vhost-vsock.c index 66da96583b..9f9093e196 100644 --- a/hw/virtio/vhost-vsock.c +++ b/hw/virtio/vhost-vsock.c @@ -325,7 +325,7 @@ static void vhost_vsock_device_realize(DeviceState *dev, Error **errp) } else { vhostfd = open("/dev/vhost-vsock", O_RDWR); if (vhostfd < 0) { - error_setg_errno(errp, -errno, + error_setg_errno(errp, errno, "vhost-vsock: failed to open vhost device"); return; }
error_setg_errno takes a positive error number, so we should not invert errno's sign. Signed-off-by: Nick Erdmann <n@nirf.de> --- hw/virtio/vhost-vsock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1