Message ID | 038502fbe4a4cf8bca7cc7b50104478e1c821647.1510181732.git.alistair.francis@xilinx.com |
---|---|
State | New |
Headers | show
Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="N72I4j5y"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yXMt75KYLz9s4q for <incoming@patchwork.ozlabs.org>; Thu, 9 Nov 2017 10:28:14 +1100 (AEDT) Received: from localhost ([::1]:34440 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>) id 1eCZlS-000447-Mq for incoming@patchwork.ozlabs.org; Wed, 08 Nov 2017 18:28:10 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <alistai@xilinx.com>) id 1eCZMh-0000d4-Te for qemu-devel@nongnu.org; Wed, 08 Nov 2017 18:02:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <alistai@xilinx.com>) id 1eCZMe-0003eU-PM for qemu-devel@nongnu.org; Wed, 08 Nov 2017 18:02:35 -0500 Received: from mail-sn1nam01on0053.outbound.protection.outlook.com ([104.47.32.53]:24078 helo=NAM01-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <alistai@xilinx.com>) id 1eCZMe-0003e4-Ib for qemu-devel@nongnu.org; Wed, 08 Nov 2017 18:02:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=rKaXFOS4KAo8UWMN294RGwqKKlOyuq2byj8SBO5gqDw=; b=N72I4j5yoKgB5ABpVaWblp0jkE0kPSy+7s5dLyQbS7FXtmzc/APdjhJX3STArFS5+OkZGqgFUK0JsBg9CQ0rQPXJaxm52ctznjoAy0QdICKeDGx4t2jCAkhzjm3mVDqa93fV8s8/lz5sK0tdDF+7bMpZOImEvAsSZ9IoljL+/80= Received: from SN4PR0201CA0060.namprd02.prod.outlook.com (2603:10b6:803:20::22) by DM2PR02MB1340.namprd02.prod.outlook.com (2a01:111:e400:50c8::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.13; Wed, 8 Nov 2017 23:02:29 +0000 Received: from CY1NAM02FT061.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::201) by SN4PR0201CA0060.outlook.office365.com (2603:10b6:803:20::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.218.12 via Frontend Transport; Wed, 8 Nov 2017 23:02:29 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by CY1NAM02FT061.mail.protection.outlook.com (10.152.75.30) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.197.9 via Frontend Transport; Wed, 8 Nov 2017 23:02:28 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:36224 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from <alistair.francis@xilinx.com>) id 1eCZMZ-0003yg-QY; Wed, 08 Nov 2017 15:02:27 -0800 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from <alistair.francis@xilinx.com>) id 1eCZMZ-00035r-NN; Wed, 08 Nov 2017 15:02:27 -0800 Received: from xsj-pvapsmtp01 (xsj-pvapsmtp01.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id vA8N2Glm010246; Wed, 8 Nov 2017 15:02:17 -0800 Received: from [172.19.2.220] (helo=xsjalistai50.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from <alistair.francis@xilinx.com>) id 1eCZMO-00032U-PG; Wed, 08 Nov 2017 15:02:16 -0800 From: Alistair Francis <alistair.francis@xilinx.com> To: <qemu-devel@nongnu.org> Date: Wed, 8 Nov 2017 14:58:18 -0800 Message-ID: <038502fbe4a4cf8bca7cc7b50104478e1c821647.1510181732.git.alistair.francis@xilinx.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <cover.1510181732.git.alistair.francis@xilinx.com> References: <cover.1510181732.git.alistair.francis@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23450.000 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(376002)(346002)(2980300002)(438002)(189002)(199003)(81156014)(81166006)(2351001)(54906003)(5820100001)(76176999)(50986999)(106002)(8676002)(316002)(356003)(36756003)(9786002)(305945005)(50466002)(4326008)(189998001)(77096006)(8936002)(39060400002)(47776003)(2870700001)(33646002)(2906002)(50226002)(63266004)(23676003)(478600001)(106466001)(2950100002)(5660300001)(36386004)(6916009)(118296001)(107986001)(5001870100001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR02MB1340; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; CY1NAM02FT061; 1:qvvqxcnvm8QYYyRS2OMwNSGSAJWh7oL5xWLR0cxkkLHzmueiSb6QP6/LJIrbCuY2DgbiZnDlBGjyco6TExwgcxkMxOjFVMx9o08LhFpo/xQWFuw/Ib2xAhee6kY9bKn8 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: de98fddc-abe2-4718-6f35-08d526fcc8f2 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(8251501002)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199); SRVR:DM2PR02MB1340; X-Microsoft-Exchange-Diagnostics: 1; DM2PR02MB1340; 3:Sn9fs4mCJ8YsXKuAbA7XQPldrnZWg7XXe4b9I8RsPID+jZbyS06cF13MrSM1/4DQmFiRGgdF8l3W0lePFcBEMxHxeg44BU0MCHcnzCdOpxBD+sE7RNQ7KxQaz0Kzwmma8aStY8AiE28JtOq7k7jek9no10JUKIW8AApFeooelZ2zP52lOIkCkiS3X9L3kcIZyw0EwQhkjZLlEUAV0VckycrL9gj2RY0Oref4H0VpHldy+3qr65rCPXRUqRE3NkJfi1BiJRv18EHsZGP6xAQBgMFarsC3tFG+ZLcpX7RyprONdDF1KbsJLTmrOHGTVP9tG3ql2nKkoSCSvOBqpCsr5F1YAbLlDCM/j1N9ogVb7z0=; 25:0X+Q3XN9wum5stOBjbuYRZon+vOrTGe456mrmjMDE/Bz/oYg7CqutQk9AK8a3KeGHFHW2/ZF9AwdJC1ckgtx5EEsymqryxMYCdikO3qDaRgPdv2OgB+jAKvy1IOjBWoPXT6GLo6uUrAfN4w/Os3Wt6I3VJbb/eMBLq28T4ZgCUQzkbyVGlR70Y+OLf4JD4k5YsRC6Jz+/KWybr9T6yY7VveyTHuWnJzONxkhl1SFd5fQ023zGTYxY6OaD3MvxyFxQbH7ziQ3zm4lrrcc+JZTdqRy9y07eJ0Elkjkn//qL8pW/+f0+Esty+aegD3TesvCfwSPYym7PrOLDeAahdslIlStNg1XO+kP+OmQF8gBIvw= X-MS-TrafficTypeDiagnostic: DM2PR02MB1340: X-Microsoft-Exchange-Diagnostics: 1; DM2PR02MB1340; 31:joTOXieAKSwV1vXcCjbLKncmqWKN/g9MMAAzCGKMdStatbymGiz0U0TxNVpncFUiNqbXtVu4A5N2HY3x5NixNfhcfi/lp3wJycGr6dElZYWJ9Jd72B5wpz1absqaO569Z0h/5INxeAKq/4TYtdLAmumSNC7OVVVPskoJnAkJG4EpFYG+CgJvIvDktLHLVx8Xmb8xHZjkw3LO54Lq+OMShZwPMcva8mAlFpRrI7FVNPY=; 20:wq3mw9zrDuvj7z+aILbBfIY1tA3Ew7fgXca+uOZOBW6agdLFTx0AU/K/F96DWT8awzZgMYujXC01YNDOf5eShzmGuk65n1aPr7/H/yWv/uv8ouY9/Pu/t5swZCP+8SbPADP6pRkQEkisN6gMoCZUdXSU7j2jBtqpZHiv0LsCKoM6UVSGRaNl8cIP4rldUpRylgHpLpzzuhoyaaIhruUwvzb5q5XoKysF5wzVZmalcGria11zQ5X4gIqEx6g9z6fPHyl6Yc1qc1lBJPGNRTa6NosS+rl9zgyk5ncF1+SSNoeyyLYg4rWDIJTDxob8Do4fbcvXiQJXeri/MU5qQeflHCsK2ERpZ75TGx9X6Omyvr1cBVFMYfXF0dogQauJbR2Jx3kYJmQNJPm3xDWNlYfXsOnGcQ/XuuVPvaRYbOZxX5ZHCTsUY4mNkiCEWGIS09NKBLwCrnOqJ/FMuKU1uQXL52dH5hcu1kbrsDxhfkWd2IjZ+a71NXE6cTmTijxkWVaR X-Exchange-Antispam-Report-Test: UriScan:(788757137089)(192813158149592); X-Microsoft-Antispam-PRVS: <DM2PR02MB13407CF32D16D27C2E9BE01EDC560@DM2PR02MB1340.namprd02.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93004095)(3002001)(3231021)(100000703101)(100105400095)(6055026)(6041248)(20161123562025)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM2PR02MB1340; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM2PR02MB1340; X-Microsoft-Exchange-Diagnostics: 1; DM2PR02MB1340; 4:RWwGLthFeTJo6Gx+qoRetkiRL00Ww7m+mDXWOTMbUVuO+31pJVR8TUL2W4MvnNmLis6Txz3xIZCXrLYFotj23mnHXfSEKVtw/+hBYHALwScdE6q7QpPN7ntTeEflRxkiGsBuaT0qpn2sWhh/dD4UYaDv1GyFlHdH3s0nlRz5bDBML30Dq3wO7d7BJVl1il+bb9HeJ/E/cFr1+ysmQqXmvI2ga9coATbM/BOTiIPas6+jsNnoLMqu63++fkOY2xC+EDgLvulCoba5ll1KEXIOQa43V0/yfVx8L9wlKbZbrCJonX+KkCZvkDidMaJ0vtibzeW3pG7OvC6nSgciTOHYmw== X-Forefront-PRVS: 0485417665 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM2PR02MB1340; 23:NwbLoz7l/4RkVYIedKBK+YuVCgxyNAVyLihUVwZBX?= ESWJn+6mmYZTZ25hbqNPJjJ3bTsXZuaiVa66uTRqWniuLr1MHP8qcTGzCDKLhvofoBjn+bJn86j6eB9AGL0Dmb6IcSMtzkcCKOHIBW/roZIk+llHWOfYih94UQQiewofqKGHINuxRuSfWpgvwBygiivlTcrzkKeSkVOy4h7Jnbl4i5DWkyuqgircC+R4Ec/wn1HSBp5otKf/kmXPlz8QG6VIYoDii5V/B9bCx9A6+K5bf84aWuh78AENB0bFhYTQgY7qo0Q756b75su+LuDFr1HMztV4vNSIBDOh7PB/Ft2y/ab1PadyBeJE3oYronBav5wlXGok59bwgjuf/ybwIvUWplqBAyvt2xDbixJYpaLEaM2AubWX6YgmFwdwKVMsTP6N62iQBVDYGYqWbDdJFkrd5LaahACogBgho5SGoeWz2bc/F+H0SOS6dL4LmpSyaIKXV8v9fYzX4x+7O9t/Dk/sq9Mvm8kdyc4Cn4wVffm6ZB6Q+RU5WtjWH9Gd2fZ5WEid+sAA+ORHcpt1f4hq75kE8LaVOJTeQCchk2kkh/sb8e7HByWTLsVbnfawe5chF2rSCQViaCtHfaJCqEGFDptoXj46UXZFXrQWjns3/p439o1I4PNdDKxdfJDlUSQDJBZ/+NEQ0oP9vX5Zw8gtFi62PhEvvAZjMCwUALHjDyci4OBIwjkZKqwuqUMkZhow6aCPxSrG6JLXtmjVWxAbpKFyUxcJ52UhycRb2aCoCU9i/U/O309EqFMN7nvvM0vgyUgclVFgz+KB4btfAONr8OnL4bySX5TfpW+4qhKHSz3Xsq+bQdYNFLiBiuNgXVmyFPZp5TYvpRvrW6mOuBeitEldRGe4Wou20+7b8YbEHjcjdK3GWsXpd+HfRFI73xRjlxJNrSRuxOVYmje65qfuz2fKitNf/XRCGkNaHw7cuMbiUDdnaSXffHldyi9m1zD+clP/urdqvOe0vz62pFlhMvhfbygdm1b2lJXFiCBZIBlMUAsXdUcej0VWWMf4EiMtks= X-Microsoft-Exchange-Diagnostics: 1; DM2PR02MB1340; 6:MBxhuyM2AvLI96kDAOIsd/tg/nve6cJRiQ8ayCSsRUSA133H/CtI4rg6DJA26/W0VJvatYPZbjL9R6v1kGe0IM1rx0JYCj4yP7b4p8uoa0XYOpJvXXW6/I53G8R5LgD03VTWZQ+BLi8beuf/RN8zdS70tnIQ7c2Z2TurLw6jNsUJE2EKzWQ/q8aD2dejAomiskhULEz8R0Lmfsj/9PSATbmggfX05Vx55Wtbzw33MVaMSPE8fPsn8TE1slf+uzGfFMP+qHa4ggPAW4KfdL0DyIXrzLTVKpGdtAK9hVQld2ywTUjn1Er4tv55ybp4n9KCjGAQncAID3w7tZbC3d+80rdreYWyqiQD6+ZJK+pTyuU=; 5:Hfcaa3/5XOp8VEq+pnkc5tRNad9nh1UGQBmHCNE8y9tUQPgq2q9I94HYGuIHIOT6Bh7h+cA0DI61p3QUXAsmrCZibUMMD7RDcOE0OI34QuknUR7JtUs/wR4sgb9otZObCzQT09KFUzkz602QGLvh1ncwDTMboowErOtdwK50bAw=; 24:l7vDKMURRC1NWUmDvBAgHn6oVxJyEdUQBdIMgfs3RwtieR4M0kfS3/uWDVQmWwnFgOBYZhIlexHRlcoZ4SJ5su3Ec6/0Oln5jd1gxv5WV4E=; 7:anrEa+N+F4dmhwNIvBcv6zmoAfSxqAWg8W7Ix/uJ2LHv5Q071icmRe31MbCTOYJUA+jC9kAUzEJjyAvPMj0sdAJJyD68MuL3DnE+opqyOHYtN4B4YzY0mjd7pr/pdmL+sC5MaKciWqlEXq5IKC184Qo/ZpzIeIvYhIh7ibO4CRkf8nSL80xNYisHBemHBhsHfAyx8MHUYG2b1XsTjmtRAQwheCTsTmz9C8JYKG3/9KCqT8vEtD22cTc6q1mBcWmJ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2017 23:02:28.3832 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: de98fddc-abe2-4718-6f35-08d526fcc8f2 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR02MB1340 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.32.53 Subject: [Qemu-devel] [PATCH v4 30/45] hw/pci*: Replace fprintf(stderr, "*\n" with error_report() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Cc: Marcel Apfelbaum <marcel@redhat.com>, alistair23@gmail.com, "Michael S. Tsirkin" <mst@redhat.com>, armbru@redhat.com, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> |
Series |
Remove some of the fprintf(stderr, "*
|
expand
|
diff --git a/hw/pci-host/bonito.c b/hw/pci-host/bonito.c index 2ebeab5d90..6f2e589bee 100644 --- a/hw/pci-host/bonito.c +++ b/hw/pci-host/bonito.c @@ -38,7 +38,7 @@ */ #include "qemu/osdep.h" - +#include "qemu/error-report.h" #include "hw/hw.h" #include "hw/pci/pci.h" #include "hw/i386/pc.h" @@ -449,8 +449,8 @@ static uint32_t bonito_sbridge_pciaddr(void *opaque, hwaddr addr) regno = (cfgaddr & BONITO_PCICONF_REG_MASK) >> BONITO_PCICONF_REG_OFFSET; if (idsel == 0) { - fprintf(stderr, "error in bonito pci config address " TARGET_FMT_plx - ",pcimap_cfg=%x\n", addr, s->regs[BONITO_PCIMAP_CFG]); + error_report("error in bonito pci config address " TARGET_FMT_plx + ",pcimap_cfg=%x", addr, s->regs[BONITO_PCIMAP_CFG]); exit(1); } pciaddr = PCI_ADDR(pci_bus_num(phb->bus), devno, funno, regno); diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 5ed3c8dca4..948d4e04ee 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -525,8 +525,8 @@ static int get_pci_irq_state(QEMUFile *f, void *pv, size_t size, for (i = 0; i < PCI_NUM_PINS; ++i) { irq_state[i] = qemu_get_be32(f); if (irq_state[i] != 0x1 && irq_state[i] != 0) { - fprintf(stderr, "irq state %d: must be 0 or 1.\n", - irq_state[i]); + error_report("irq state %d: must be 0 or 1", + irq_state[i]); return -EINVAL; } } @@ -688,7 +688,7 @@ static PCIBus *pci_get_bus_devfn(int *devfnp, PCIBus *root, unsigned slot; if (!root) { - fprintf(stderr, "No primary PCI bus\n"); + error_report("No primary PCI bus"); return NULL; } @@ -704,7 +704,7 @@ static PCIBus *pci_get_bus_devfn(int *devfnp, PCIBus *root, } if (dom != 0) { - fprintf(stderr, "No support for non-zero PCI domains\n"); + error_report("No support for non-zero PCI domains"); return NULL; } @@ -1128,8 +1128,8 @@ void pci_register_bar(PCIDevice *pci_dev, int region_num, assert(region_num >= 0); assert(region_num < PCI_NUM_REGIONS); if (size & (size-1)) { - fprintf(stderr, "ERROR: PCI region size must be pow2 " - "type=0x%x, size=0x%"FMT_PCIBUS"\n", type, size); + error_report("ERROR: PCI region size must be pow2 " + "type=0x%x, size=0x%"FMT_PCIBUS"", type, size); exit(1); }