From patchwork Fri May 16 02:01:21 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Crosthwaite X-Patchwork-Id: 349412 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 240BB1400A6 for ; Fri, 16 May 2014 12:04:22 +1000 (EST) Received: from localhost ([::1]:33026 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wl7VU-0002ym-1f for incoming@patchwork.ozlabs.org; Thu, 15 May 2014 22:04:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wl7Uv-0001yp-Pw for qemu-devel@nongnu.org; Thu, 15 May 2014 22:03:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wl7Up-0001ER-Bc for qemu-devel@nongnu.org; Thu, 15 May 2014 22:03:45 -0400 Received: from mail-qc0-f176.google.com ([209.85.216.176]:38205) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wl7Up-0001EM-86 for qemu-devel@nongnu.org; Thu, 15 May 2014 22:03:39 -0400 Received: by mail-qc0-f176.google.com with SMTP id r5so3303601qcx.35 for ; Thu, 15 May 2014 19:03:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=YR4Croihm88sFsZdxpTSZybWEOPk+tCE8d8GF1RMZ2Y=; b=AOBBYPhNiHmpayNFDbLiAfBR92RF0V7AD/77+LmElvusm76exrEmArcrS/JB0O+sZ3 VmKz3PpHkhVMEtW2rgszG/vBCbFfQzYj4MSJ/LMGLS0+SqwdJgiWIY1kmtUqDIaKZd4J f+Uohv1yeVFB2GLLlWj6k3RqM5unWzxPcjAeT2QI/XYau7JRzDFIzQlyMypihDA95Hpt lTVN9O0wD+8H5xygoXgid/0xk3AuU+IOpXqDkIxONNDlUpQk9Xf++6kGVGKRRXJsBx52 AIBG+DAaiesJNTQxM2NqczorBfuaVQ+TJW2XtGERwKM6ODbJvZZjapM2a0BM8lQI24i/ WCFQ== X-Gm-Message-State: ALoCoQnBNMG6Q+AnDOlS3Dltoe8wBNGFvqz9nkZ/qqcIdujIPDxxi48yomQ7cYc1t6i6wBU+inH+ X-Received: by 10.224.2.193 with SMTP id 1mr18522463qak.100.1400205818928; Thu, 15 May 2014 19:03:38 -0700 (PDT) Received: from localhost ([149.199.62.254]) by mx.google.com with ESMTPSA id r4sm10701631qat.16.2014.05.15.19.03.37 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 15 May 2014 19:03:37 -0700 (PDT) From: Peter Crosthwaite To: qemu-devel@nongnu.org Date: Thu, 15 May 2014 19:01:21 -0700 Message-Id: <00bd534f53ae4f94c5e306235d5be57ecad816de.1400204799.git.peter.crosthwaite@xilinx.com> X-Mailer: git-send-email 1.9.3.1.ga73a6ad In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.216.176 Cc: edgar.iglesias@xilinx.com, pbonzini@redhat.com, afaerber@suse.de, peter.maydell@linaro.org Subject: [Qemu-devel] [RFC v1 20/25] sysbus: Enable hotplug. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org If your willing to set a few props, it can work. All the connections this comment is referring to are QOMified now, so sysbus hotplug is a full reality. Signed-off-by: Peter Crosthwaite --- hw/core/sysbus.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c index 6858336..a56a74d 100644 --- a/hw/core/sysbus.c +++ b/hw/core/sysbus.c @@ -241,13 +241,6 @@ static void sysbus_device_class_init(ObjectClass *klass, void *data) DeviceClass *k = DEVICE_CLASS(klass); k->init = sysbus_device_init; k->bus_type = TYPE_SYSTEM_BUS; - /* - * device_add plugs devices into suitable bus. For "real" buses, - * that actually connects the device. For sysbus, the connections - * need to be made separately, and device_add can't do that. The - * device would be left unconnected, and could not possibly work. - */ - k->cannot_instantiate_with_device_add_yet = true; } static const TypeInfo sysbus_device_type_info = {