| Message ID | cover.1686868895.git.balaton@eik.bme.hu |
|---|---|
| Headers | show |
| Series | Misc clean ups to target/ppc exception handling | expand |
Zoltan, Patches 1, 2, 3, 5, 7 and 11 are queued. If you would be so kind to get the remaining patches, rebase them on top of my ppc-next and resend, I believe there's more stuff to be queued. Thanks, Daniel On 6/15/23 20:03, BALATON Zoltan wrote: > These are some small clean ups for target/ppc/excp_helper.c trying to > make this code a bit simpler. No functional change is intended. > > v2: Patch 3 changes according to review, added tags > v3: Address more review comments: don't change cpu_interrupt_exittb() > parameter, add back lev, add scv patch from Nick + add some more > patches to clean up #ifdefs > > Regards, > BALATON Zoltan > > BALATON Zoltan (13): > target/ppc: Remove some superfluous parentheses > target/ppc: Remove unneeded parameter from powerpc_reset_wakeup() > target/ppc: Move common check in exception handlers to a function > target/ppc: Use env_cpu for cpu_abort in excp_helper > target/ppc: Remove some more local CPUState variables only used once > target/ppc: Readability improvements in exception handlers > target/ppd: Remove unused define > target/ppc: Fix gen_sc to use correct nip > target/ppc: Simplify syscall exception handlers > target/ppc: Get CPUState in one step > target/ppc: Clean up ifdefs in excp_helper.c, part 1 > target/ppc: Clean up ifdefs in excp_helper.c, part 2 > target/ppc: Clean up ifdefs in excp_helper.c, part 3 > > Nicholas Piggin (1): > target/ppc: Move patching nip from exception handler to helper_scv > > target/ppc/cpu.h | 1 + > target/ppc/excp_helper.c | 570 ++++++++++++--------------------------- > target/ppc/translate.c | 15 +- > 3 files changed, 178 insertions(+), 408 deletions(-) >
On Fri, 30 Jun 2023, Daniel Henrique Barboza wrote: > Patches 1, 2, 3, 5, 7 and 11 are queued. > > If you would be so kind to get the remaining patches, rebase them > on top of my ppc-next and resend, I believe there's more stuff > to be queued. Thanks for taking care of these. I'll do the rebase of remaining patches once the current queue is merged, they aren't urgent so I can come back to those later. I'm working on some sam460ex patches but don't know yet when can I send it so don't wait for me now. Regards, BALATON Zoltan > > > Thanks, > > > Daniel > > On 6/15/23 20:03, BALATON Zoltan wrote: >> These are some small clean ups for target/ppc/excp_helper.c trying to >> make this code a bit simpler. No functional change is intended. >> >> v2: Patch 3 changes according to review, added tags >> v3: Address more review comments: don't change cpu_interrupt_exittb() >> parameter, add back lev, add scv patch from Nick + add some more >> patches to clean up #ifdefs >> >> Regards, >> BALATON Zoltan >> >> BALATON Zoltan (13): >> target/ppc: Remove some superfluous parentheses >> target/ppc: Remove unneeded parameter from powerpc_reset_wakeup() >> target/ppc: Move common check in exception handlers to a function >> target/ppc: Use env_cpu for cpu_abort in excp_helper >> target/ppc: Remove some more local CPUState variables only used once >> target/ppc: Readability improvements in exception handlers >> target/ppd: Remove unused define >> target/ppc: Fix gen_sc to use correct nip >> target/ppc: Simplify syscall exception handlers >> target/ppc: Get CPUState in one step >> target/ppc: Clean up ifdefs in excp_helper.c, part 1 >> target/ppc: Clean up ifdefs in excp_helper.c, part 2 >> target/ppc: Clean up ifdefs in excp_helper.c, part 3 >> >> Nicholas Piggin (1): >> target/ppc: Move patching nip from exception handler to helper_scv >> >> target/ppc/cpu.h | 1 + >> target/ppc/excp_helper.c | 570 ++++++++++++--------------------------- >> target/ppc/translate.c | 15 +- >> 3 files changed, 178 insertions(+), 408 deletions(-) >> > >
On 6/30/23 19:57, BALATON Zoltan wrote: > On Fri, 30 Jun 2023, Daniel Henrique Barboza wrote: >> Patches 1, 2, 3, 5, 7 and 11 are queued. >> >> If you would be so kind to get the remaining patches, rebase them >> on top of my ppc-next and resend, I believe there's more stuff >> to be queued. > > Thanks for taking care of these. I'll do the rebase of remaining patches once the current queue is merged, they aren't urgent so I can come back to those later. I'm working on some sam460ex patches but don't know yet when can I send it so don't wait for me now. Got it. Just bear in mind the current release schedule. Code freeze is July 11th: https://wiki.qemu.org/Planning/8.1 I'll send one last PR before freeze (probably on July 10th) and then it'll be only bug fixes until end of August. Thanks, Daniel > > Regards, > BALATON Zoltan > >> >> >> Thanks, >> >> >> Daniel >> >> On 6/15/23 20:03, BALATON Zoltan wrote: >>> These are some small clean ups for target/ppc/excp_helper.c trying to >>> make this code a bit simpler. No functional change is intended. >>> >>> v2: Patch 3 changes according to review, added tags >>> v3: Address more review comments: don't change cpu_interrupt_exittb() >>> parameter, add back lev, add scv patch from Nick + add some more >>> patches to clean up #ifdefs >>> >>> Regards, >>> BALATON Zoltan >>> >>> BALATON Zoltan (13): >>> target/ppc: Remove some superfluous parentheses >>> target/ppc: Remove unneeded parameter from powerpc_reset_wakeup() >>> target/ppc: Move common check in exception handlers to a function >>> target/ppc: Use env_cpu for cpu_abort in excp_helper >>> target/ppc: Remove some more local CPUState variables only used once >>> target/ppc: Readability improvements in exception handlers >>> target/ppd: Remove unused define >>> target/ppc: Fix gen_sc to use correct nip >>> target/ppc: Simplify syscall exception handlers >>> target/ppc: Get CPUState in one step >>> target/ppc: Clean up ifdefs in excp_helper.c, part 1 >>> target/ppc: Clean up ifdefs in excp_helper.c, part 2 >>> target/ppc: Clean up ifdefs in excp_helper.c, part 3 >>> >>> Nicholas Piggin (1): >>> target/ppc: Move patching nip from exception handler to helper_scv >>> >>> target/ppc/cpu.h | 1 + >>> target/ppc/excp_helper.c | 570 ++++++++++++--------------------------- >>> target/ppc/translate.c | 15 +- >>> 3 files changed, 178 insertions(+), 408 deletions(-) >>> >> >>
On Sat, 1 Jul 2023, Daniel Henrique Barboza wrote: > On 6/30/23 19:57, BALATON Zoltan wrote: >> On Fri, 30 Jun 2023, Daniel Henrique Barboza wrote: >>> Patches 1, 2, 3, 5, 7 and 11 are queued. >>> >>> If you would be so kind to get the remaining patches, rebase them >>> on top of my ppc-next and resend, I believe there's more stuff >>> to be queued. >> >> Thanks for taking care of these. I'll do the rebase of remaining patches >> once the current queue is merged, they aren't urgent so I can come back to >> those later. I'm working on some sam460ex patches but don't know yet when >> can I send it so don't wait for me now. > > Got it. Just bear in mind the current release schedule. Code freeze is July > 11th: > > https://wiki.qemu.org/Planning/8.1 > > I'll send one last PR before freeze (probably on July 10th) and then it'll be > only bug fixes until end of August. Do you mean one more last PR after merging the current queue or the current queue will only be in that last PR? I hoped there would be a PR now on which I can rebase the outstanding patches for the last PR so I don't have to rebase on next but if the only PR you plan is the last on 10th then I may need to move to ppc-next now. Regards, BALATON Zoltan
On 7/1/23 06:39, BALATON Zoltan wrote: > On Sat, 1 Jul 2023, Daniel Henrique Barboza wrote: >> On 6/30/23 19:57, BALATON Zoltan wrote: >>> On Fri, 30 Jun 2023, Daniel Henrique Barboza wrote: >>>> Patches 1, 2, 3, 5, 7 and 11 are queued. >>>> >>>> If you would be so kind to get the remaining patches, rebase them >>>> on top of my ppc-next and resend, I believe there's more stuff >>>> to be queued. >>> >>> Thanks for taking care of these. I'll do the rebase of remaining patches once the current queue is merged, they aren't urgent so I can come back to those later. I'm working on some sam460ex patches but don't know yet when can I send it so don't wait for me now. >> >> Got it. Just bear in mind the current release schedule. Code freeze is July 11th: >> >> https://wiki.qemu.org/Planning/8.1 >> >> I'll send one last PR before freeze (probably on July 10th) and then it'll be only bug fixes until end of August. > > Do you mean one more last PR after merging the current queue or the current queue will only be in that last PR? I hoped there would be a PR now on which I can rebase the outstanding patches for the last PR so I don't have to rebase on next but if the only PR you plan is the last on 10th then I may need to move to ppc-next now. Just use ppc-next right now. Even if I send a PR today with what we have, Peter/Richard has no obligation of merging it quickly on Monday (there's an US holiday July 4th, and some people will also skip July 3rd). If you wait for such PR to merge upstream, then start rebasing your stuff, you'll have less time to work with. Daniel > > Regards, > BALATON Zoltan
On Sat, 1 Jul 2023, Daniel Henrique Barboza wrote: > On 7/1/23 06:39, BALATON Zoltan wrote: >> On Sat, 1 Jul 2023, Daniel Henrique Barboza wrote: >>> On 6/30/23 19:57, BALATON Zoltan wrote: >>>> On Fri, 30 Jun 2023, Daniel Henrique Barboza wrote: >>>>> Patches 1, 2, 3, 5, 7 and 11 are queued. >>>>> >>>>> If you would be so kind to get the remaining patches, rebase them >>>>> on top of my ppc-next and resend, I believe there's more stuff >>>>> to be queued. >>>> >>>> Thanks for taking care of these. I'll do the rebase of remaining patches >>>> once the current queue is merged, they aren't urgent so I can come back >>>> to those later. I'm working on some sam460ex patches but don't know yet >>>> when can I send it so don't wait for me now. >>> >>> Got it. Just bear in mind the current release schedule. Code freeze is >>> July 11th: >>> >>> https://wiki.qemu.org/Planning/8.1 >>> >>> I'll send one last PR before freeze (probably on July 10th) and then it'll >>> be only bug fixes until end of August. >> >> Do you mean one more last PR after merging the current queue or the current >> queue will only be in that last PR? I hoped there would be a PR now on >> which I can rebase the outstanding patches for the last PR so I don't have >> to rebase on next but if the only PR you plan is the last on 10th then I >> may need to move to ppc-next now. > > Just use ppc-next right now. > > Even if I send a PR today with what we have, Peter/Richard has no > obligation of merging it quickly on Monday (there's an US holiday July > 4th, and some people will also skip July 3rd). If you wait for such PR > to merge upstream, then start rebasing your stuff, you'll have less time > to work with. They may not be in the US though. Anyway, I've tried to rebase the remaining patches on your ppc-next branch and they applied without changes so not sure what you need from me now. I think Nick had alternative versions of the checkstop and sc patches that may cause a rebase when then go in first. Do you want me to merge them and submit that as a series with my patches? I don't have much time for now and these are just clean ups so I can live with these missing the next release and can come back to it later. I may try to do some sam460ex clean ups instead that should not clash with anything else. Regards, BALATON Zoltan
On 7/2/23 09:36, BALATON Zoltan wrote: > On Sat, 1 Jul 2023, Daniel Henrique Barboza wrote: >> On 7/1/23 06:39, BALATON Zoltan wrote: >>> On Sat, 1 Jul 2023, Daniel Henrique Barboza wrote: >>>> On 6/30/23 19:57, BALATON Zoltan wrote: >>>>> On Fri, 30 Jun 2023, Daniel Henrique Barboza wrote: >>>>>> Patches 1, 2, 3, 5, 7 and 11 are queued. >>>>>> >>>>>> If you would be so kind to get the remaining patches, rebase them >>>>>> on top of my ppc-next and resend, I believe there's more stuff >>>>>> to be queued. >>>>> >>>>> Thanks for taking care of these. I'll do the rebase of remaining patches once the current queue is merged, they aren't urgent so I can come back to those later. I'm working on some sam460ex patches but don't know yet when can I send it so don't wait for me now. >>>> >>>> Got it. Just bear in mind the current release schedule. Code freeze is July 11th: >>>> >>>> https://wiki.qemu.org/Planning/8.1 >>>> >>>> I'll send one last PR before freeze (probably on July 10th) and then it'll be only bug fixes until end of August. >>> >>> Do you mean one more last PR after merging the current queue or the current queue will only be in that last PR? I hoped there would be a PR now on which I can rebase the outstanding patches for the last PR so I don't have to rebase on next but if the only PR you plan is the last on 10th then I may need to move to ppc-next now. >> >> Just use ppc-next right now. >> >> Even if I send a PR today with what we have, Peter/Richard has no obligation of merging it quickly on Monday (there's an US holiday July 4th, and some people will also skip July 3rd). If you wait for such PR to merge upstream, then start rebasing your stuff, you'll have less time to work with. > > They may not be in the US though. Anyway, I've tried to rebase the remaining patches on your ppc-next branch and they applied without changes so not sure what you need from me now. I think Nick had alternative versions of the checkstop and sc patches that may cause a rebase when then go in first. Do you want me to merge them and submit that as a series with my patches? I don't have much time for now and these are just clean ups so I can live with these missing the next release and can come back to it later. I may try to do some sam460ex clean ups instead that should not clash with anything else. I'm fine with leaving some of these cleanups for the next release. I might review some patches by myself and queueing them during this week. Daniel > > Regards, > BALATON Zoltan