mbox series

[v2,0/2] 9pfs: test suite fixes

Message ID cover.1604061839.git.qemu_oss@crudebyte.com
Headers show
Series 9pfs: test suite fixes | expand

Message

Christian Schoenebeck Oct. 30, 2020, 12:43 p.m. UTC
Fixes two bugs with the 9pfs 'local' tests as discussed with latest 9P PR
(2020-10-23). See the discussion of that PR for details.

v1->v2:

  - Added Greg's tested-by tag [patch 1].

  - Log an info-level message if mkdir() failed [patch 2].

  - Update commit log message about coverity being the reporter and
    details of the coverity report [patch 2].

Christian Schoenebeck (2):
  tests/9pfs: fix test dir for parallel tests
  tests/9pfs: fix coverity error in create_local_test_dir()

 tests/qtest/libqos/virtio-9p.c | 32 +++++++++++++++++++++++++-------
 1 file changed, 25 insertions(+), 7 deletions(-)

Comments

Greg Kurz Oct. 30, 2020, 1:23 p.m. UTC | #1
On Fri, 30 Oct 2020 13:43:59 +0100
Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:

> Fixes two bugs with the 9pfs 'local' tests as discussed with latest 9P PR
> (2020-10-23). See the discussion of that PR for details.
> 
> v1->v2:
> 
>   - Added Greg's tested-by tag [patch 1].
> 
>   - Log an info-level message if mkdir() failed [patch 2].
> 
>   - Update commit log message about coverity being the reporter and
>     details of the coverity report [patch 2].
> 
> Christian Schoenebeck (2):
>   tests/9pfs: fix test dir for parallel tests
>   tests/9pfs: fix coverity error in create_local_test_dir()
> 
>  tests/qtest/libqos/virtio-9p.c | 32 +++++++++++++++++++++++++-------
>  1 file changed, 25 insertions(+), 7 deletions(-)
> 

Series,

Reviewed-by: Greg Kurz <groug@kaod.org>
Christian Schoenebeck Oct. 30, 2020, 1:38 p.m. UTC | #2
On Freitag, 30. Oktober 2020 14:23:15 CET Greg Kurz wrote:
> On Fri, 30 Oct 2020 13:43:59 +0100
> 
> Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:
> > Fixes two bugs with the 9pfs 'local' tests as discussed with latest 9P PR
> > (2020-10-23). See the discussion of that PR for details.
> > 
> > v1->v2:
> >   - Added Greg's tested-by tag [patch 1].
> >   
> >   - Log an info-level message if mkdir() failed [patch 2].
> >   
> >   - Update commit log message about coverity being the reporter and
> >   
> >     details of the coverity report [patch 2].
> > 
> > Christian Schoenebeck (2):
> >   tests/9pfs: fix test dir for parallel tests
> >   tests/9pfs: fix coverity error in create_local_test_dir()
> >  
> >  tests/qtest/libqos/virtio-9p.c | 32 +++++++++++++++++++++++++-------
> >  1 file changed, 25 insertions(+), 7 deletions(-)
> 
> Series,
> 
> Reviewed-by: Greg Kurz <groug@kaod.org>

Thanks for review and testing. I appreciate it.

Best regards,
Christian Schoenebeck