| Message ID | cover.1542287931.git.simon@ruderich.org |
|---|---|
| Headers | show |
| Series | qmp: add pmemload command | expand |
On 11/15/18 7:22 AM, Simon Ruderich wrote: > Hello again, > > Please ignore v6, I forgot one patch. I hope I got it right this > time. Our automated tooling doesn't spot patches sent in reply to an earlier series; you may want to repost v7 as a new top-level thread (not in-reply-to any earlier message) to makes sure it gets seen by patchew. > > As I got no replies to my last mails, here again the full patch > set (rebased on current master) in the hope to get this merged. > The first few patches are cleanup, the last two patches add the > pmemload feature. Only 5/6 requires an ack (although all > mentioned issues should be fixed), all other patches were already > reviewed in the last round. > > If there's anything else I can do to get this merged, please tell > me. > > Regards > Simon Ruderich > > Simon Ruderich (7): > cpus: correct coding style in qmp_memsave/qmp_pmemsave > cpus: convert qmp_memsave/qmp_pmemsave to use qemu_open > cpus: use size_t in qmp_memsave/qmp_pmemsave > hmp: use l for size argument in memsave/pmemsave > hmp: use F for filename arguments in memsave/pmemsave > qmp: add pmemload command > hmp: add pmemload command > > cpus.c | 81 ++++++++++++++++++++++++++++++++++++++++--------- > hmp-commands.hx | 18 +++++++++-- > hmp.c | 16 ++++++++-- > hmp.h | 1 + > qapi/misc.json | 20 ++++++++++++ > 5 files changed, 118 insertions(+), 18 deletions(-) > > No changes between v6 and v7, but v6 missed one patch. > > Diff between v5 and v7: > > --- a/qapi/misc.json > +++ b/qapi/misc.json > @@ -1201,7 +1201,7 @@ > # > # Returns: Nothing on success > # > -# Since: 3.1 > +# Since: 3.2 Except the next release will be named 4.0, not 3.2 :) (It's okay, there's a lot of mentions of 3.2 floating on the list right now, and we'll probably have to do a global search-and-replace at some point once we are into the new year)
On Thu, Nov 15, 2018 at 07:45:29AM -0600, Eric Blake wrote: > On 11/15/18 7:22 AM, Simon Ruderich wrote: >> Hello again, >> >> Please ignore v6, I forgot one patch. I hope I got it right this >> time. > > Our automated tooling doesn't spot patches sent in reply to an earlier > series; you may want to repost v7 as a new top-level thread (not in-reply-to > any earlier message) to makes sure it gets seen by patchew. Hello, Thanks for the quick reply and review. I didn't know that patchew requires new threads. I've resent it as v8 as new top-level thread. >> --- a/qapi/misc.json >> +++ b/qapi/misc.json >> @@ -1201,7 +1201,7 @@ >> # >> # Returns: Nothing on success >> # >> -# Since: 3.1 >> +# Since: 3.2 > > Except the next release will be named 4.0, not 3.2 :) (It's okay, there's a > lot of mentions of 3.2 floating on the list right now, and we'll probably > have to do a global search-and-replace at some point once we are into the > new year) I've fixed the version in v8. Regards Simon Ruderich
Hello again, Please ignore v6, I forgot one patch. I hope I got it right this time. As I got no replies to my last mails, here again the full patch set (rebased on current master) in the hope to get this merged. The first few patches are cleanup, the last two patches add the pmemload feature. Only 5/6 requires an ack (although all mentioned issues should be fixed), all other patches were already reviewed in the last round. If there's anything else I can do to get this merged, please tell me. Regards Simon Ruderich Simon Ruderich (7): cpus: correct coding style in qmp_memsave/qmp_pmemsave cpus: convert qmp_memsave/qmp_pmemsave to use qemu_open cpus: use size_t in qmp_memsave/qmp_pmemsave hmp: use l for size argument in memsave/pmemsave hmp: use F for filename arguments in memsave/pmemsave qmp: add pmemload command hmp: add pmemload command cpus.c | 81 ++++++++++++++++++++++++++++++++++++++++--------- hmp-commands.hx | 18 +++++++++-- hmp.c | 16 ++++++++-- hmp.h | 1 + qapi/misc.json | 20 ++++++++++++ 5 files changed, 118 insertions(+), 18 deletions(-) No changes between v6 and v7, but v6 missed one patch. Diff between v5 and v7: --- a/qapi/misc.json +++ b/qapi/misc.json @@ -1201,7 +1201,7 @@ # # Returns: Nothing on success # -# Since: 3.1 +# Since: 3.2 ## { 'command': 'pmemload', 'data': {'val': 'int', 'filename': 'str', '*size': 'int', '*offset': 'int'} } Diff between v4 (last full series) and v7: --- a/cpus.c +++ b/cpus.c @@ -2473,6 +2473,10 @@ void qmp_pmemload(int64_t addr, const char *filename, error_setg_errno(errp, errno, "could not fstat fd to get size"); goto exit; } + if (S_ISCHR(s.st_mode) || S_ISBLK(s.st_mode)) { + error_setg(errp, "pmemload doesn't support char/block devices"); + goto exit; + } size = s.st_size; } --- a/qapi/misc.json +++ b/qapi/misc.json @@ -1201,7 +1201,7 @@ # # Returns: Nothing on success # -# Since: 3.1 +# Since: 3.2 ## { 'command': 'pmemload', 'data': {'val': 'int', 'filename': 'str', '*size': 'int', '*offset': 'int'} }