| Message ID | cover.1540293795.git.tgolembi@redhat.com |
|---|---|
| Headers | show |
| Series | qga: report serial number and disk node | expand |
Quoting Tomáš Golembiovský (2018-10-23 06:23:09) > Note that PCI controller reporting on Windows was and still is broken. > Unfortunately I don't know how to fix it at the momemnt. See commit message and > code comment. If anyone has environment where the original code works let me > know. CCing author of the code In case I missed something obvious. > > v5: > - return -1 in PCI info > I have cherry-picked three commits from Sameeh Jubran and Michael Roth: > https://github.com/mdroth/qemu/commit/89f145d7e90d721dbc7c9d0082e564bad7e88247 > https://github.com/mdroth/qemu/commit/d5f5f7e7dc265a9e62e5f4c2ee342ab7e56cca53 > https://github.com/mdroth/qemu/commit/201db36b56d7d1ba5ff720eedcb3b62b75306fde > - remove == TRUE from if-conditions > - separate Linux and Windows changes so that the Linux part can be pushed > independently; the relevant commits are ordered first. > - fixed several typos > > v4: > - split changes into more patches > - fixed UNC for physical drive to use device namespace > - renamed g_debug_err() to debug_error() > - fixed build without libudev > > v3: > - fix typos > - add configure test for libudev > - change order of patches fixing PCI controller info and build fix to avoid > exposing broken code > - split reporting of serial number and device node into two separate patches > > v2: > - fix checkpatch error > > Michael Roth (1): > *additonal fixup for NULL pci_controller field > > Sameeh Jubran (2): > qga-win: prevent crash when executing fsinfo command > qga-win: fsinfo: pci-info: allow partial info > > Tomáš Golembiovský (11): > configure: add test for libudev > qga: linux: report disk serial number > qga: linux: return disk device in guest-get-fsinfo > build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI > qga-win: add debugging information > qga-win: refactor disk properties (bus) > qga-win: report disk serial number > qga-win: refactor disk info > qga-win: handle multi-disk volumes > qga-win: return disk device in guest-get-fsinfo > qga-win: demystify namespace stripping Thanks, applied to qga tree with some small fix-ups: https://github.com/mdroth/qemu/commits/qga > > configure | 24 +++- > dtc | 2 +- > qga/Makefile.objs | 1 + > qga/commands-posix.c | 37 +++++- > qga/commands-win32.c | 269 +++++++++++++++++++++++++++++++++++-------- > qga/qapi-schema.json | 5 +- > 6 files changed, 287 insertions(+), 51 deletions(-) > > -- > 2.19.0 >
On Mon, 29 Oct 2018 22:27:45 -0500 Michael Roth <mdroth@linux.vnet.ibm.com> wrote: > Quoting Tomáš Golembiovský (2018-10-23 06:23:09) > > Note that PCI controller reporting on Windows was and still is broken. > > Unfortunately I don't know how to fix it at the momemnt. See commit message and > > code comment. If anyone has environment where the original code works let me > > know. CCing author of the code In case I missed something obvious. > > > > v5: > > - return -1 in PCI info > > I have cherry-picked three commits from Sameeh Jubran and Michael Roth: > > https://github.com/mdroth/qemu/commit/89f145d7e90d721dbc7c9d0082e564bad7e88247 > > https://github.com/mdroth/qemu/commit/d5f5f7e7dc265a9e62e5f4c2ee342ab7e56cca53 > > https://github.com/mdroth/qemu/commit/201db36b56d7d1ba5ff720eedcb3b62b75306fde > > - remove == TRUE from if-conditions > > - separate Linux and Windows changes so that the Linux part can be pushed > > independently; the relevant commits are ordered first. > > - fixed several typos > > > > v4: > > - split changes into more patches > > - fixed UNC for physical drive to use device namespace > > - renamed g_debug_err() to debug_error() > > - fixed build without libudev > > > > v3: > > - fix typos > > - add configure test for libudev > > - change order of patches fixing PCI controller info and build fix to avoid > > exposing broken code > > - split reporting of serial number and device node into two separate patches > > > > v2: > > - fix checkpatch error > > > > Michael Roth (1): > > *additonal fixup for NULL pci_controller field > > > > Sameeh Jubran (2): > > qga-win: prevent crash when executing fsinfo command > > qga-win: fsinfo: pci-info: allow partial info > > > > Tomáš Golembiovský (11): > > configure: add test for libudev > > qga: linux: report disk serial number > > qga: linux: return disk device in guest-get-fsinfo > > build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI > > qga-win: add debugging information > > qga-win: refactor disk properties (bus) > > qga-win: report disk serial number > > qga-win: refactor disk info > > qga-win: handle multi-disk volumes > > qga-win: return disk device in guest-get-fsinfo > > qga-win: demystify namespace stripping > > Thanks, applied to qga tree with some small fix-ups: > https://github.com/mdroth/qemu/commits/qga Thank you > > > > > configure | 24 +++- > > dtc | 2 +- > > qga/Makefile.objs | 1 + > > qga/commands-posix.c | 37 +++++- > > qga/commands-win32.c | 269 +++++++++++++++++++++++++++++++++++-------- > > qga/qapi-schema.json | 5 +- > > 6 files changed, 287 insertions(+), 51 deletions(-) > > > > -- > > 2.19.0 > >
Note that PCI controller reporting on Windows was and still is broken. Unfortunately I don't know how to fix it at the momemnt. See commit message and code comment. If anyone has environment where the original code works let me know. CCing author of the code In case I missed something obvious. v5: - return -1 in PCI info I have cherry-picked three commits from Sameeh Jubran and Michael Roth: https://github.com/mdroth/qemu/commit/89f145d7e90d721dbc7c9d0082e564bad7e88247 https://github.com/mdroth/qemu/commit/d5f5f7e7dc265a9e62e5f4c2ee342ab7e56cca53 https://github.com/mdroth/qemu/commit/201db36b56d7d1ba5ff720eedcb3b62b75306fde - remove == TRUE from if-conditions - separate Linux and Windows changes so that the Linux part can be pushed independently; the relevant commits are ordered first. - fixed several typos v4: - split changes into more patches - fixed UNC for physical drive to use device namespace - renamed g_debug_err() to debug_error() - fixed build without libudev v3: - fix typos - add configure test for libudev - change order of patches fixing PCI controller info and build fix to avoid exposing broken code - split reporting of serial number and device node into two separate patches v2: - fix checkpatch error Michael Roth (1): *additonal fixup for NULL pci_controller field Sameeh Jubran (2): qga-win: prevent crash when executing fsinfo command qga-win: fsinfo: pci-info: allow partial info Tomáš Golembiovský (11): configure: add test for libudev qga: linux: report disk serial number qga: linux: return disk device in guest-get-fsinfo build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI qga-win: add debugging information qga-win: refactor disk properties (bus) qga-win: report disk serial number qga-win: refactor disk info qga-win: handle multi-disk volumes qga-win: return disk device in guest-get-fsinfo qga-win: demystify namespace stripping configure | 24 +++- dtc | 2 +- qga/Makefile.objs | 1 + qga/commands-posix.c | 37 +++++- qga/commands-win32.c | 269 +++++++++++++++++++++++++++++++++++-------- qga/qapi-schema.json | 5 +- 6 files changed, 287 insertions(+), 51 deletions(-)