| Message ID | cover.1536320522.git.tgolembi@redhat.com |
|---|---|
| Headers | show |
| Series | qga: report serial number and disk node | expand |
Gentle reminder. This feature is fairly important for oVirt and I'd rather not miss another release. On Fri, 7 Sep 2018 13:42:08 +0200 Tomáš Golembiovský <tgolembi@redhat.com> wrote: > Note that PCI controller reporting on Windows was and still is broken. > Unfortunately I don't know how to fix it at the momemnt. See commit message and > code comment. If anyone has environment where the original code works let me > know. CCing author of the code In case I missed something obvious. > > v3: > - fix typos > - add configure test for libudev > - change order of patches fixing PCI controller info and build fix to avoid > exposing broken code > - split reporting of serial number and device node into two separate patches > > v2: > - fix checkpatch error > > Patches 1 and 3 are bug-fixes of existing code > Patch 2 is optional and contains debug messages -- the windows QGA seriously > lacks debug messages... > Patch 4 adds reporting of disk serial number and device node of the disk. > > Tomáš Golembiovský (5): > qga: win32: fix crashes when PCI info cannot be retrived > build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI > qga: win32: add debugging information > qga: report disk serial number > qga: return disk device in guest-get-fsinfo > > configure | 24 ++++- > qga/Makefile.objs | 1 + > qga/commands-posix.c | 27 +++++ > qga/commands-win32.c | 248 ++++++++++++++++++++++++++++++++++++------- > qga/qapi-schema.json | 5 +- > 5 files changed, 264 insertions(+), 41 deletions(-) > > -- > 2.18.0 >
ping On Tue, 18 Sep 2018 13:49:24 +0200 Tomáš Golembiovský <tgolembi@redhat.com> wrote: > Gentle reminder. > > This feature is fairly important for oVirt and I'd rather not miss > another release. > > On Fri, 7 Sep 2018 13:42:08 +0200 > Tomáš Golembiovský <tgolembi@redhat.com> wrote: > > > Note that PCI controller reporting on Windows was and still is broken. > > Unfortunately I don't know how to fix it at the momemnt. See commit message and > > code comment. If anyone has environment where the original code works let me > > know. CCing author of the code In case I missed something obvious. > > > > v3: > > - fix typos > > - add configure test for libudev > > - change order of patches fixing PCI controller info and build fix to avoid > > exposing broken code > > - split reporting of serial number and device node into two separate patches > > > > v2: > > - fix checkpatch error > > > > Patches 1 and 3 are bug-fixes of existing code > > Patch 2 is optional and contains debug messages -- the windows QGA seriously > > lacks debug messages... > > Patch 4 adds reporting of disk serial number and device node of the disk. > > > > Tomáš Golembiovský (5): > > qga: win32: fix crashes when PCI info cannot be retrived > > build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI > > qga: win32: add debugging information > > qga: report disk serial number > > qga: return disk device in guest-get-fsinfo > > > > configure | 24 ++++- > > qga/Makefile.objs | 1 + > > qga/commands-posix.c | 27 +++++ > > qga/commands-win32.c | 248 ++++++++++++++++++++++++++++++++++++------- > > qga/qapi-schema.json | 5 +- > > 5 files changed, 264 insertions(+), 41 deletions(-) > > > > -- > > 2.18.0 > > > > > -- > Tomáš Golembiovský <tgolembi@redhat.com>
Note that PCI controller reporting on Windows was and still is broken. Unfortunately I don't know how to fix it at the momemnt. See commit message and code comment. If anyone has environment where the original code works let me know. CCing author of the code In case I missed something obvious. v3: - fix typos - add configure test for libudev - change order of patches fixing PCI controller info and build fix to avoid exposing broken code - split reporting of serial number and device node into two separate patches v2: - fix checkpatch error Patches 1 and 3 are bug-fixes of existing code Patch 2 is optional and contains debug messages -- the windows QGA seriously lacks debug messages... Patch 4 adds reporting of disk serial number and device node of the disk. Tomáš Golembiovský (5): qga: win32: fix crashes when PCI info cannot be retrived build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI qga: win32: add debugging information qga: report disk serial number qga: return disk device in guest-get-fsinfo configure | 24 ++++- qga/Makefile.objs | 1 + qga/commands-posix.c | 27 +++++ qga/commands-win32.c | 248 ++++++++++++++++++++++++++++++++++++------- qga/qapi-schema.json | 5 +- 5 files changed, 264 insertions(+), 41 deletions(-)