| Message ID | cover.1529568501.git.balaton@eik.bme.hu |
|---|---|
| Headers | show |
| Series | Misc sm501 improvements | expand |
On Thu, Jun 21, 2018 at 10:08:21AM +0200, BALATON Zoltan wrote: > These are fixes to sm501 emulation that were found while testing with > AmigaOS 4.1FE (AmigaOS 4 is known to work on real hardware but we have > no way to verify it against hardware). While this is mainly to improve > sam460ex emulation this is now a separate series with the sm501 > specific patches because that's also used on SH emulation. I hope > someone can review and merge this. I'm not really familiar with the sm501 hardware, so I can't speak to these technically, beyond the fact that there's nothing obviously bogus. I can say that BALATON Zoltan is the only person who's made non-trivial changes to sm501 lately, and there don't seem to have been any screams, so I'm pretty happy to assume he knows what he's doing.
Hi Zoltan, On 06/21/2018 05:08 AM, BALATON Zoltan wrote: > These are fixes to sm501 emulation that were found while testing with > AmigaOS 4.1FE (AmigaOS 4 is known to work on real hardware but we have > no way to verify it against hardware). While this is mainly to improve Is it possible to fetch/use this image? (and add integration tests) > sam460ex emulation this is now a separate series with the sm501 > specific patches because that's also used on SH emulation. I hope > someone can review and merge this. > > BALATON Zoltan (3): > sm501: Implement i2c part for reading monitor EDID > sm501: Set updated region dirty after 2D operation > sm501: Fix support for non-zero frame buffer start address > > Sebastian Bauer (2): > sm501: Perform a full update after palette change > sm501: Use values from the pitch register for 2d operations. > > default-configs/ppc-softmmu.mak | 1 + > default-configs/ppcemb-softmmu.mak | 1 + > default-configs/sh4-softmmu.mak | 2 + > default-configs/sh4eb-softmmu.mak | 2 + > hw/display/sm501.c | 166 +++++++++++++++++++++++++++++++++++-- > 5 files changed, 163 insertions(+), 9 deletions(-) >
Cc'ing Gerd who maintains many hw/display/ files. On 06/21/2018 09:51 PM, David Gibson wrote: > On Thu, Jun 21, 2018 at 10:08:21AM +0200, BALATON Zoltan wrote: >> These are fixes to sm501 emulation that were found while testing with >> AmigaOS 4.1FE (AmigaOS 4 is known to work on real hardware but we have >> no way to verify it against hardware). While this is mainly to improve >> sam460ex emulation this is now a separate series with the sm501 >> specific patches because that's also used on SH emulation. I hope >> someone can review and merge this. [...] > hw/display/sm501.c | 166 +++++++++++++++++++++++++++++++++++-- > > I'm not really familiar with the sm501 hardware, so I can't speak to > these technically, beyond the fact that there's nothing obviously > bogus. > > I can say that BALATON Zoltan is the only person who's made > non-trivial changes to sm501 lately, and there don't seem to have been > any screams, so I'm pretty happy to assume he knows what he's doing. >
On Thu, 21 Jun 2018, Philippe Mathieu-Daudé wrote: > Hi Zoltan, > > On 06/21/2018 05:08 AM, BALATON Zoltan wrote: >> These are fixes to sm501 emulation that were found while testing with >> AmigaOS 4.1FE (AmigaOS 4 is known to work on real hardware but we have >> no way to verify it against hardware). While this is mainly to improve > > Is it possible to fetch/use this image? (and add integration tests) AmigaOS 4 is not freely available, it needs to be purchased so I'm not sure it could be used for tests. Also the current version available for Sam460 does not work too well with QEMU yet. To be able to use it according to Sebastian one needs at least updated ehci driver and maybe CLGD graphics driver which are not on this boot CD and editing the CD is not convenient or doable by most people. Therefore we are trying to fix QEMU with Sebastian to be usable with the current boot CD but maybe an updated CD with better drivers would be the way to go, although I don't know if the vendor wants to do that or not. Regards, BALATON Zoltan
On Thu, Jun 21, 2018 at 10:37:10PM -0300, Philippe Mathieu-Daudé wrote: > Cc'ing Gerd who maintains many hw/display/ files. > > On 06/21/2018 09:51 PM, David Gibson wrote: > > On Thu, Jun 21, 2018 at 10:08:21AM +0200, BALATON Zoltan wrote: > >> These are fixes to sm501 emulation that were found while testing with > >> AmigaOS 4.1FE (AmigaOS 4 is known to work on real hardware but we have > >> no way to verify it against hardware). While this is mainly to improve > >> sam460ex emulation this is now a separate series with the sm501 > >> specific patches because that's also used on SH emulation. I hope > >> someone can review and merge this. > [...] > > hw/display/sm501.c | 166 > +++++++++++++++++++++++++++++++++++-- > > > > I'm not really familiar with the sm501 hardware, so I can't speak to > > these technically, beyond the fact that there's nothing obviously > > bogus. > > > > I can say that BALATON Zoltan is the only person who's made > > non-trivial changes to sm501 lately, and there don't seem to have been > > any screams, so I'm pretty happy to assume he knows what he's doing. Changes all look sane to me even without having sm501 specs at hand. cheers, Gerd
On 06/22/2018 05:55 AM, BALATON Zoltan wrote: > On Thu, 21 Jun 2018, Philippe Mathieu-Daudé wrote: >> Hi Zoltan, >> >> On 06/21/2018 05:08 AM, BALATON Zoltan wrote: >>> These are fixes to sm501 emulation that were found while testing with >>> AmigaOS 4.1FE (AmigaOS 4 is known to work on real hardware but we have >>> no way to verify it against hardware). While this is mainly to improve >> >> Is it possible to fetch/use this image? (and add integration tests) > > AmigaOS 4 is not freely available, it needs to be purchased so I'm not > sure it could be used for tests. Also the current version available for > Sam460 does not work too well with QEMU yet. To be able to use it > according to Sebastian one needs at least updated ehci driver and maybe > CLGD graphics driver which are not on this boot CD and editing the CD is > not convenient or doable by most people. Therefore we are trying to fix > QEMU with Sebastian to be usable with the current boot CD but maybe an > updated CD with better drivers would be the way to go, although I don't > know if the vendor wants to do that or not. OK thanks for the explanation, I plan to add part of it somewhere in the wiki.