Message ID | cover.1529196703.git.keno@juliacomputing.com |
---|---|
Headers | show |
Series | 9p: Add support for Darwin | expand |
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1529196703.git.keno@juliacomputing.com Subject: [Qemu-devel] [PATCH v3 00/13] 9p: Add support for Darwin === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20180615194705.28019-1-alex.bennee@linaro.org -> patchew/20180615194705.28019-1-alex.bennee@linaro.org * [new tag] patchew/cover.1529196703.git.keno@juliacomputing.com -> patchew/cover.1529196703.git.keno@juliacomputing.com Switched to a new branch 'test' 4b8587ff41 9p: darwin: configure: Allow VirtFS on Darwin 6fca82963b 9p: darwin: virtfs-proxy: Implement setuid code for darwin da47c1cf4a 9p: darwin: Implement compatibility for mknodat 52eb0c76e0 9p: darwin: Provide a fallback implementation for utimensat 3d55eb845d 9p: darwin: Compatibility for f/l*xattr c1c235d3c0 9p: darwin: *xattr_nofollow implementations 28b7d5a3d9 9p: darwin: Provide a compatibility definition for XATTR_SIZE_MAX 100a9f6570 9p: darwin: Ignore O_{NOATIME, DIRECT} 8d93cfca8b 9p: darwin: Explicitly cast comparisons of mode_t with -1 6d83d8da90 9p: darwin: Handle struct dirent differences e5419933d4 9p: darwin: Handle struct stat(fs) differences 2c193d5f06 9p: Rename 9p-util -> 9p-util-linux 8fb0b6857d 9p: linux: Fix a couple Linux assumptions === OUTPUT BEGIN === Checking PATCH 1/13: 9p: linux: Fix a couple Linux assumptions... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #71: new file mode 100644 total: 0 errors, 1 warnings, 69 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 2/13: 9p: Rename 9p-util -> 9p-util-linux... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: rename from hw/9pfs/9p-util.c total: 0 errors, 1 warnings, 13 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/13: 9p: darwin: Handle struct stat(fs) differences... Checking PATCH 4/13: 9p: darwin: Handle struct dirent differences... Checking PATCH 5/13: 9p: darwin: Explicitly cast comparisons of mode_t with -1... Checking PATCH 6/13: 9p: darwin: Ignore O_{NOATIME, DIRECT}... Checking PATCH 7/13: 9p: darwin: Provide a compatibility definition for XATTR_SIZE_MAX... Checking PATCH 8/13: 9p: darwin: *xattr_nofollow implementations... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #14: new file mode 100644 total: 0 errors, 1 warnings, 71 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 9/13: 9p: darwin: Compatibility for f/l*xattr... Checking PATCH 10/13: 9p: darwin: Provide a fallback implementation for utimensat... WARNING: architecture specific defines should be avoided #60: FILE: hw/9pfs/9p-util-darwin.c:66: +#ifndef __has_builtin WARNING: architecture specific defines should be avoided #91: FILE: hw/9pfs/9p-util-darwin.c:97: +#if defined(__MAC_10_13) WARNING: architecture specific defines should be avoided #92: FILE: hw/9pfs/9p-util-darwin.c:98: +# if __MAC_OS_X_VERSION_MIN_REQUIRED >= __MAC_10_13 total: 0 errors, 3 warnings, 151 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 11/13: 9p: darwin: Implement compatibility for mknodat... ERROR: do not use C99 // comments #60: FILE: hw/9pfs/9p-util-darwin.c:166: +// This is an undocumented OS X syscall. It would be best to avoid it, ERROR: do not use C99 // comments #61: FILE: hw/9pfs/9p-util-darwin.c:167: +// but there doesn't seem to be another safe way to implement mknodat. ERROR: do not use C99 // comments #62: FILE: hw/9pfs/9p-util-darwin.c:168: +// Dear Apple, please implement mknodat before you remove this syscall. total: 3 errors, 0 warnings, 71 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 12/13: 9p: darwin: virtfs-proxy: Implement setuid code for darwin... Checking PATCH 13/13: 9p: darwin: configure: Allow VirtFS on Darwin... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com