Message ID | cover.1522769774.git.jan.kiszka@web.de |
---|---|
Headers | show |
Series | target-i386: Enhance SVM support | expand |
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1522769774.git.jan.kiszka@web.de Subject: [Qemu-devel] [PATCH v2 0/4] target-i386: Enhance SVM support === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/cover.1522769774.git.jan.kiszka@web.de -> patchew/cover.1522769774.git.jan.kiszka@web.de Switched to a new branch 'test' 9cbe95251e target-i386: Add NPT support 8880b9be5d target-i386: Mark cpu_vmexit noreturn 2913fc90bf target-i386: Allow interrupt injection after STGI 7c59f09518 target-i386: Add NMI interception to SVM === OUTPUT BEGIN === Checking PATCH 1/4: target-i386: Add NMI interception to SVM... Checking PATCH 2/4: target-i386: Allow interrupt injection after STGI... Checking PATCH 3/4: target-i386: Mark cpu_vmexit noreturn... Checking PATCH 4/4: target-i386: Add NPT support... ERROR: braces {} are necessary for all arms of this statement #104: FILE: target/i386/excp_helper.c:184: + if (env->nested_pg_mode & SVM_NPT_LMA) { [...] + } else [...] total: 1 errors, 0 warnings, 394 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On 2018-04-03 17:36, Jan Kiszka wrote: > These patches allow to run Jailhouse in emulated x86-64 mode under QEMU. > AMD IOMMU only works with one additional hack, but that's a different > story, and we can test these changes without it. > > Change in v2: > - build fix for 32-bit hosts > - replaces NPT exitinfo magics with symbolic constants > > Jan > > Jan Kiszka (4): > target-i386: Add NMI interception to SVM > target-i386: Allow interrupt injection after STGI > target-i386: Mark cpu_vmexit noreturn > target-i386: Add NPT support > > target/i386/cpu.c | 2 +- > target/i386/cpu.h | 10 ++- > target/i386/excp_helper.c | 216 +++++++++++++++++++++++++++++++++++++++++++++- > target/i386/mem_helper.c | 6 +- > target/i386/seg_helper.c | 1 + > target/i386/svm.h | 14 +++ > target/i386/svm_helper.c | 23 +++++ > target/i386/translate.c | 3 +- > 8 files changed, 266 insertions(+), 9 deletions(-) > Ping on this series. Jan