| Message ID | 20240221094317.994454-1-zhao1.liu@linux.intel.com |
|---|---|
| Headers | show |
| Series | Fix missing ERRP_GUARD() when dereference @errp | expand |
21.02.2024 12:43, Zhao Liu wrote: > From: Zhao Liu <zhao1.liu@intel.com> > > Hi all, > > Thanks to Markus's explanation about ERRP_GUARD() on my previsou > patch [1], > > I realize that perhaps more @errp dereference cases need to be > double-checked to ensure that ERRP_GUARD() is being used correctly. > > Therefore, there're the patches to add more missing ERRP_GUARD(). > > [1]: https://lore.kernel.org/qemu-devel/875xz0ojg7.fsf@pond.sub.org/ Hi! Since you're going to respin (it looks like), please include the initial patch (hw/intc one) into the series as well, so it's all in one go. I'm not sure this should come via trivial-patches tree though. Looks trivial enough :) /mjt
On Thu, Feb 22, 2024 at 09:04:14AM +0300, Michael Tokarev wrote: > Date: Thu, 22 Feb 2024 09:04:14 +0300 > From: Michael Tokarev <mjt@tls.msk.ru> > Subject: Re: [PATCH 0/6] [PATCH 0/6] Fix missing ERRP_GUARD() when > dereference @errp > > 21.02.2024 12:43, Zhao Liu wrote: > > From: Zhao Liu <zhao1.liu@intel.com> > > > > Hi all, > > > > Thanks to Markus's explanation about ERRP_GUARD() on my previsou > > patch [1], > > > > I realize that perhaps more @errp dereference cases need to be > > double-checked to ensure that ERRP_GUARD() is being used correctly. > > > > Therefore, there're the patches to add more missing ERRP_GUARD(). > > > > [1]: https://lore.kernel.org/qemu-devel/875xz0ojg7.fsf@pond.sub.org/ > > Hi! > > Since you're going to respin (it looks like), please include the initial > patch (hw/intc one) into the series as well, so it's all in one go. > > I'm not sure this should come via trivial-patches tree though. Looks > trivial enough :) > Hi Michael, Sure, I'll add that one into this series. I understand that such small fixes across multiple parts are suited for trivial-tree. Thanks, Zhao
From: Zhao Liu <zhao1.liu@intel.com> Hi all, Thanks to Markus's explanation about ERRP_GUARD() on my previsou patch [1], I realize that perhaps more @errp dereference cases need to be double-checked to ensure that ERRP_GUARD() is being used correctly. Therefore, there're the patches to add more missing ERRP_GUARD(). [1]: https://lore.kernel.org/qemu-devel/875xz0ojg7.fsf@pond.sub.org/ Thanks and Best Regards, Zhao --- Zhao Liu (6): hw/cxl/cxl-host: Fix missing ERRP_GUARD() in cxl_fixed_memory_window_config() hw/display/macfb: Fix missing ERRP_GUARD() in macfb_nubus_realize() hw/mem/cxl_type3: Fix missing ERRP_GUARD() in ct3_realize() hw/misc/xlnx-versal-trng: Fix missing ERRP_GUARD() in trng_prop_fault_event_set() hw/pci-bridge/cxl_upstream: Fix missing ERRP_GUARD() in cxl_usp_realize() hw/vfio/iommufd: Fix missing ERRP_GUARD() in iommufd_cdev_getfd() hw/cxl/cxl-host.c | 1 + hw/display/macfb.c | 1 + hw/mem/cxl_type3.c | 1 + hw/misc/xlnx-versal-trng.c | 2 ++ hw/pci-bridge/cxl_upstream.c | 1 + hw/vfio/iommufd.c | 1 + 6 files changed, 7 insertions(+)