From patchwork Mon Jan 22 14:55:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 1889224 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=hvITcoeQ; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TJYMW04zZz23fx for ; Tue, 23 Jan 2024 02:01:27 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rRvik-0006uW-0T; Mon, 22 Jan 2024 09:56:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRvii-0006sO-Qm for qemu-devel@nongnu.org; Mon, 22 Jan 2024 09:56:16 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rRvif-0008Fe-80 for qemu-devel@nongnu.org; Mon, 22 Jan 2024 09:56:16 -0500 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-40ea5653f6bso25827895e9.3 for ; Mon, 22 Jan 2024 06:56:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705935371; x=1706540171; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bb/KYUiaTsna6vJuXI/9siaZWs98wLSaDxs6Hv4zkgU=; b=hvITcoeQlSeCKT9LdMy8mjY5iVSspcsqj2SAKpr5MU++7/9A5hq7BfWvQ5CtIr3yDW RRNmBC7ZOjYkpYoB2PTWWw1+5UhCY+QEmK9r5MjgGmplS7ix3U9Ga3yQA029cRme9kas yzNn3UcC6oPVhusn4PtyLHugUm4qwlv1WMvdJbfGslwyYLuPYvGh2borAVTbazmO8It7 nwjHmJnhkm7xqkUmgnGmxAi1SWnxt9+5sy6gf6QGPTec5wR/Oi71Qwfy3nJxS38Ji3Us BjnwaPA70qxeByzKl6dxby9sUToH0nSqIi/D9jCsFJrqcD05026LTJAstparSy/JcI/l 8fSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705935371; x=1706540171; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bb/KYUiaTsna6vJuXI/9siaZWs98wLSaDxs6Hv4zkgU=; b=cNmxwEkQIcU/jjScI6SbYfiWtilwvPnGbqAfmKIwA5MCOmCrJQlcic+TDBWAgXN1PD kvOfp0m6tZeDCDse3Ej3NdosnAvK7qQ52DcFoAXmMCA+MzckGTmJARL8KfH796jx6+bs zobISLjnQLAB8ZbNlZlERE1m3hOILlMDGnd6ldzAXZ2exyyVrBLBRGgiHR8EUj1Hkpm6 cTl+31Mh0la962mjJvGbwMoVpgCxgtocLLUQ+gwcJzE5M+DQNKPABiJyxPqJ2THZ61aQ sFfmwNKvlxs6QALIIpcT7PqlEbrd8hbus5QD7iEuPBtdHlp2yoaPYdGYI5I068CJELnl vZRg== X-Gm-Message-State: AOJu0Yz2VuiOYEc3E8JKOY8AKpIY1nHwUr5ve55k0SfWTsjL009pi11o sVAQwhmtUnjJ/0NcOj+TXX5nQ7bsxPbkYbuz6PEUU8AI5j0MdoY1k11SVWedMUk= X-Google-Smtp-Source: AGHT+IFRKwbXocgaijT07IhMJdnHqOsm5/GOB25FwCO0EZ5jJroK5Ak40g+nI35wW91C50qu6kEv6g== X-Received: by 2002:a05:600c:21d1:b0:40e:3b3f:51eb with SMTP id x17-20020a05600c21d100b0040e3b3f51ebmr2307292wmj.81.1705935371471; Mon, 22 Jan 2024 06:56:11 -0800 (PST) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id m4-20020a5d64a4000000b003392e05fb3esm4592744wrp.24.2024.01.22.06.56.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 06:56:11 -0800 (PST) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id C42EF5F7AE; Mon, 22 Jan 2024 14:56:10 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum , "Edgar E. Iglesias" , =?utf-8?q?Philippe_Mathieu-?= =?utf-8?q?Daud=C3=A9?= , Michael Rolnik , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Laurent Vivier , kvm@vger.kernel.org, Yoshinori Sato , Pierrick Bouvier , Palmer Dabbelt , Liu Zhiwei , Laurent Vivier , Yanan Wang , qemu-ppc@nongnu.org, Weiwei Li , qemu-s390x@nongnu.org, =?utf-8?q?Alex_Benn=C3=A9e?= , =?utf-8?q?C=C3=A9dri?= =?utf-8?q?c_Le_Goater?= , Peter Maydell , Alexandre Iooss , John Snow , Mahmoud Mandour , Wainer dos Santos Moschetta , Richard Henderson , Ilya Leoshkevich , Alistair Francis , David Woodhouse , Cleber Rosa , Beraldo Leal , Bin Meng , Nicholas Piggin , Aurelien Jarno , Daniel Henrique Barboza , Daniel Henrique Barboza , Thomas Huth , David Hildenbrand , qemu-riscv@nongnu.org, qemu-arm@nongnu.org, Paolo Bonzini , Song Gao , Eduardo Habkost , Brian Cain , Paul Durrant Subject: [PATCH v3 00/21] plugin updates (register access) for 9.0 (pre-PR?) Date: Mon, 22 Jan 2024 14:55:49 +0000 Message-Id: <20240122145610.413836-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Akihiko requested the register support not be merged in its current state so it's time for another round of review. I've made a few tweaks to simplify the register and CPU tracking code in execlog and removed some stale API functions. However from my point of view its ready to merge. v3 --- - split from testing bits (merged) - removed unused api funcs - keep CPUs in a GArray instead of doing by hand v2 -- - Review feedback for register API - readthedocs update - add expectation docs for plugins The following still need review: contrib/plugins: extend execlog to track register changes gdbstub: expose api to find registers Akihiko Odaki (15): hw/riscv: Use misa_mxl instead of misa_mxl_max target/riscv: Remove misa_mxl validation target/riscv: Move misa_mxl_max to class target/riscv: Validate misa_mxl_max only once target/arm: Use GDBFeature for dynamic XML target/ppc: Use GDBFeature for dynamic XML target/riscv: Use GDBFeature for dynamic XML gdbstub: Use GDBFeature for gdb_register_coprocessor gdbstub: Use GDBFeature for GDBRegisterState gdbstub: Change gdb_get_reg_cb and gdb_set_reg_cb gdbstub: Simplify XML lookup gdbstub: Infer number of core registers from XML hw/core/cpu: Remove gdb_get_dynamic_xml member gdbstub: Add members to identify registers to GDBFeature plugins: Use different helpers when reading registers Alex Bennée (6): gdbstub: expose api to find registers plugins: add an API to read registers contrib/plugins: fix imatch contrib/plugins: extend execlog to track register changes docs/devel: lift example and plugin API sections up docs/devel: document some plugin assumptions docs/devel/tcg-plugins.rst | 72 +++++++- accel/tcg/plugin-helpers.h | 3 +- include/exec/gdbstub.h | 43 ++++- include/hw/core/cpu.h | 7 +- include/qemu/plugin.h | 1 + include/qemu/qemu-plugin.h | 51 +++++- target/arm/cpu.h | 27 ++- target/arm/internals.h | 14 +- target/hexagon/internal.h | 4 +- target/microblaze/cpu.h | 4 +- target/ppc/cpu-qom.h | 1 + target/ppc/cpu.h | 5 +- target/riscv/cpu.h | 9 +- target/s390x/cpu.h | 2 - accel/tcg/plugin-gen.c | 43 ++++- contrib/plugins/execlog.c | 319 +++++++++++++++++++++++++++++------ gdbstub/gdbstub.c | 169 +++++++++++-------- hw/core/cpu-common.c | 5 +- hw/riscv/boot.c | 2 +- plugins/api.c | 123 +++++++++++++- target/arm/cpu.c | 2 - target/arm/cpu64.c | 1 - target/arm/gdbstub.c | 230 ++++++++++++------------- target/arm/gdbstub64.c | 122 +++++++------- target/avr/cpu.c | 1 - target/hexagon/cpu.c | 4 +- target/hexagon/gdbstub.c | 10 +- target/i386/cpu.c | 2 - target/loongarch/cpu.c | 2 - target/loongarch/gdbstub.c | 13 +- target/m68k/cpu.c | 1 - target/m68k/helper.c | 26 ++- target/microblaze/cpu.c | 6 +- target/microblaze/gdbstub.c | 9 +- target/ppc/cpu_init.c | 7 - target/ppc/gdbstub.c | 114 +++++++------ target/riscv/cpu.c | 193 +++++++++++---------- target/riscv/gdbstub.c | 151 +++++++++-------- target/riscv/kvm/kvm-cpu.c | 10 +- target/riscv/machine.c | 7 +- target/riscv/tcg/tcg-cpu.c | 44 +---- target/riscv/translate.c | 3 +- target/rx/cpu.c | 1 - target/s390x/cpu.c | 1 - target/s390x/gdbstub.c | 105 +++++++----- plugins/qemu-plugins.symbols | 2 + scripts/feature_to_c.py | 14 +- 47 files changed, 1287 insertions(+), 698 deletions(-)