mbox series

[v1,0/3] Refactor PPI logic/definitions for virt/sbsa-ref

Message ID 20230915115535.129834-1-quic_llindhol@quicinc.com
Headers show
Series Refactor PPI logic/definitions for virt/sbsa-ref | expand

Message

Leif Lindholm Sept. 15, 2023, 11:55 a.m. UTC 
This set reworks the handling of private peripheral interrupts in virt
to use INTIDs instead of PPI IDs, to make it easier to cross reference
against Arm's Base System Architecture specification.

It then breaks those definitions out into a separate header and switches
sbsa-ref to use the same header instead of defining its own values
locally.

Changes since RFC:
- Compilation tested
- Reordered patches 1-2 as suggested by Philippe.

Leif Lindholm (3):
  {include/}hw/arm: refactor virt PPI logic
  include/hw/arm: move BSA definitions to bsa.h
  hw/arm/sbsa-ref: use bsa.h for PPI definitions

 hw/arm/sbsa-ref.c        | 23 +++++++++++------------
 hw/arm/virt-acpi-build.c |  4 ++--
 hw/arm/virt.c            |  9 +++++----
 include/hw/arm/bsa.h     | 35 +++++++++++++++++++++++++++++++++++
 include/hw/arm/virt.h    | 12 +-----------
 5 files changed, 54 insertions(+), 29 deletions(-)
 create mode 100644 include/hw/arm/bsa.h

Comments

Marcin Juszkiewicz Sept. 15, 2023, 12:04 p.m. UTC | #1 
W dniu 15.09.2023 o 13:55, Leif Lindholm pisze:
> This set reworks the handling of private peripheral interrupts in virt
> to use INTIDs instead of PPI IDs, to make it easier to cross reference
> against Arm's Base System Architecture specification.
> 
> It then breaks those definitions out into a separate header and switches
> sbsa-ref to use the same header instead of defining its own values
> locally.
> 
> Changes since RFC:
> - Compilation tested
> - Reordered patches 1-2 as suggested by Philippe.
> 
> Leif Lindholm (3):
>    {include/}hw/arm: refactor virt PPI logic
>    include/hw/arm: move BSA definitions to bsa.h
>    hw/arm/sbsa-ref: use bsa.h for PPI definitions
> 
>   hw/arm/sbsa-ref.c        | 23 +++++++++++------------
>   hw/arm/virt-acpi-build.c |  4 ++--
>   hw/arm/virt.c            |  9 +++++----
>   include/hw/arm/bsa.h     | 35 +++++++++++++++++++++++++++++++++++
>   include/hw/arm/virt.h    | 12 +-----------
>   5 files changed, 54 insertions(+), 29 deletions(-)
>   create mode 100644 include/hw/arm/bsa.h
> 

Tested-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Reviewed-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>