| Message ID | 20230710094931.84402-1-philmd@linaro.org |
|---|---|
| Headers | show |
| Series | hw/virtio: Build vhost-vdpa.o once for all targets | expand |
Hi Michael, This series is now fully reviewed. On 10/7/23 11:49, Philippe Mathieu-Daudé wrote: > Missing review: patch #4 > > Since v2: > - Added R-b tags > - Addressed Richard's review comment: page_mask = -page_size > > Philippe Mathieu-Daudé (6): > hw/virtio: Propagate page_mask to > vhost_vdpa_listener_skipped_section() > hw/virtio: Propagate page_mask to vhost_vdpa_section_end() > hw/virtio/vhost-vdpa: Inline TARGET_PAGE_ALIGN() macro > hw/virtio/vhost-vdpa: Use target-agnostic qemu_target_page_mask() > hw/virtio: Build vhost-vdpa.o once > hw/virtio/meson: Rename softmmu_virtio_ss[] -> system_virtio_ss[] > > hw/virtio/vhost-vdpa.c | 36 +++++++++++++++++++++--------------- > hw/virtio/meson.build | 25 +++++++++++++------------ > 2 files changed, 34 insertions(+), 27 deletions(-) >
On 30/8/23 15:35, Philippe Mathieu-Daudé wrote: > Hi Michael, > > This series is now fully reviewed. > > On 10/7/23 11:49, Philippe Mathieu-Daudé wrote: >> Missing review: patch #4 >> >> Since v2: >> - Added R-b tags >> - Addressed Richard's review comment: page_mask = -page_size >> >> Philippe Mathieu-Daudé (6): >> hw/virtio: Propagate page_mask to >> vhost_vdpa_listener_skipped_section() >> hw/virtio: Propagate page_mask to vhost_vdpa_section_end() >> hw/virtio/vhost-vdpa: Inline TARGET_PAGE_ALIGN() macro >> hw/virtio/vhost-vdpa: Use target-agnostic qemu_target_page_mask() >> hw/virtio: Build vhost-vdpa.o once >> hw/virtio/meson: Rename softmmu_virtio_ss[] -> system_virtio_ss[] Michael, I have another series unifying virtio endianness blocked by this one. I can merge it if you provide your Ack-by. Thanks, Phil.
Hi Michael, On 6/9/23 08:31, Philippe Mathieu-Daudé wrote: > On 30/8/23 15:35, Philippe Mathieu-Daudé wrote: >> >> This series is now fully reviewed. >> >> On 10/7/23 11:49, Philippe Mathieu-Daudé wrote: >>> Missing review: patch #4 >>> >>> Since v2: >>> - Added R-b tags >>> - Addressed Richard's review comment: page_mask = -page_size >>> >>> Philippe Mathieu-Daudé (6): >>> hw/virtio: Propagate page_mask to >>> vhost_vdpa_listener_skipped_section() >>> hw/virtio: Propagate page_mask to vhost_vdpa_section_end() >>> hw/virtio/vhost-vdpa: Inline TARGET_PAGE_ALIGN() macro >>> hw/virtio/vhost-vdpa: Use target-agnostic qemu_target_page_mask() >>> hw/virtio: Build vhost-vdpa.o once >>> hw/virtio/meson: Rename softmmu_virtio_ss[] -> system_virtio_ss[] > > Michael, I have another series unifying virtio endianness blocked > by this one. I can merge it if you provide your Ack-by. Unless you object, I'll merge this series. Since we are early enough in the development window, if something breaks, we'll catch it in time and fix or revert. Regards, Phil.
On Mon, Sep 18, 2023 at 12:42:02PM +0200, Philippe Mathieu-Daudé wrote: > Hi Michael, > > On 6/9/23 08:31, Philippe Mathieu-Daudé wrote: > > On 30/8/23 15:35, Philippe Mathieu-Daudé wrote: > > > > > > This series is now fully reviewed. > > > > > > On 10/7/23 11:49, Philippe Mathieu-Daudé wrote: > > > > Missing review: patch #4 > > > > > > > > Since v2: > > > > - Added R-b tags > > > > - Addressed Richard's review comment: page_mask = -page_size > > > > > > > > Philippe Mathieu-Daudé (6): > > > > hw/virtio: Propagate page_mask to > > > > vhost_vdpa_listener_skipped_section() > > > > hw/virtio: Propagate page_mask to vhost_vdpa_section_end() > > > > hw/virtio/vhost-vdpa: Inline TARGET_PAGE_ALIGN() macro > > > > hw/virtio/vhost-vdpa: Use target-agnostic qemu_target_page_mask() > > > > hw/virtio: Build vhost-vdpa.o once > > > > hw/virtio/meson: Rename softmmu_virtio_ss[] -> system_virtio_ss[] > > > > Michael, I have another series unifying virtio endianness blocked > > by this one. I can merge it if you provide your Ack-by. > > Unless you object, I'll merge this series. Since we are early enough > in the development window, if something breaks, we'll catch it in > time and fix or revert. > > Regards, > > Phil. It's actually in my tree, and should go out in a couple of days finally.
Missing review: patch #4 Since v2: - Added R-b tags - Addressed Richard's review comment: page_mask = -page_size Philippe Mathieu-Daudé (6): hw/virtio: Propagate page_mask to vhost_vdpa_listener_skipped_section() hw/virtio: Propagate page_mask to vhost_vdpa_section_end() hw/virtio/vhost-vdpa: Inline TARGET_PAGE_ALIGN() macro hw/virtio/vhost-vdpa: Use target-agnostic qemu_target_page_mask() hw/virtio: Build vhost-vdpa.o once hw/virtio/meson: Rename softmmu_virtio_ss[] -> system_virtio_ss[] hw/virtio/vhost-vdpa.c | 36 +++++++++++++++++++++--------------- hw/virtio/meson.build | 25 +++++++++++++------------ 2 files changed, 34 insertions(+), 27 deletions(-)