mbox series

[0/2] PC: Create RTC controllers in south bridges

Message ID 20230519084734.220480-1-shentey@gmail.com
Headers show
Series PC: Create RTC controllers in south bridges | expand

Message

Bernhard Beschow May 19, 2023, 8:47 a.m. UTC 
This series contains two patches originating from the PIIX consolidation series
[1]. Since the two patches represent general PC code modernization (ICH9 is
modernized as well) and since the PIIX consolidation series is still under
discussion it made sense to split off these patches.

Testing done:
* `make check`
* `make check-avocado`

[1] https://lore.kernel.org/qemu-devel/20230518172747-mutt-send-email-mst@kernel.org/

Bernhard Beschow (2):
  hw/i386/pc: Create RTC controllers in south bridges
  hw/i386/pc: No need for rtc_state to be an out-parameter

 include/hw/i386/pc.h          |  2 +-
 include/hw/southbridge/ich9.h |  2 ++
 include/hw/southbridge/piix.h |  3 +++
 hw/i386/pc.c                  | 16 +++++++++++++---
 hw/i386/pc_piix.c             | 10 +++++++++-
 hw/i386/pc_q35.c              |  4 +++-
 hw/isa/lpc_ich9.c             |  8 ++++++++
 hw/isa/piix3.c                | 15 +++++++++++++++
 hw/isa/Kconfig                |  2 ++
 9 files changed, 56 insertions(+), 6 deletions(-)

Comments

Mark Cave-Ayland May 25, 2023, 3:50 p.m. UTC | #1 
On 19/05/2023 09:47, Bernhard Beschow wrote:

> This series contains two patches originating from the PIIX consolidation series
> [1]. Since the two patches represent general PC code modernization (ICH9 is
> modernized as well) and since the PIIX consolidation series is still under
> discussion it made sense to split off these patches.
> 
> Testing done:
> * `make check`
> * `make check-avocado`
> 
> [1] https://lore.kernel.org/qemu-devel/20230518172747-mutt-send-email-mst@kernel.org/
> 
> Bernhard Beschow (2):
>    hw/i386/pc: Create RTC controllers in south bridges
>    hw/i386/pc: No need for rtc_state to be an out-parameter
> 
>   include/hw/i386/pc.h          |  2 +-
>   include/hw/southbridge/ich9.h |  2 ++
>   include/hw/southbridge/piix.h |  3 +++
>   hw/i386/pc.c                  | 16 +++++++++++++---
>   hw/i386/pc_piix.c             | 10 +++++++++-
>   hw/i386/pc_q35.c              |  4 +++-
>   hw/isa/lpc_ich9.c             |  8 ++++++++
>   hw/isa/piix3.c                | 15 +++++++++++++++
>   hw/isa/Kconfig                |  2 ++
>   9 files changed, 56 insertions(+), 6 deletions(-)

These look good to me:

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.