mbox series

[PULL,SUBSYSTEM,arm,0/8] TivaC Implementation

Message ID 20230516072959.49994-1-m.elsayed4420@gmail.com
Headers show
Series TivaC Implementation | expand

Message

Mohamed ElSayed May 16, 2023, 7:29 a.m. UTC 
***
This is an implementation for the TivaC board.
For now it models the system control block, the general purpose I/O, the general purpose timers, the watchdog timers and the usart module.

The code is available at https://github.com/moesay/qemu_TivaC.git
***

Mohamed ElSayed (8):
  the tivac machine def initial commit
  tivac usart module implementation
  tivac gpio module implementation
  tivac system control implementation
  tivac general purpose timers implementation
  tivac watchdog timers implementation
  editing the meson and KConfig files to add tivac to qemu build system
  code style fixes

 .gitignore                              |   1 +
 README.rst                              | 150 +---
 configs/devices/arm-softmmu/default.mak |   1 +
 hw/arm/Kconfig                          |  13 +
 hw/arm/meson.build                      |   3 +
 hw/arm/tivac.c                          |  56 ++
 hw/arm/tm4c123gh6pm_soc.c               | 276 +++++++
 hw/char/Kconfig                         |   3 +
 hw/char/meson.build                     |   1 +
 hw/char/tm4c123_usart.c                 | 383 +++++++++
 hw/char/trace-events                    |   4 +
 hw/gpio/Kconfig                         |   3 +
 hw/gpio/meson.build                     |   1 +
 hw/gpio/tm4c123_gpio.c                  | 372 +++++++++
 hw/gpio/trace-events                    |   4 +
 hw/misc/Kconfig                         |   3 +
 hw/misc/meson.build                     |   1 +
 hw/misc/tm4c123_sysctl.c                | 989 ++++++++++++++++++++++++
 hw/misc/trace-events                    |   5 +
 hw/timer/Kconfig                        |   3 +
 hw/timer/meson.build                    |   1 +
 hw/timer/tm4c123_gptm.c                 | 495 ++++++++++++
 hw/timer/trace-events                   |   5 +
 hw/watchdog/Kconfig                     |   3 +
 hw/watchdog/meson.build                 |   1 +
 hw/watchdog/tm4c123_watchdog.c          | 297 +++++++
 hw/watchdog/trace-events                |   3 +
 include/hw/arm/tm4c123gh6pm_soc.h       |  71 ++
 include/hw/char/tm4c123_usart.h         | 124 +++
 include/hw/gpio/tm4c123_gpio.h          | 127 +++
 include/hw/misc/tm4c123_sysctl.h        | 307 ++++++++
 include/hw/timer/tm4c123_gptm.h         | 131 ++++
 include/hw/watchdog/tm4c123_watchdog.h  |  97 +++
 33 files changed, 3797 insertions(+), 137 deletions(-)
 create mode 100644 hw/arm/tivac.c
 create mode 100644 hw/arm/tm4c123gh6pm_soc.c
 create mode 100644 hw/char/tm4c123_usart.c
 create mode 100644 hw/gpio/tm4c123_gpio.c
 create mode 100644 hw/misc/tm4c123_sysctl.c
 create mode 100644 hw/timer/tm4c123_gptm.c
 create mode 100644 hw/watchdog/tm4c123_watchdog.c
 create mode 100644 include/hw/arm/tm4c123gh6pm_soc.h
 create mode 100644 include/hw/char/tm4c123_usart.h
 create mode 100644 include/hw/gpio/tm4c123_gpio.h
 create mode 100644 include/hw/misc/tm4c123_sysctl.h
 create mode 100644 include/hw/timer/tm4c123_gptm.h
 create mode 100644 include/hw/watchdog/tm4c123_watchdog.h

--
2.34.1

Comments

Alex Bennée May 16, 2023, 9 a.m. UTC | #1 
Mohamed ElSayed <m.elsayed4420@gmail.com> writes:

> ***
> This is an implementation for the TivaC board.
> For now it models the system control block, the general purpose I/O, the general purpose timers, the watchdog timers and the usart module.
>
> The code is available at https://github.com/moesay/qemu_TivaC.git
> ***

Hi Mohamed,

I'm afraid this pull request won't get processed. Pull requests are sent
by maintainers who are listed in the MAINTAINERS file with signed PRs.
If you want to get support for the TivacC board up-streamed you should
post a series of patches and participate in code review. We have some
general guidance for the process here:

  https://qemu.readthedocs.io/en/latest/devel/submitting-a-patch.html

A couple of general points to get you started:

 - patch 7

   This is obviously wrong as it updates the project README with your
   personal fork information.

 - patch 8

   code format fixes to your own code should be folded into the relevant commit

 - use of qemu_log

   direct use of qemu_log is discouraged. Generally for devices you
   would be using qemu_log_mask with LOG_UNIMP or LOG_GUEST_ERROR as
   appropriate. Think about if the log point would be better handled at
   a tracepoint (or removed completely if it was a debugging aid during
   development).