From patchwork Fri Apr 28 19:49:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Sementsov-Ogievskiy X-Patchwork-Id: 1775145 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru header.a=rsa-sha256 header.s=default header.b=1FfOWV55; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Q7NWr1th3z23tZ for ; Sat, 29 Apr 2023 05:51:04 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1psU6U-0000rS-EN; Fri, 28 Apr 2023 15:50:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psU6R-0000q5-RG for qemu-devel@nongnu.org; Fri, 28 Apr 2023 15:49:59 -0400 Received: from forwardcorp1b.mail.yandex.net ([178.154.239.136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psU6H-00011z-LP for qemu-devel@nongnu.org; Fri, 28 Apr 2023 15:49:56 -0400 Received: from mail-nwsmtp-smtp-corp-main-26.myt.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-26.myt.yp-c.yandex.net [IPv6:2a02:6b8:c12:369a:0:640:c31a:0]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTP id F011B60C9D; Fri, 28 Apr 2023 22:49:39 +0300 (MSK) Received: from vsementsov-nix.yandex-team.ru (unknown [2a02:6b8:b081:b432::1:18]) by mail-nwsmtp-smtp-corp-main-26.myt.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id TnPWb50Oca60-el1yiHkL; Fri, 28 Apr 2023 22:49:39 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1682711379; bh=VbDGJKYsvC6dHONbPPc760HpzEYXR2bPJgvBFhDNsak=; h=Message-Id:Date:Cc:Subject:To:From; b=1FfOWV55bjyq7uaIFrxEpUhrLkc0QkiogL0PxF+fbmId4lq/XyxaIFgH9TKAX+NXJ 4qtpbfcGENujfY8/rPL5qDWMgdOvzASt0Ic8+TOVubT1eunVM8YN8D+pv+fABgsEtO 6kB114VeLSIWOa9QLnLLBgzllXHQsPzRdyoregws= Authentication-Results: mail-nwsmtp-smtp-corp-main-26.myt.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Cc: lukasstraub2@web.de, quintela@redhat.com, chen.zhang@intel.com, vsementsov@yandex-team.ru Subject: [PATCH v4 00/10] COLO: improve build options Date: Fri, 28 Apr 2023 22:49:18 +0300 Message-Id: <20230428194928.1426370-1-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Received-SPF: pass client-ip=178.154.239.136; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1b.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org v4: 01: add r-b by Lukas 02: new 03: - keep x-colo capability enum value unconditional - drop ifdefs in options.c and keep capability check instead - update stubs - add missed a-b by Dr. David 04: keep filter-mirror untouched, add r-b by Juan others: new. Some further improvements of COLO module API. May be merged separately. Hi all! COLO substem seems to be useless when CONFIG_REPLICATION is unset, as we simply don't allow to set x-colo capability in this case. So, let's not compile in unreachable code and interface we cannot use when CONFIG_REPLICATION is unset. Also, provide personal configure option for COLO Proxy subsystem. Vladimir Sementsov-Ogievskiy (10): block/meson.build: prefer positive condition for replication colo: make colo_checkpoint_notify static and provide simpler API build: move COLO under CONFIG_REPLICATION configure: add --disable-colo-proxy option migration: drop colo_incoming_thread from MigrationIncomingState migration: process_incoming_migration_co: simplify code flow around ret migration: split migration_incoming_co migration: process_incoming_migration_co(): move colo part to colo migration: disallow change capabilities in COLO state migration: block incoming colo when capability is disabled block/meson.build | 2 +- hmp-commands.hx | 2 + include/migration/colo.h | 18 +++++- meson_options.txt | 2 + migration/colo.c | 100 +++++++++++++++++++-------------- migration/meson.build | 6 +- migration/migration-hmp-cmds.c | 2 + migration/migration.c | 51 +++++++---------- migration/migration.h | 11 +++- migration/options.c | 6 +- net/meson.build | 13 ++++- qapi/migration.json | 9 ++- scripts/meson-buildoptions.sh | 3 + stubs/colo-compare.c | 7 +++ stubs/colo.c | 37 ++++++++++++ stubs/meson.build | 2 + 16 files changed, 181 insertions(+), 90 deletions(-) create mode 100644 stubs/colo-compare.c create mode 100644 stubs/colo.c