Message ID | 20230425070248.2550028-1-gaosong@loongson.cn |
---|---|
Headers | show |
Series | Add LoongArch LSX instructions | expand |
On 4/25/23 08:02, Song Gao wrote: > Hi, > > This series adds LoongArch LSX instructions, Since the LoongArch > Vol2 is not open, So we use 'RFC' title. > > I'm not sure when the manual will be open. > After these patches are reviewed, how about merging them? > > About test: > V2 we use RISU test the LoongArch LSX instructions. > > QEMU: > https://github.com/loongson/qemu/tree/tcg-old-abi-support-lsx > RISU: > https://github.com/loongson/risu/tree/loongarch-suport-lsx > > Build test: > make docker-test-build@fedora-i386-cross > > The following patches need to be reviewed: > 0001-target-loongarch-Add-LSX-data-type-VReg.patch > 0014-target-loongarch-Implement-vmul-vmuh-vmulw-ev-od.patch > 0030-target-loongarch-Implement-vpcnt.patch > 0034-target-loongarch-Implement-LSX-fpu-fcvt-instructions.patch > 0037-target-loongarch-Implement-vbitsel-vset.patch > 0041-target-loongarch-Implement-vld-vst.patch > > V4: > - R-b and rebase; > - Migrate the upper half lsx regs; > - Remove tcg_gen_mulus2_*; > - Vsetallnez use !do_match2; > - Use tcg_gen_concat_i64_i128/tcg_gen_extr_i128_i64 to replace > TCGV128_LOW(val)/TCGV128_High(val); One minor nit, everything reviewed! Congratulations. r~
在 2023/5/2 上午2:43, Richard Henderson 写道: > On 4/25/23 08:02, Song Gao wrote: >> Hi, >> >> This series adds LoongArch LSX instructions, Since the LoongArch >> Vol2 is not open, So we use 'RFC' title. >> >> I'm not sure when the manual will be open. >> After these patches are reviewed, how about merging them? >> >> About test: >> V2 we use RISU test the LoongArch LSX instructions. >> >> QEMU: >> https://github.com/loongson/qemu/tree/tcg-old-abi-support-lsx >> RISU: >> https://github.com/loongson/risu/tree/loongarch-suport-lsx >> >> Build test: >> make docker-test-build@fedora-i386-cross >> >> The following patches need to be reviewed: >> 0001-target-loongarch-Add-LSX-data-type-VReg.patch >> 0014-target-loongarch-Implement-vmul-vmuh-vmulw-ev-od.patch >> 0030-target-loongarch-Implement-vpcnt.patch >> 0034-target-loongarch-Implement-LSX-fpu-fcvt-instructions.patch >> 0037-target-loongarch-Implement-vbitsel-vset.patch >> 0041-target-loongarch-Implement-vld-vst.patch >> >> V4: >> - R-b and rebase; >> - Migrate the upper half lsx regs; >> - Remove tcg_gen_mulus2_*; >> - Vsetallnez use !do_match2; >> - Use tcg_gen_concat_i64_i128/tcg_gen_extr_i128_i64 to replace >> TCGV128_LOW(val)/TCGV128_High(val); > > One minor nit, everything reviewed! Congratulations. > Thank you for your guidance and review. Since all patches are reviewed, how about drop 'RFC' on v5? I am really not sure When the Vol2 will be open. Thanks. Song Gao
On 5/4/23 02:26, Song Gao wrote: >>> V4: >>> - R-b and rebase; >>> - Migrate the upper half lsx regs; >>> - Remove tcg_gen_mulus2_*; >>> - Vsetallnez use !do_match2; >>> - Use tcg_gen_concat_i64_i128/tcg_gen_extr_i128_i64 to replace >>> TCGV128_LOW(val)/TCGV128_High(val); >> >> One minor nit, everything reviewed! Congratulations. >> > Thank you for your guidance and review. > > Since all patches are reviewed, how about drop 'RFC' on v5? Sure. > I am really not sure When the Vol2 will be open. That is unfortunate. I think the timing of the merge of this code is now up to you as maintainer of the Loongson target. As an employee of the company you have more insight into the status of the extension, whether it is already present in shipping silicon, or completed final draft, or still beta, etc. Even if the extension is finalized, I see no reason why you should not be able to merge, so long as the extension is off by default, to be enabled by a cpu property from the command-line. We regularly do this for unratified RISCV extensions. r~
On 5/4/23 09:25, Richard Henderson wrote: > On 5/4/23 02:26, Song Gao wrote: >>>> V4: >>>> - R-b and rebase; >>>> - Migrate the upper half lsx regs; >>>> - Remove tcg_gen_mulus2_*; >>>> - Vsetallnez use !do_match2; >>>> - Use tcg_gen_concat_i64_i128/tcg_gen_extr_i128_i64 to replace >>>> TCGV128_LOW(val)/TCGV128_High(val); >>> >>> One minor nit, everything reviewed! Congratulations. >>> >> Thank you for your guidance and review. >> >> Since all patches are reviewed, how about drop 'RFC' on v5? > > Sure. > >> I am really not sure When the Vol2 will be open. > > That is unfortunate. > > I think the timing of the merge of this code is now up to you as maintainer of the > Loongson target. As an employee of the company you have more insight into the status of > the extension, whether it is already present in shipping silicon, or completed final > draft, or still beta, etc. > > Even if the extension is finalized, I see no reason why you should not be able to merge, Oops. "Even if the extension is *not* finalized..." I.e., a beta extension can be merged if it is off by default. r~
在 2023/5/4 下午5:41, Richard Henderson 写道: > On 5/4/23 09:25, Richard Henderson wrote: >> On 5/4/23 02:26, Song Gao wrote: >>>>> V4: >>>>> - R-b and rebase; >>>>> - Migrate the upper half lsx regs; >>>>> - Remove tcg_gen_mulus2_*; >>>>> - Vsetallnez use !do_match2; >>>>> - Use tcg_gen_concat_i64_i128/tcg_gen_extr_i128_i64 to replace >>>>> TCGV128_LOW(val)/TCGV128_High(val); >>>> >>>> One minor nit, everything reviewed! Congratulations. >>>> >>> Thank you for your guidance and review. >>> >>> Since all patches are reviewed, how about drop 'RFC' on v5? >> >> Sure. >> >>> I am really not sure When the Vol2 will be open. >> >> That is unfortunate. >> >> I think the timing of the merge of this code is now up to you as >> maintainer of the Loongson target. As an employee of the company you >> have more insight into the status of the extension, whether it is >> already present in shipping silicon, or completed final draft, or >> still beta, etc. >> >> Even if the extension is finalized, I see no reason why you should >> not be able to merge, > > Oops. "Even if the extension is *not* finalized..." > I.e., a beta extension can be merged if it is off by default. Thanks for your explanation. The 'la464' supports LSX and LASX by default. The 'la364' supports LSX by default. Neither of these are beta extensions. They are already present in the shipping silicon and have been finalized. And the 'la664' also supports LSX and LASX by default. I will send v5 series. Thanks. Song Gao