| Message ID | 20230331141833.3647-1-imp@bsdimp.com |
|---|---|
| Headers | show |
| Series | bsd-user: remove bitrotted NetBSD and OpenBSD bsd-user support | expand |
On 3/31/23 07:18, Warner Losh wrote: > The NetBSD and OpenBSD support in bsd-user hasn't built since before the meson > conversion. It's also out of sync with many of the recent changes in the > bsd-user fork and has just been removed there. Remove it from master for the > same reasons: it generates a number of false positives with grep and has > increasingly gotten in the way. The bsd-user fork code is much more advanced, > and even it doesn't compile and is out of date. Remove this from both > branches. If others wish to bring it up to speed, I'm happy to help them. > > Warner Losh (7): > bsd-user: Remove obsolete prototypes > bsd-user: Remove netbsd system call inclusion and defines > bsd-user: Remove netbsd system call tracing > bsd-user: Remove openbsd system call inclusion and defines > bsd-user: Remove openbsd system call tracing > bsd-user: Remove netbsd directory > bsd-user: Remove openbsd directory Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
Dear Qemu folks, I'll throw it in the NetBSD group for feedback. With regards, Reinoud On Fri, Mar 31, 2023 at 08:18:26AM -0600, Warner Losh wrote: > The NetBSD and OpenBSD support in bsd-user hasn't built since before the meson > conversion. It's also out of sync with many of the recent changes in the > bsd-user fork and has just been removed there. Remove it from master for the > same reasons: it generates a number of false positives with grep and has > increasingly gotten in the way. The bsd-user fork code is much more advanced, > and even it doesn't compile and is out of date. Remove this from both > branches. If others wish to bring it up to speed, I'm happy to help them. > > Warner Losh (7): > bsd-user: Remove obsolete prototypes > bsd-user: Remove netbsd system call inclusion and defines > bsd-user: Remove netbsd system call tracing > bsd-user: Remove openbsd system call inclusion and defines > bsd-user: Remove openbsd system call tracing > bsd-user: Remove netbsd directory > bsd-user: Remove openbsd directory > > bsd-user/netbsd/host-os.h | 25 -- > bsd-user/netbsd/os-strace.h | 1 - > bsd-user/netbsd/strace.list | 145 ----------- > bsd-user/netbsd/syscall_nr.h | 373 --------------------------- > bsd-user/netbsd/target_os_elf.h | 147 ----------- > bsd-user/netbsd/target_os_siginfo.h | 82 ------ > bsd-user/netbsd/target_os_signal.h | 69 ----- > bsd-user/netbsd/target_os_stack.h | 56 ---- > bsd-user/netbsd/target_os_thread.h | 25 -- > bsd-user/openbsd/host-os.h | 25 -- > bsd-user/openbsd/os-strace.h | 1 - > bsd-user/openbsd/strace.list | 187 -------------- > bsd-user/openbsd/syscall_nr.h | 225 ---------------- > bsd-user/openbsd/target_os_elf.h | 147 ----------- > bsd-user/openbsd/target_os_siginfo.h | 82 ------ > bsd-user/openbsd/target_os_signal.h | 69 ----- > bsd-user/openbsd/target_os_stack.h | 56 ---- > bsd-user/openbsd/target_os_thread.h | 25 -- > bsd-user/qemu.h | 16 -- > bsd-user/strace.c | 34 --- > bsd-user/syscall_defs.h | 29 +-- > 21 files changed, 1 insertion(+), 1818 deletions(-) > delete mode 100644 bsd-user/netbsd/host-os.h > delete mode 100644 bsd-user/netbsd/os-strace.h > delete mode 100644 bsd-user/netbsd/strace.list > delete mode 100644 bsd-user/netbsd/syscall_nr.h > delete mode 100644 bsd-user/netbsd/target_os_elf.h > delete mode 100644 bsd-user/netbsd/target_os_siginfo.h > delete mode 100644 bsd-user/netbsd/target_os_signal.h > delete mode 100644 bsd-user/netbsd/target_os_stack.h > delete mode 100644 bsd-user/netbsd/target_os_thread.h > delete mode 100644 bsd-user/openbsd/host-os.h > delete mode 100644 bsd-user/openbsd/os-strace.h > delete mode 100644 bsd-user/openbsd/strace.list > delete mode 100644 bsd-user/openbsd/syscall_nr.h > delete mode 100644 bsd-user/openbsd/target_os_elf.h > delete mode 100644 bsd-user/openbsd/target_os_siginfo.h > delete mode 100644 bsd-user/openbsd/target_os_signal.h > delete mode 100644 bsd-user/openbsd/target_os_stack.h > delete mode 100644 bsd-user/openbsd/target_os_thread.h > > -- > 2.39.2 >
These haven't even compiled in years. Last time I polled the NetBSD and OpenBSD communities they weren't using this and had no plans to fix. I'd be happy to work with anybody that wanted to fix that state of affairs. Warner On Sat, Apr 1, 2023, 7:00 AM Reinoud Zandijk <reinoud@netbsd.org> wrote: > Dear Qemu folks, > > I'll throw it in the NetBSD group for feedback. > > With regards, > Reinoud > > On Fri, Mar 31, 2023 at 08:18:26AM -0600, Warner Losh wrote: > > The NetBSD and OpenBSD support in bsd-user hasn't built since before the > meson > > conversion. It's also out of sync with many of the recent changes in the > > bsd-user fork and has just been removed there. Remove it from master for > the > > same reasons: it generates a number of false positives with grep and has > > increasingly gotten in the way. The bsd-user fork code is much more > advanced, > > and even it doesn't compile and is out of date. Remove this from both > > branches. If others wish to bring it up to speed, I'm happy to help them. > > > > Warner Losh (7): > > bsd-user: Remove obsolete prototypes > > bsd-user: Remove netbsd system call inclusion and defines > > bsd-user: Remove netbsd system call tracing > > bsd-user: Remove openbsd system call inclusion and defines > > bsd-user: Remove openbsd system call tracing > > bsd-user: Remove netbsd directory > > bsd-user: Remove openbsd directory > > > > bsd-user/netbsd/host-os.h | 25 -- > > bsd-user/netbsd/os-strace.h | 1 - > > bsd-user/netbsd/strace.list | 145 ----------- > > bsd-user/netbsd/syscall_nr.h | 373 --------------------------- > > bsd-user/netbsd/target_os_elf.h | 147 ----------- > > bsd-user/netbsd/target_os_siginfo.h | 82 ------ > > bsd-user/netbsd/target_os_signal.h | 69 ----- > > bsd-user/netbsd/target_os_stack.h | 56 ---- > > bsd-user/netbsd/target_os_thread.h | 25 -- > > bsd-user/openbsd/host-os.h | 25 -- > > bsd-user/openbsd/os-strace.h | 1 - > > bsd-user/openbsd/strace.list | 187 -------------- > > bsd-user/openbsd/syscall_nr.h | 225 ---------------- > > bsd-user/openbsd/target_os_elf.h | 147 ----------- > > bsd-user/openbsd/target_os_siginfo.h | 82 ------ > > bsd-user/openbsd/target_os_signal.h | 69 ----- > > bsd-user/openbsd/target_os_stack.h | 56 ---- > > bsd-user/openbsd/target_os_thread.h | 25 -- > > bsd-user/qemu.h | 16 -- > > bsd-user/strace.c | 34 --- > > bsd-user/syscall_defs.h | 29 +-- > > 21 files changed, 1 insertion(+), 1818 deletions(-) > > delete mode 100644 bsd-user/netbsd/host-os.h > > delete mode 100644 bsd-user/netbsd/os-strace.h > > delete mode 100644 bsd-user/netbsd/strace.list > > delete mode 100644 bsd-user/netbsd/syscall_nr.h > > delete mode 100644 bsd-user/netbsd/target_os_elf.h > > delete mode 100644 bsd-user/netbsd/target_os_siginfo.h > > delete mode 100644 bsd-user/netbsd/target_os_signal.h > > delete mode 100644 bsd-user/netbsd/target_os_stack.h > > delete mode 100644 bsd-user/netbsd/target_os_thread.h > > delete mode 100644 bsd-user/openbsd/host-os.h > > delete mode 100644 bsd-user/openbsd/os-strace.h > > delete mode 100644 bsd-user/openbsd/strace.list > > delete mode 100644 bsd-user/openbsd/syscall_nr.h > > delete mode 100644 bsd-user/openbsd/target_os_elf.h > > delete mode 100644 bsd-user/openbsd/target_os_siginfo.h > > delete mode 100644 bsd-user/openbsd/target_os_signal.h > > delete mode 100644 bsd-user/openbsd/target_os_stack.h > > delete mode 100644 bsd-user/openbsd/target_os_thread.h > > > > -- > > 2.39.2 > > >
After consulting with Taylor Campbell, I'm going to hold off on this for now. He had some code to start to fix things, which I hope he can find time and energy to port over to the (more complete) qemu-bsd-user upstream so that there's one target for people working on the area that will eventually become what's in qemu-project's master branch. I'll replace this series with some other changes that try to accomplish the same base goals. Warner On Fri, Mar 31, 2023 at 8:19 AM Warner Losh <imp@bsdimp.com> wrote: > The NetBSD and OpenBSD support in bsd-user hasn't built since before the > meson > conversion. It's also out of sync with many of the recent changes in the > bsd-user fork and has just been removed there. Remove it from master for > the > same reasons: it generates a number of false positives with grep and has > increasingly gotten in the way. The bsd-user fork code is much more > advanced, > and even it doesn't compile and is out of date. Remove this from both > branches. If others wish to bring it up to speed, I'm happy to help them. > > Warner Losh (7): > bsd-user: Remove obsolete prototypes > bsd-user: Remove netbsd system call inclusion and defines > bsd-user: Remove netbsd system call tracing > bsd-user: Remove openbsd system call inclusion and defines > bsd-user: Remove openbsd system call tracing > bsd-user: Remove netbsd directory > bsd-user: Remove openbsd directory > > bsd-user/netbsd/host-os.h | 25 -- > bsd-user/netbsd/os-strace.h | 1 - > bsd-user/netbsd/strace.list | 145 ----------- > bsd-user/netbsd/syscall_nr.h | 373 --------------------------- > bsd-user/netbsd/target_os_elf.h | 147 ----------- > bsd-user/netbsd/target_os_siginfo.h | 82 ------ > bsd-user/netbsd/target_os_signal.h | 69 ----- > bsd-user/netbsd/target_os_stack.h | 56 ---- > bsd-user/netbsd/target_os_thread.h | 25 -- > bsd-user/openbsd/host-os.h | 25 -- > bsd-user/openbsd/os-strace.h | 1 - > bsd-user/openbsd/strace.list | 187 -------------- > bsd-user/openbsd/syscall_nr.h | 225 ---------------- > bsd-user/openbsd/target_os_elf.h | 147 ----------- > bsd-user/openbsd/target_os_siginfo.h | 82 ------ > bsd-user/openbsd/target_os_signal.h | 69 ----- > bsd-user/openbsd/target_os_stack.h | 56 ---- > bsd-user/openbsd/target_os_thread.h | 25 -- > bsd-user/qemu.h | 16 -- > bsd-user/strace.c | 34 --- > bsd-user/syscall_defs.h | 29 +-- > 21 files changed, 1 insertion(+), 1818 deletions(-) > delete mode 100644 bsd-user/netbsd/host-os.h > delete mode 100644 bsd-user/netbsd/os-strace.h > delete mode 100644 bsd-user/netbsd/strace.list > delete mode 100644 bsd-user/netbsd/syscall_nr.h > delete mode 100644 bsd-user/netbsd/target_os_elf.h > delete mode 100644 bsd-user/netbsd/target_os_siginfo.h > delete mode 100644 bsd-user/netbsd/target_os_signal.h > delete mode 100644 bsd-user/netbsd/target_os_stack.h > delete mode 100644 bsd-user/netbsd/target_os_thread.h > delete mode 100644 bsd-user/openbsd/host-os.h > delete mode 100644 bsd-user/openbsd/os-strace.h > delete mode 100644 bsd-user/openbsd/strace.list > delete mode 100644 bsd-user/openbsd/syscall_nr.h > delete mode 100644 bsd-user/openbsd/target_os_elf.h > delete mode 100644 bsd-user/openbsd/target_os_siginfo.h > delete mode 100644 bsd-user/openbsd/target_os_signal.h > delete mode 100644 bsd-user/openbsd/target_os_stack.h > delete mode 100644 bsd-user/openbsd/target_os_thread.h > > -- > 2.39.2 > >