From patchwork Mon Jun 13 13:25:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?C=C3=A9dric_Le_Goater?= X-Patchwork-Id: 1642826 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4LMC6q5bVyz9s0r for ; Mon, 13 Jun 2022 23:27:47 +1000 (AEST) Received: from localhost ([::1]:35348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o0k6b-0001Q4-8S for incoming@patchwork.ozlabs.org; Mon, 13 Jun 2022 09:27:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0k55-0000FO-CM; Mon, 13 Jun 2022 09:26:11 -0400 Received: from gandalf.ozlabs.org ([150.107.74.76]:37371) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0k53-0004SB-59; Mon, 13 Jun 2022 09:26:11 -0400 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4LMC4h1BmMz4yY5; Mon, 13 Jun 2022 23:25:56 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4LMC4R56Ybz4yXP; Mon, 13 Jun 2022 23:25:43 +1000 (AEST) From: =?utf-8?q?C=C3=A9dric_Le_Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Peter Maydell , Joe Komlodi , Troy Lee , Jamin Lin , Steven Lee , Klaus Jensen , Peter Delevoryas , Corey Minyard , Jonathan Cameron , Damien Hedde , Andrew Jeffery , Joel Stanley , Cleber Rosa , =?utf-8?q?Ph?= =?utf-8?q?ilippe_Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Beraldo Leal , =?utf-8?q?C=C3=A9dric_Le_Goater?= Subject: [PATCH v2 00/17] aspeed: Extend ast2600 I2C model with new mode Date: Mon, 13 Jun 2022 15:25:22 +0200 Message-Id: <20220613132539.2199772-1-clg@kaod.org> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Received-SPF: pass client-ip=150.107.74.76; envelope-from=SRS0=yfRC=WU=kaod.org=clg@ozlabs.org; helo=gandalf.ozlabs.org X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Hello, Here is a series aggregating recent changes proposed on the Aspeed ast2600 I2C controller model. First comes a large set of changes converting the model to use the registerfield interface and adding the I2C new register mode (Joe). Since this is complex to review, extra tests are added to the acceptance test suite to check that I2C devices are still functional in the ast2600-evb machine. These tests use small buildroot images available on GH. The ast1030 and ast2600 SoC share the same I2C logic. This series adds I2C support to the ast1030 now that new register mode is supported. There was a previous proposal from Troy doing the same but Joe's patchset covers the same need (and converts the model to registerfield) Klaus made a proposal to add support for multi master in the I2C core and the Aspeed I2C model. The last patches add the required bits to let this happen. Thanks, C. Changes in v2: - reworked I2C avocado tests - dropped ctrl_global_rsvd property - removed support for multiple masters from Klaus. this change should come in its own series. Cédric Le Goater (8): aspeed: Remove fake RTC device on ast2500-evb test/avocado/machine_aspeed.py: Move OpenBMC tests test/avocado/machine_aspeed.py: Add tests using buildroot images test/avocado/machine_aspeed.py: Add I2C tests to ast2500-evb test/avocado/machine_aspeed.py: Add I2C tests to ast2600-evb test/avocado/machine_aspeed.py: Add an I2C RTC test aspeed/i2c: Add ast1030 controller models aspeed/i2c: Enable SLAVE_ADDR_RX_MATCH always Joe Komlodi (6): hw/registerfields: Add shared fields macros aspeed: i2c: Migrate to registerfields API aspeed: i2c: Use reg array instead of individual vars aspeed: i2c: Add new mode support aspeed: i2c: Add PKT_DONE IRQ to trace aspeed: i2c: Move regs and helpers to header file Klaus Jensen (2): hw/i2c/aspeed: rework raise interrupt trace event hw/i2c/aspeed: add DEV_ADDR in old register mode Troy Lee (1): aspeed: Add I2C buses to AST1030 model include/hw/i2c/aspeed_i2c.h | 289 +++++++++- include/hw/registerfields.h | 70 +++ hw/arm/aspeed.c | 17 +- hw/arm/aspeed_ast10x0.c | 18 + hw/i2c/aspeed_i2c.c | 820 +++++++++++++++++----------- hw/i2c/trace-events | 2 +- tests/avocado/boot_linux_console.py | 43 -- tests/avocado/machine_aspeed.py | 136 +++++ 8 files changed, 1030 insertions(+), 365 deletions(-)