mbox series

[0/5] hw/nvme: fix namespace identifiers

Message ID 20220419121039.1259477-1-its@irrelevant.dk
Headers show
Series hw/nvme: fix namespace identifiers | expand

Message

Klaus Jensen April 19, 2022, 12:10 p.m. UTC 
From: Klaus Jensen <k.jensen@samsung.com>

The namespace identifiers reported by the controller is kind of a mess.
See [1,2].

This series should fix this for both the `-device nvme,drive=...` and
`-device nvme-ns,...` cases.

  [1]: https://lore.kernel.org/linux-nvme/20220224192845.1097602-1-hch@lst.de/
  [2]: https://lore.kernel.org/linux-nvme/20220413044905.376785-1-hch@lst.de/

Klaus Jensen (5):
  hw/nvme: enforce common serial per subsystem
  hw/nvme: always set eui64
  hw/nvme: do not report null uuid
  hw/nvme: do not auto-generate uuid
  hw/nvme: bump firmware revision

 docs/system/devices/nvme.rst |  6 ++++--
 hw/nvme/ctrl.c               | 21 ++++++++++-----------
 hw/nvme/ns.c                 | 14 +++++++++-----
 hw/nvme/nvme.h               |  4 ++++
 hw/nvme/subsys.c             |  7 +++++++
 5 files changed, 34 insertions(+), 18 deletions(-)

Comments

Keith Busch April 19, 2022, 2:32 p.m. UTC | #1 
On Tue, Apr 19, 2022 at 02:10:34PM +0200, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
> 
> The namespace identifiers reported by the controller is kind of a mess.
> See [1,2].
> 
> This series should fix this for both the `-device nvme,drive=...` and
> `-device nvme-ns,...` cases.

Series looks good.

Reviewed-by: Keith Busch <kbusch@kernel.org>