mbox series

[v3,0/5] target/arm: Use tcg_constant_*

Message ID 20211029231834.2476117-1-f4bug@amsat.org
Headers show
Series target/arm: Use tcg_constant_* | expand

Message

Philippe Mathieu-Daudé Oct. 29, 2021, 11:18 p.m. UTC 
Missing review: patches #2 & #5 (new)

Introduce store_cpu_field_constant() helper to avoid using temporary
when the value is constant (and read-only).

Since v2:
- Simplify store_cpu_field_constant(), do not modify store_cpu_field()
- Added another use in gen_rev16()

Philippe Mathieu-Daudé (5):
  target/arm: Use tcg_constant_i32() in op_smlad()
  target/arm: Introduce store_cpu_field_constant() helper
  target/arm: Use the constant variant of store_cpu_field() when
    possible
  target/arm: Use tcg_constant_i64() in do_sat_addsub_64()
  target/arm: Use tcg_constant_i32() in gen_rev16()

 target/arm/translate-a32.h |  3 +++
 target/arm/translate-sve.c | 17 ++++++++---------
 target/arm/translate.c     | 27 ++++++++-------------------
 3 files changed, 19 insertions(+), 28 deletions(-)

Comments

Richard Henderson Nov. 1, 2021, 5:41 p.m. UTC | #1 
On 10/29/21 7:18 PM, Philippe Mathieu-Daudé wrote:
> Missing review: patches #2 & #5 (new)
> 
> Introduce store_cpu_field_constant() helper to avoid using temporary
> when the value is constant (and read-only).
> 
> Since v2:
> - Simplify store_cpu_field_constant(), do not modify store_cpu_field()
> - Added another use in gen_rev16()
> 
> Philippe Mathieu-Daudé (5):
>    target/arm: Use tcg_constant_i32() in op_smlad()
>    target/arm: Introduce store_cpu_field_constant() helper
>    target/arm: Use the constant variant of store_cpu_field() when
>      possible
>    target/arm: Use tcg_constant_i64() in do_sat_addsub_64()
>    target/arm: Use tcg_constant_i32() in gen_rev16()
> 
>   target/arm/translate-a32.h |  3 +++
>   target/arm/translate-sve.c | 17 ++++++++---------
>   target/arm/translate.c     | 27 ++++++++-------------------
>   3 files changed, 19 insertions(+), 28 deletions(-)

Thanks, applied to target-arm.next.


r~