mbox series

[v3,0/3] VNC-related HMP/QMP fixes

Message ID 20210920105641.258104-1-s.reiter@proxmox.com
Headers show
Series VNC-related HMP/QMP fixes | expand

Message

Stefan Reiter Sept. 20, 2021, 10:56 a.m. UTC 
Since the removal of the generic 'qmp_change' command, one can no longer replace
the 'default' VNC display listen address at runtime (AFAIK). For our users who
need to set up a secondary VNC access port, this means configuring a second VNC
display (in addition to our standard one for web-access), but it turns out one
cannot set a password on this second display at the moment, as the
'set_password' call only operates on the 'default' display.

Additionally, using secret objects, the password is only read once at startup.
This could be considered a bug too, but is not touched in this series and left
for a later date.


v2 -> v3:
* refactor QMP schema for set/expire_password as suggested by Eric Blake and
  Markus Armbruster

v1 -> v2:
* add Marc-André's R-b on patch 1
* use '-d' flag as suggested by Eric Blake and Gerd Hoffmann
  * I didn't see a way to do this yet, so I added a "flags with values" arg type


Stefan Reiter (3):
  monitor/hmp: correctly invert password argument detection again
  monitor/hmp: add support for flag argument with value
  monitor: refactor set/expire_password and allow VNC display id

 hmp-commands.hx    |  29 ++++----
 monitor/hmp-cmds.c |  62 ++++++++++++++++-
 monitor/hmp.c      |  17 ++++-
 monitor/qmp-cmds.c |  62 ++++++-----------
 qapi/ui.json       | 168 +++++++++++++++++++++++++++++++++++++--------
 5 files changed, 252 insertions(+), 86 deletions(-)