mbox series

[00/10] aspeed/smc: Cleanups and QOMification

Message ID 20210907065822.1152443-1-clg@kaod.org
Headers show
Series aspeed/smc: Cleanups and QOMification | expand

Message

Cédric Le Goater Sept. 7, 2021, 6:58 a.m. UTC 
Hello,

It looks big but there are no major changes.

This series adds a simple support for the 2nd watchdog registers which
were moved under the AST2600 FMC controller to deactivate the
alternate boot function. Then come cleanups of the AspeedSMC model
mostly removing a useless AspeedSMCController structure (that's the
noisy part) and QOMifying the AspeedSMCFlash structure.

Thanks,

C.

Cédric Le Goater (10):
  aspeed/smc: Add watchdog Control/Status Registers
  aspeed/smc: Introduce aspeed_smc_error() helper
  aspeed/smc: Stop using the model name for the memory regions
  aspeed/smc: Drop AspeedSMCController structure
  aspeed/smc: Remove the 'flash' attribute from AspeedSMCFlash
  aspeed/smc: Remove the 'size' attribute from AspeedSMCFlash
  aspeed/smc: Rename AspeedSMCFlash 'id' to 'cs'
  aspeed/smc: QOMify AspeedSMCFlash
  aspeed/smc: Add default reset values
  aspeed/smc: Introduce an addr_width() class handler

 include/hw/ssi/aspeed_smc.h |   81 ++-
 hw/arm/aspeed.c             |   18 +-
 hw/arm/aspeed_ast2600.c     |    4 +-
 hw/arm/aspeed_soc.c         |    4 +-
 hw/ssi/aspeed_smc.c         | 1129 ++++++++++++++++++++---------------
 5 files changed, 701 insertions(+), 535 deletions(-)

Comments

Joel Stanley Sept. 7, 2021, 7:17 a.m. UTC | #1 
Hi Cédric,

On Tue, 7 Sept 2021 at 06:58, Cédric Le Goater <clg@kaod.org> wrote:
> This series adds a simple support for the 2nd watchdog registers which
> were moved under the AST2600 FMC controller to deactivate the
> alternate boot function. Then come cleanups of the AspeedSMC model
> mostly removing a useless AspeedSMCController structure (that's the
> noisy part) and QOMifying the AspeedSMCFlash structure.

I had a read through and it makes sense to me.

Reviewed-by: Joel Stanley <joel@jms.id.au>

Cheers,

Joel