From patchwork Thu Aug 5 13:56:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 1513909 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PhaNZB9B; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GgVZW5Nrhz9sW8 for ; Thu, 5 Aug 2021 23:58:43 +1000 (AEST) Received: from localhost ([::1]:43304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBdtR-000678-Ex for incoming@patchwork.ozlabs.org; Thu, 05 Aug 2021 09:58:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBdsJ-0004ZF-Qw for qemu-devel@nongnu.org; Thu, 05 Aug 2021 09:57:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44416) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBdsH-0008Uz-4s for qemu-devel@nongnu.org; Thu, 05 Aug 2021 09:57:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628171848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4dlKvBDVIFqszBQnMWEULOjSO/n1OfjsfYWZa2oaXgI=; b=PhaNZB9BKn36mYQVtR0EVspjzJ7ej9zemZNooB23Q+DvDuBSQUk0ZU8fydMnNd3ZRZl8cl DN7ChURKClnJrG/awPZtML4e9AOiJ4efDDMoASsZP2oEcUV9ZzNSXuNLuOeiWqIT6qiTjU o2khr03I7CIY2ebQM1acW4JrftkxQK8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-284-aFDoCKx8P_u5eQRy1h1xSQ-1; Thu, 05 Aug 2021 09:57:27 -0400 X-MC-Unique: aFDoCKx8P_u5eQRy1h1xSQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7BED1801AE7 for ; Thu, 5 Aug 2021 13:57:26 +0000 (UTC) Received: from localhost (unknown [10.39.208.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id B3D435C1A1; Thu, 5 Aug 2021 13:57:18 +0000 (UTC) From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH v3 00/18] Clipboard fixes (for 6.1?) Date: Thu, 5 Aug 2021 17:56:57 +0400 Message-Id: <20210805135715.857938-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=marcandre.lureau@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Gerd Hoffmann Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Marc-André Lureau Hi, Here is a few fixes I have collected while working on clipboard-related code. There are some obvious code improvements/fixes, and better handling of release & unregister to avoid dangling pointers and improve user experience. v3: - add a migration blocker - improve the code by using a few helpers v2: - replaced "ui/vdagent: unregister clipboard peer on finalize" with "ui/vdagent: disconnect handlers and reset state on finalize" patch. - added "ui/vdagent: reset outbuf on disconnect" - commit message tweaks Marc-André Lureau (18): ui/vdagent: fix leak on error path ui/vdagent: remove copy-pasta comment ui/gtk-clipboard: use existing macros ui/gtk-clipboard: fix clipboard enum typo ui/clipboard: add helper to retrieve current clipboard ui/clipboard: add qemu_clipboard_peer_owns() helper ui/clipboard: add qemu_clipboard_peer_release() helper ui/clipboard: release owned grabs on unregister ui/vdagent: disconnect handlers and reset state on finalize ui/vdagent: reset outbuf on disconnect ui/vdagent: split clipboard recv message handling ui/vdagent: use qemu_clipboard_peer_release helper ui/vdagent: use qemu_clipboard_info helper ui/vdagent: send empty clipboard when unhandled ui/gtk-clipboard: use qemu_clipboard_info helper ui/vdagent: send release when no clipboard owner ui/gtk-clipboard: emit release clipboard events ui/vdagent: add a migration blocker include/ui/clipboard.h | 33 ++++++ include/ui/gtk.h | 1 - ui/clipboard.c | 41 +++++++ ui/gtk-clipboard.c | 24 ++--- ui/vdagent.c | 239 ++++++++++++++++++++++++++--------------- ui/trace-events | 1 + 6 files changed, 240 insertions(+), 99 deletions(-) Acked-by: Gerd Hoffmann