| Message ID | 20210603133722.218465-1-pbonzini@redhat.com |
|---|---|
| Headers | show |
| Series | block: file-posix queue | expand |
On Thu, 2021-06-03 at 15:37 +0200, Paolo Bonzini wrote: > Hi Kevin, > > this is a combination of two series that both affect host block device > support in block/file-posix.c. Joelle's series is unchanged, while > mine was adjusted according to your review of v2. > > v1->v2: add missing patch > > v2->v3: add max_hw_transfer to BlockLimits > > > Joelle van Dyne (3): > block: feature detection for host block support > block: check for sys/disk.h > block: detect DKIOCGETBLOCKCOUNT/SIZE before use > > Paolo Bonzini (4): > file-posix: fix max_iov for /dev/sg devices > scsi-generic: pass max_segments via max_iov field in BlockLimits > block: add max_hw_transfer to BlockLimits > file-posix: try BLKSECTGET on block devices too, do not round to power > of 2 > > block.c | 2 +- > block/block-backend.c | 12 ++++ > block/file-posix.c | 104 ++++++++++++++++++++------------- > block/io.c | 1 + > hw/scsi/scsi-generic.c | 6 +- > include/block/block_int.h | 7 +++ > include/sysemu/block-backend.h | 1 + > meson.build | 7 ++- > qapi/block-core.json | 10 +++- > 9 files changed, 102 insertions(+), 48 deletions(-) > Hi Paolo and everyone! I used to have a patch series that was about to fix the block limits of the scsi-block, which I think is similar to this patch series. Sorry that I kind of forgot about it for too much time. https://www.mail-archive.com/qemu-devel@nongnu.org/msg768261.html I'll need some time to swap-in this area so that I could compare our patches to see if we missed something. Best regards, Maxim Levitsky
On 07/06/21 15:52, Maxim Levitsky wrote: > I used to have a patch series that was about to fix the block limits of the scsi-block, > which I think is similar to this patch series. > > Sorry that I kind of forgot about it for too much time. > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg768261.html > > I'll need some time to swap-in this area so that I could compare our > patches to see if we missed something. They are indeed very similar; the only substantial change is that my patches also clamp max_hw_transfer to max_transfer. I picked up patch 5 from your old submission and queued it, since it's a SCSI change. Paolo
Hi Kevin, this is a combination of two series that both affect host block device support in block/file-posix.c. Joelle's series is unchanged, while mine was adjusted according to your review of v2. v1->v2: add missing patch v2->v3: add max_hw_transfer to BlockLimits Joelle van Dyne (3): block: feature detection for host block support block: check for sys/disk.h block: detect DKIOCGETBLOCKCOUNT/SIZE before use Paolo Bonzini (4): file-posix: fix max_iov for /dev/sg devices scsi-generic: pass max_segments via max_iov field in BlockLimits block: add max_hw_transfer to BlockLimits file-posix: try BLKSECTGET on block devices too, do not round to power of 2 block.c | 2 +- block/block-backend.c | 12 ++++ block/file-posix.c | 104 ++++++++++++++++++++------------- block/io.c | 1 + hw/scsi/scsi-generic.c | 6 +- include/block/block_int.h | 7 +++ include/sysemu/block-backend.h | 1 + meson.build | 7 ++- qapi/block-core.json | 10 +++- 9 files changed, 102 insertions(+), 48 deletions(-)