[0/6] block permission updated follow-up

Message ID	20210503113402.185852-1-vsementsov@virtuozzo.com
Headers	show Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com, kwolf@redhat.com, vsementsov@virtuozzo.com Subject: [PATCH 0/6] block permission updated follow-up Date: Mon, 3 May 2021 14:33:56 +0300 Message-Id: <20210503113402.185852-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received-SPF: pass client-ip=40.107.20.96; envelope-from=vsementsov@virtuozzo.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action Precedence: list Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>
Series	block permission updated follow-up \| expand [0/6] block permission updated follow-up [1/6] block: fix leak of tran in bdrv_root_attach_child [2/6] block: bdrv_reopen_multiple(): fix leak of tran object [3/6] block-backend: improve blk_root_get_parent_desc() [4/6] block: improve bdrv_child_get_parent_desc() [5/6] block: simplify bdrv_child_user_desc() [6/6] block: improve permission conflict error message [7/6] block: document child argument of bdrv_attach_child_common()

Message ID

20210503113402.185852-1-vsementsov@virtuozzo.com

Headers

From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, mreitz@redhat.com, kwolf@redhat.com,
 vsementsov@virtuozzo.com
Subject: [PATCH 0/6] block permission updated follow-up
Date: Mon,  3 May 2021 14:33:56 +0300
Message-Id: <20210503113402.185852-1-vsementsov@virtuozzo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from localhost.localdomain (185.215.60.251) by
 HE1PR05CA0255.eurprd05.prod.outlook.com (2603:10a6:3:fb::31) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4087.27 via Frontend Transport; Mon, 3 May 2021 11:34:15 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 95600836-e6e7-420a-d6be-08d90e2761ef
X-MS-TrafficTypeDiagnostic: AM5PR0801MB1713:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: 
 <AM5PR0801MB1713D7F9ACF75690BB0DEFD4C15B9@AM5PR0801MB1713.eurprd08.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:318;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 
 3EoLB3ZIiAtr/W7WI/Du2ogdnVmxvqmbnhm5Q51Vwti+cIe9vBzysU72GulVITyiUK/gwzSnH8ED0tilHywozy2QbfEi9w1Z3/hJw1OGCW1jOpIYSkmG+6PFmL2kOvM2BFJpJW7pbzvzk+HyMIwnnkkikQkXrLnUtNSsbt3XL/pycnpOCGVmGjdILwfhoVnpvqt8CqNIGGIfpBFndeD9PWM6tKUMQ9N/vFzyk4ui18bCl1cImGYipZws29rV515hpZ/860K9SmgLNvk0uSo6vgLcX6GWBWm/KJ3LVZ7ckX91tGukAD7ECl894jbRwL+jb8y/8h6auWOlwk6UtCTynydz+gZGvWlNb85HZTaO2+Src3q0w7OAkfK/kVV2J8XZIxO3+jw7ZXCdhkvvkyApbsyBxLS4y9jqYSQRd1A+HBG8tVwDOPmXESu+pXJgaCbjPhL4BMFu9FLY7emYAJEM0XkPIoR9k0s2bfYYQOtiR/52R6Z6kRKyeWLRJP3nvy10/elRYYXL/r0CmptrBlO5pDRu6eHKYdDOVVIEPnFEUpSs0+uthtzEybnx6anXbD2wor2DePm2byzOAQvFwyDbzjEiqufYynD7uyxaFlwXr4rddbq8kpZM87LZSEPKU4PsmNXPKZNGgFDpiVuWzgH80BZW1nhgO1WM1ZHOIxrUoxhtLkIe6bOw6IbmMLymjOS+
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(4636009)(136003)(366004)(376002)(39830400003)(346002)(396003)(107886003)(5660300002)(6506007)(956004)(1076003)(2616005)(6916009)(4744005)(6512007)(52116002)(4326008)(16526019)(15650500001)(2906002)(186003)(36756003)(38100700002)(83380400001)(66556008)(66946007)(66476007)(86362001)(6486002)(8676002)(8936002)(478600001)(26005)(6666004)(316002)(38350700002)(69590400013);
 DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: 
 WqImTd8gCPKYsfciX3W8Hm2etEVZNRyRdvFsOE8r8WPc8D8Sab2OkVQ9RESHD7lXxDs+xwq+jp60y3QTyuiH9Aedk3dttepy/DCD9ZLAsDvTmkcg22me557+QGQ+bilhvD8HRVx6Qha29mQ6NLP7QXh0wGL3q/pxmCD5PW9xR4wA86D5MWfOrVFiNeqzVLlPFB3yliYXg74pqfK5iUfCN5K9rJ8xIvQmb+mqh8o/pZcuonXGpwS4TfrHHFAvjYfLDcikcxCnmRu+fhsFQhY7vQv5Zlk1kBXgN+ss36b4yiZNMM5/KN/GOtC4/cZghZyaNNE+sSPrSCkwvrlr1py+jfM44VvKKMuiCyIZPxSBSb3Zqt9FXmAMiR+VV3G4sZ6z+Zf4xvuBmGrXqIp6v7z/IXStZOEGjVznv34u1mu1gZAZMNmvj/z5CTWUcVw2tF0/Y1P3urkoBDy3oS3PApF4dYD50TcJztMIBXj+PSk5N2jiUVGpbA+oZ8JovgP8CVnV+OJXb5oXfZe8IIe3kCsaIC2l/aj54ILE8I7hYBiBeSrMraZcGxchQ8ykluj0OvTaDWjucUPerXXVkGd99bHk0TDQsALirNeErU8kBVQIWzVKIUddZJDbOp40ykFXhtUngyBKafuCiWazoy8kVWEwUGLrVxMqRUIDttq7DjxH3v5FK6CZIXbbfeO7zvZYFjvOdXIEuXltm7vy63m+EZUEq16CKqeoXfhVRkwYiDMuEJ/runia8DA1BDa23Fn2TddNLxsJm9JMTEWtDtmcCkFif4/enThjj4IBa5PT4LRGxwP28KhEdSAwK48oO4kIDjQzfmdCIQuuiYfRoNCa1WxCXlmkFrGDzxqS0NKsZi6WbHL4OLLxcN+ABSZY4WlQhYLIUyMvVYlFCKaSC7dESRVTflaQ3ux/NMXSt9GkFTnTCgJJ/DBsYAfqesJoiukgQ1McNEYeCtjctjpHFRyMq4ZCBIzWyChaTMAgob7LBPy9iZv0luLugaUnmbkrSMzKEyLpmoT6S3fPBHVpy3IyIFfGWLa6/2grIItRDm1ZgHUqA/widDdSbp9EV+gkOROkMjugw8ziUUK7+n5T1651JWj0up8I7uTd7Tczw51KSYmFjIMvjDi0+Pf4/6JwqoBwoU3imqRUARGe9DCYMc5gK0wNrgtsPpzJCKOYa99f8XrXYOJ6rqqLnggvlYrcvbLhf9W5KrxmVfw4SvWp1AGIPmOssgMK9Mcd+G3UArGmMBW+MmrOTAXAJcceZcOOg1dRdLCqw9bj7ODDu5a9ddgjLKzhLKDPdAtpp+FbI6oKKi2R+u0+WW9HBjDmkUu3O/WbmyIu
X-OriginatorOrg: virtuozzo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 95600836-e6e7-420a-d6be-08d90e2761ef
X-MS-Exchange-CrossTenant-AuthSource: AM7PR08MB5494.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2021 11:34:16.0979 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 
 ivDVhrpjBubQeTSGKLmAzi7oXLw7WyFOSOebIlZZA3fT61AKgjJg7cEqBE8bUW203p4NHaL7n6pGs/a7iApHO2jybQUxWxO7jfG7M7BOWWk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1713
Received-SPF: pass client-ip=40.107.20.96;
 envelope-from=vsementsov@virtuozzo.com;
 helo=EUR05-DB8-obe.outbound.protection.outlook.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001,
 RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
 <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
 <mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org
Sender: "Qemu-devel"
 <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>

Series

block permission updated follow-up | expand

Message

Vladimir Sementsov-Ogievskiy May 3, 2021, 11:33 a.m. UTC

Hi all!

Here are two coverity fixes and improvement of error message.

Vladimir Sementsov-Ogievskiy (6):
  block: fix leak of tran in bdrv_root_attach_child
  block: bdrv_reopen_multiple(): fix leak of tran object
  block-backend: improve blk_root_get_parent_desc()
  block: improve bdrv_child_get_parent_desc()
  block: simplify bdrv_child_user_desc()
  block: improve permission conflict error message

 block.c                               | 51 ++++++++++++++++++---------
 block/block-backend.c                 |  9 +++--
 tests/qemu-iotests/283.out            |  2 +-
 tests/qemu-iotests/307.out            |  2 +-
 tests/qemu-iotests/tests/qsd-jobs.out |  2 +-
 5 files changed, 42 insertions(+), 24 deletions(-)