Message ID | 20210418163134.1133100-1-f4bug@amsat.org |
---|---|
Headers | show |
Series | target/mips: Re-org to allow KVM-only builds | expand |
Patchew URL: https://patchew.org/QEMU/20210418163134.1133100-1-f4bug@amsat.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210418163134.1133100-1-f4bug@amsat.org Subject: [PATCH 00/26] target/mips: Re-org to allow KVM-only builds === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20210417194205.17057-1-peter.maydell@linaro.org -> patchew/20210417194205.17057-1-peter.maydell@linaro.org * [new tag] patchew/20210418163134.1133100-1-f4bug@amsat.org -> patchew/20210418163134.1133100-1-f4bug@amsat.org Switched to a new branch 'test' ec4a066 gitlab-ci: Add KVM mips64el cross-build jobs 0f39b27 hw/mips: Restrict non-virtualized machines to TCG d91a8b3 target/mips: Move TCG source files under tcg/ sub directory c83fb11 target/mips: Move helper.h -> tcg/helper.h.inc c6e95b9 target/mips: Move CP0 helpers to sysemu/cp0.c 2d3b5d6 target/mips: Move exception management code to exception.c 78d355a target/mips: Move TLB management helpers to tcg/sysemu/tlb_helper.c 51e44c9 target/mips: Move helper_cache() to tcg/sysemu/special_helper.c db846de target/mips: Move Special opcodes to tcg/sysemu/special_helper.c 7d440db target/mips: Restrict CPUMIPSTLBContext::map_address() handlers scope 6d61110 target/mips: Move tlb_helper.c to tcg/sysemu/ 8f68aad target/mips: Restrict mmu_init() to TCG 7f51b6e target/mips: Move sysemu TCG-specific code to tcg/sysemu/ subfolder 4a8000c target/mips: Move code related to physical addressing to sysemu/phys.c 17eb078 target/mips: Move sysemu specific files under sysemu/ subfolder 2557ee2 target/mips: Move cpu_signal_handler definition around 2945a42 target/mips: Add simple user-mode mips_cpu_tlb_fill() 5dc00af target/mips: Add simple user-mode mips_cpu_do_interrupt() 1dee23e target/mips: Introduce tcg-internal.h for TCG specific declarations d553454 meson: Introduce meson_user_arch source set for arch-specific user-mode 061bc56 target/mips: Extract load/store helpers to ldst_helper.c 55fbc48 target/mips: Restrict mips_cpu_dump_state() to cpu.c 1b28dda target/mips: Make CPU/FPU regnames[] arrays global c920bad target/mips: Move msa_reset() to new source file 5af6fa7 target/mips: Move IEEE rounding mode array to new source file 990b30d target/mips: Simplify meson TCG rules === OUTPUT BEGIN === 1/26 Checking commit 990b30d220a6 (target/mips: Simplify meson TCG rules) 2/26 Checking commit 5af6fa7b1717 (target/mips: Move IEEE rounding mode array to new source file) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644 total: 0 errors, 1 warnings, 39 lines checked Patch 2/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/26 Checking commit c920bad76ffc (target/mips: Move msa_reset() to new source file) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: new file mode 100644 total: 0 errors, 1 warnings, 70 lines checked Patch 3/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/26 Checking commit 1b28ddabf976 (target/mips: Make CPU/FPU regnames[] arrays global) 5/26 Checking commit 55fbc48fe4bd (target/mips: Restrict mips_cpu_dump_state() to cpu.c) 6/26 Checking commit 061bc56c2038 (target/mips: Extract load/store helpers to ldst_helper.c) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 591 lines checked Patch 6/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/26 Checking commit d55345471b37 (meson: Introduce meson_user_arch source set for arch-specific user-mode) 8/26 Checking commit 1dee23e2dc56 (target/mips: Introduce tcg-internal.h for TCG specific declarations) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #53: new file mode 100644 total: 0 errors, 1 warnings, 45 lines checked Patch 8/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/26 Checking commit 5dc00af27500 (target/mips: Add simple user-mode mips_cpu_do_interrupt()) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #53: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 9/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/26 Checking commit 2945a4222f12 (target/mips: Add simple user-mode mips_cpu_tlb_fill()) 11/26 Checking commit 2557ee2c1477 (target/mips: Move cpu_signal_handler definition around) 12/26 Checking commit 17eb078e75c2 (target/mips: Move sysemu specific files under sysemu/ subfolder) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: target/mips/{ => sysemu}/addr.c | 0 total: 0 errors, 1 warnings, 35 lines checked Patch 12/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/26 Checking commit 4a8000ca29c7 (target/mips: Move code related to physical addressing to sysemu/phys.c) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #75: new file mode 100644 total: 0 errors, 1 warnings, 573 lines checked Patch 13/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/26 Checking commit 7f51b6e03727 (target/mips: Move sysemu TCG-specific code to tcg/sysemu/ subfolder) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: target/mips/{ => tcg/sysemu}/cp0_helper.c | 0 total: 0 errors, 1 warnings, 406 lines checked Patch 14/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/26 Checking commit 8f68aad986bd (target/mips: Restrict mmu_init() to TCG) 16/26 Checking commit 6d611109139f (target/mips: Move tlb_helper.c to tcg/sysemu/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #23: target/mips/{ => tcg/sysemu}/tlb_helper.c | 3 --- total: 0 errors, 1 warnings, 59 lines checked Patch 16/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/26 Checking commit 7d440db61c4b (target/mips: Restrict CPUMIPSTLBContext::map_address() handlers scope) 18/26 Checking commit db846de717b4 (target/mips: Move Special opcodes to tcg/sysemu/special_helper.c) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #203: new file mode 100644 total: 0 errors, 1 warnings, 331 lines checked Patch 18/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/26 Checking commit 51e44c97b2e8 (target/mips: Move helper_cache() to tcg/sysemu/special_helper.c) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #118: new file mode 100644 total: 0 errors, 1 warnings, 72 lines checked Patch 19/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/26 Checking commit 78d355aa02ce (target/mips: Move TLB management helpers to tcg/sysemu/tlb_helper.c) ERROR: space prohibited after that '&' (ctx:WxW) #455: FILE: target/mips/tcg/sysemu/tlb_helper.c:71: + tlb->XI0 = (env->CP0_EntryLo0 >> CP0EnLo_XI) & 1; ^ ERROR: space prohibited after that '&' (ctx:WxW) #456: FILE: target/mips/tcg/sysemu/tlb_helper.c:72: + tlb->RI0 = (env->CP0_EntryLo0 >> CP0EnLo_RI) & 1; ^ ERROR: space prohibited after that '&' (ctx:WxW) #461: FILE: target/mips/tcg/sysemu/tlb_helper.c:77: + tlb->XI1 = (env->CP0_EntryLo1 >> CP0EnLo_XI) & 1; ^ ERROR: space prohibited after that '&' (ctx:WxW) #462: FILE: target/mips/tcg/sysemu/tlb_helper.c:78: + tlb->RI1 = (env->CP0_EntryLo1 >> CP0EnLo_RI) & 1; ^ total: 4 errors, 0 warnings, 720 lines checked Patch 20/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/26 Checking commit 2d3b5d637a21 (target/mips: Move exception management code to exception.c) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #157: new file mode 100644 total: 0 errors, 1 warnings, 404 lines checked Patch 21/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/26 Checking commit c6e95b91596e (target/mips: Move CP0 helpers to sysemu/cp0.c) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #160: new file mode 100644 ERROR: space prohibited after that '&' (ctx:WxW) #204: FILE: target/mips/sysemu/cp0.c:40: + cu = (v >> CP0St_CU0) & 0xf; ^ ERROR: space prohibited after that '&' (ctx:WxW) #205: FILE: target/mips/sysemu/cp0.c:41: + mx = (v >> CP0St_MX) & 0x1; ^ ERROR: space prohibited after that '&' (ctx:WxW) #206: FILE: target/mips/sysemu/cp0.c:42: + ksu = (v >> CP0St_KSU) & 0x3; ^ ERROR: space prohibited after that '&' (ctx:WxW) #233: FILE: target/mips/sysemu/cp0.c:69: + uint32_t ksux = (1 << CP0St_KX) & val; ^ ERROR: space prohibited after that '&' (ctx:WxW) #241: FILE: target/mips/sysemu/cp0.c:77: + mask &= ~(((1 << CP0St_SR) | (1 << CP0St_NMI)) & val); ^ ERROR: space prohibited after that '&' (ctx:WxW) #268: FILE: target/mips/sysemu/cp0.c:104: + mask &= ~((1 << CP0Ca_WP) & val); ^ ERROR: space prohibited after that '&' (ctx:WxW) #273: FILE: target/mips/sysemu/cp0.c:109: + if ((old ^ env->CP0_Cause) & (1 << CP0Ca_DC)) { ^ ERROR: space prohibited after that '&' (ctx:WxW) #283: FILE: target/mips/sysemu/cp0.c:119: + if ((old ^ env->CP0_Cause) & (1 << (CP0Ca_IP + i))) { ^ total: 8 errors, 1 warnings, 257 lines checked Patch 22/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/26 Checking commit c83fb1145d13 (target/mips: Move helper.h -> tcg/helper.h.inc) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #642: new file mode 100644 total: 0 errors, 1 warnings, 1227 lines checked Patch 23/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 24/26 Checking commit d91a8b3ed88f (target/mips: Move TCG source files under tcg/ sub directory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #22: target/mips/{ => tcg}/dsp_helper.c | 0 total: 0 errors, 1 warnings, 139 lines checked Patch 24/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 25/26 Checking commit 0f39b274fa53 (hw/mips: Restrict non-virtualized machines to TCG) 26/26 Checking commit ec4a066907ab (gitlab-ci: Add KVM mips64el cross-build jobs) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210418163134.1133100-1-f4bug@amsat.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com