mbox series

[v2,0/2] add error handling in multifd_tls_handshake_thread

Message ID 20210209104237.2250941-1-wanghao232@huawei.com
Headers show
Series add error handling in multifd_tls_handshake_thread | expand

Message

Hao Wang Feb. 9, 2021, 10:42 a.m. UTC 
If any error happens during multifd send thread creating (e.g. channel broke
because new domain is destroyed by the dst), multifd_tls_handshake_thread
may exit silently, leaving main migration thread hanging (ram_save_setup ->
multifd_send_sync_main -> qemu_sem_wait(&p->sem_sync)).
Fix that by adding error handling in multifd_tls_handshake_thread.

Hao Wang (2):
  migration/tls: fix inverted semantics in multifd_channel_connect
  migration/tls: add error handling in multifd_tls_handshake_thread

 migration/multifd.c | 21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

Comments

Dr. David Alan Gilbert March 15, 2021, 5:20 p.m. UTC | #1 
* Hao Wang (wanghao232@huawei.com) wrote:
> If any error happens during multifd send thread creating (e.g. channel broke
> because new domain is destroyed by the dst), multifd_tls_handshake_thread
> may exit silently, leaving main migration thread hanging (ram_save_setup ->
> multifd_send_sync_main -> qemu_sem_wait(&p->sem_sync)).
> Fix that by adding error handling in multifd_tls_handshake_thread.
> 
> Hao Wang (2):
>   migration/tls: fix inverted semantics in multifd_channel_connect
>   migration/tls: add error handling in multifd_tls_handshake_thread
> 
>  migration/multifd.c | 21 +++++++++++++++------
>  1 file changed, 15 insertions(+), 6 deletions(-)

Queued

> 
> -- 
> 2.23.0
> 
>