mbox series

[0/6] hw/block/nvme: zoned misc fixes

Message ID 20210111123223.76248-1-its@irrelevant.dk
Headers show
Series hw/block/nvme: zoned misc fixes | expand

Message

Klaus Jensen Jan. 11, 2021, 12:32 p.m. UTC
From: Klaus Jensen <k.jensen@samsung.com>

These are some follow-up patches to the just merged zoned series.

The biggest addition here is asynchronous zeroing of zones on reset.

Klaus Jensen (6):
  hw/block/nvme: fix shutdown/reset logic
  hw/block/nvme: merge implicitly/explicitly opened processing masks
  hw/block/nvme: enum style fix
  hw/block/nvme: zero out zones on reset
  hw/block/nvme: add missing string representations for commands
  hw/block/nvme: remove unnecessary check for append

 hw/block/nvme-ns.h    |   4 +-
 hw/block/nvme.h       |   4 +
 include/block/nvme.h  |   4 +-
 hw/block/nvme.c       | 200 +++++++++++++++++++++++++++---------------
 hw/block/trace-events |   1 +
 5 files changed, 140 insertions(+), 73 deletions(-)

Comments

Dmitry Fomichev Jan. 18, 2021, 3:35 a.m. UTC | #1
On Mon, 2021-01-11 at 13:32 +0100, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>

Klaus,

This series looks good to me. I've made a comment in "zero out zones on reset"
patch, but it is only cosmetic in nature. I am going to send a patch
with another small fix in ZNS code.

Best regards,
Dmitry

Tested-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>

> 
> These are some follow-up patches to the just merged zoned series.
> 
> The biggest addition here is asynchronous zeroing of zones on reset.
> 
> Klaus Jensen (6):
>   hw/block/nvme: fix shutdown/reset logic
>   hw/block/nvme: merge implicitly/explicitly opened processing masks
>   hw/block/nvme: enum style fix
>   hw/block/nvme: zero out zones on reset
>   hw/block/nvme: add missing string representations for commands
>   hw/block/nvme: remove unnecessary check for append
> 
>  hw/block/nvme-ns.h    |   4 +-
>  hw/block/nvme.h       |   4 +
>  include/block/nvme.h  |   4 +-
>  hw/block/nvme.c       | 200 +++++++++++++++++++++++++++---------------
>  hw/block/trace-events |   1 +
>  5 files changed, 140 insertions(+), 73 deletions(-)
> 
> -- 
> 2.30.0
>
Klaus Jensen Jan. 18, 2021, 5:58 a.m. UTC | #2
On Jan 18 03:35, Dmitry Fomichev wrote:
> On Mon, 2021-01-11 at 13:32 +0100, Klaus Jensen wrote:
> > From: Klaus Jensen <k.jensen@samsung.com>
> 
> Klaus,
> 
> This series looks good to me. I've made a comment in "zero out zones on reset"
> patch, but it is only cosmetic in nature. I am going to send a patch
> with another small fix in ZNS code.
> 
> Best regards,
> Dmitry
> 
> Tested-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
> Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
> 

Thanks for the review AND testing! :)

Applying to nvme-next!