From patchwork Fri Oct 30 20:21:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eduardo Habkost X-Patchwork-Id: 1391295 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=isbsM3+j; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CNDHz6Mh8z9sRR for ; Sat, 31 Oct 2020 07:22:23 +1100 (AEDT) Received: from localhost ([::1]:40896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYauj-0000CP-Si for incoming@patchwork.ozlabs.org; Fri, 30 Oct 2020 16:22:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYau3-0000AU-MB for qemu-devel@nongnu.org; Fri, 30 Oct 2020 16:21:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30087) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kYau1-0007gz-Sp for qemu-devel@nongnu.org; Fri, 30 Oct 2020 16:21:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604089297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rmUpSIFLP4bcBRGklgXcM+VcVM29u1CqdRtS3UAu3H8=; b=isbsM3+jnjyA40Jmi9Yy0UPPHPAbUzbZ98IVBMA7kTLK94bnapgrwpL+BVR1NFWOTResjp urYWxy682R4EGAmhLl9bgvj8viVzbQKb1iQ8q/63E4rFBUxVtwHm6AGxCJaW1l5G55ntG/ KItWBl+lvjlgOaaioZdlfhxjQUvfCwM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-195-G1cpfHq3OpO-9BTnsANPMA-1; Fri, 30 Oct 2020 16:21:33 -0400 X-MC-Unique: G1cpfHq3OpO-9BTnsANPMA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 01F56805EF4 for ; Fri, 30 Oct 2020 20:21:33 +0000 (UTC) Received: from localhost (ovpn-114-68.rdu2.redhat.com [10.10.114.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id BDB0260DA0; Fri, 30 Oct 2020 20:21:32 +0000 (UTC) From: Eduardo Habkost To: qemu-devel@nongnu.org Subject: [PATCH 00/20] qdev/qom: Remove explicit type names from error_setg() calls Date: Fri, 30 Oct 2020 16:21:11 -0400 Message-Id: <20201030202131.796967-1-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/30 16:21:37 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Markus Armbruster Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Based-on: 20201029220246.472693-1-ehabkost@redhat.com Git branch: https://gitlab.com/ehabkost/qemu/-/commits/work/prop-error-reporting One of the obstacles when refactoring the QOM property parsing code are the references to the object itself in the error code, to generate "Property '.' can't take value ..." error messages. This makes it hard to isolate the string parsing code into functions that are independent from QOM. The simple solution for that would be to just remove the prefix and have less descriptive error messages. A slightly better solution is to make the code that parses -device and -object add a "Property '.' can't take value '': " prefix automatically when encountering an error when setting a property. This is the approach implemented in this series. Eduardo Habkost (20): qom: Add prefix to error message inside object_property_parse() qdev: Stop using error_set_from_qdev_prop_error() for netdev property qdev: Stop using error_set_from_qdev_prop_error() for audiodev property qdev: Stop using error_set_from_qdev_prop_error() for mac property qdev: Stop using error_set_from_qdev_prop_error() for devfn property qdev: Stop using error_set_from_qdev_prop_error() for PCI host device property qdev: Stop using error_set_from_qdev_prop_error() for css devno property qdev: Delete unused error_set_from_qdev_prop_error() function cryptodev: Remove unnecessary prefix from error message memfd: Remove unnecessary prefix from error message tpm_util: Remove unnecessary prefix from error message qdev: drive: Remove unnecessary prefix from error message qdev: chardev: Remove unnecessary prefix from error message i386: Remove unnecessary prefix from error message qerror: Delete unused QERR_PROPERTY_VALUE_BAD macro nvdimm: Remove unnecessary prefix from error message colo-compare: Remove unnecessary prefix from error message filter-dump: Remove unnecessary prefix from error message filter-buffer: Remove unnecessary prefix from error message qom: Remove error prefix check at object_property_parse() include/hw/qdev-properties.h | 2 -- include/qapi/qmp/qerror.h | 3 --- backends/cryptodev.c | 3 +-- backends/hostmem-memfd.c | 3 +-- backends/tpm/tpm_util.c | 3 +-- hw/core/qdev-properties-system.c | 28 +++++++++++----------------- hw/core/qdev-properties.c | 22 ---------------------- hw/mem/nvdimm.c | 6 ++---- hw/s390x/css.c | 2 +- net/colo-compare.c | 9 +++------ net/dump.c | 3 +-- net/filter-buffer.c | 3 +-- qom/object.c | 5 +++++ target/i386/cpu.c | 2 +- 14 files changed, 28 insertions(+), 66 deletions(-)