mbox series

[00/20] qdev/qom: Remove explicit type names from error_setg() calls

Message ID 20201030202131.796967-1-ehabkost@redhat.com
Headers show
Series qdev/qom: Remove explicit type names from error_setg() calls | expand

Message

Eduardo Habkost Oct. 30, 2020, 8:21 p.m. UTC 
Based-on: 20201029220246.472693-1-ehabkost@redhat.com
Git branch: https://gitlab.com/ehabkost/qemu/-/commits/work/prop-error-reporting

One of the obstacles when refactoring the QOM property parsing
code are the references to the object itself in the error code,
to generate "Property '<TYPE>.<PROP>' can't take value ..." error
messages.  This makes it hard to isolate the string parsing code
into functions that are independent from QOM.

The simple solution for that would be to just remove the prefix
and have less descriptive error messages.

A slightly better solution is to make the code that parses
-device and -object add a
  "Property '<TYPE>.<PROP>' can't take value '<VALUE>': "
prefix automatically when encountering an error
when setting a property.  This is the approach implemented in
this series.

Eduardo Habkost (20):
  qom: Add prefix to error message inside object_property_parse()
  qdev: Stop using error_set_from_qdev_prop_error() for netdev property
  qdev: Stop using error_set_from_qdev_prop_error() for audiodev
    property
  qdev: Stop using error_set_from_qdev_prop_error() for mac property
  qdev: Stop using error_set_from_qdev_prop_error() for devfn property
  qdev: Stop using error_set_from_qdev_prop_error() for PCI host device
    property
  qdev: Stop using error_set_from_qdev_prop_error() for css devno
    property
  qdev: Delete unused error_set_from_qdev_prop_error() function
  cryptodev: Remove unnecessary prefix from error message
  memfd: Remove unnecessary prefix from error message
  tpm_util: Remove unnecessary prefix from error message
  qdev: drive: Remove unnecessary prefix from error message
  qdev: chardev: Remove unnecessary prefix from error message
  i386: Remove unnecessary prefix from error message
  qerror: Delete unused QERR_PROPERTY_VALUE_BAD macro
  nvdimm: Remove unnecessary prefix from error message
  colo-compare: Remove unnecessary prefix from error message
  filter-dump: Remove unnecessary prefix from error message
  filter-buffer: Remove unnecessary prefix from error message
  qom: Remove error prefix check at object_property_parse()

 include/hw/qdev-properties.h     |  2 --
 include/qapi/qmp/qerror.h        |  3 ---
 backends/cryptodev.c             |  3 +--
 backends/hostmem-memfd.c         |  3 +--
 backends/tpm/tpm_util.c          |  3 +--
 hw/core/qdev-properties-system.c | 28 +++++++++++-----------------
 hw/core/qdev-properties.c        | 22 ----------------------
 hw/mem/nvdimm.c                  |  6 ++----
 hw/s390x/css.c                   |  2 +-
 net/colo-compare.c               |  9 +++------
 net/dump.c                       |  3 +--
 net/filter-buffer.c              |  3 +--
 qom/object.c                     |  5 +++++
 target/i386/cpu.c                |  2 +-
 14 files changed, 28 insertions(+), 66 deletions(-)