From patchwork Wed Oct 21 18:51:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Snow X-Patchwork-Id: 1385707 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=P0WSb3fz; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CGflP4yktz9sRK for ; Thu, 22 Oct 2020 05:53:21 +1100 (AEDT) Received: from localhost ([::1]:58160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVJEd-0005xV-GN for incoming@patchwork.ozlabs.org; Wed, 21 Oct 2020 14:53:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42522) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVJDq-0005xE-5A for qemu-devel@nongnu.org; Wed, 21 Oct 2020 14:52:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:49821) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kVJDf-0008AQ-VN for qemu-devel@nongnu.org; Wed, 21 Oct 2020 14:52:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603306332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2BBcCfVqHjMgRf/0GQk3HEMKrPlZ5yQ2xXwWI8hjaY4=; b=P0WSb3fzRF3tQVpBHCJDWV5zpSUJjFWJlGG7OUoxN4O3Z83KwMnthbHomNjqsGz7efTb2E WVhwgu58axTbx8FoCnvJOtfXtTnWt73+yWuUDhDmBjIbn6udhyvVPsHgAgimJPgV9yg56t /Lp+uhPo1x2gwE/LEXvDe7Yuo+7//ME= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-80-6wWkXZYqP-uSPhJtGh5sHQ-1; Wed, 21 Oct 2020 14:52:10 -0400 X-MC-Unique: 6wWkXZYqP-uSPhJtGh5sHQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A94F55F9C1 for ; Wed, 21 Oct 2020 18:52:09 +0000 (UTC) Received: from scv.redhat.com (ovpn-116-160.rdu2.redhat.com [10.10.116.160]) by smtp.corp.redhat.com (Postfix) with ESMTP id 02745100239F; Wed, 21 Oct 2020 18:52:08 +0000 (UTC) From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH 00/15] python: absorb scripts/qmp/qom-* tooling Date: Wed, 21 Oct 2020 14:51:53 -0400 Message-Id: <20201021185208.1611145-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=63.128.21.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/20 22:12:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Markus Armbruster , John Snow , Eduardo Habkost , Cleber Rosa Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Based-on: <20201020193555.1493936-1-jsnow@redhat.com> [PATCH v3 00/15] python: create installable package This is a bit of a demonstration of the direction I want to take our python tooling, and how it *might* work. By moving items from ./scripts/*.py over to ./python/qemu/* somewhere, they can be checked with the same isort/flake8/pylint/mypy tooling as everything else. This will help prevent regressions. I would like to, over time, move all applicable python scripts from ./scripts to ./python. That will be a long, gradual stream of changes, but the more we do it, the better off we'll be for these tools. Reviewer notes: - I just rewrote qom-xxx entirely, though it is based on the original scripts. Doing it brick by brick was too slow. - I added a symlink to the qom-fuse file under the python/ tree so I could check it with the usual linters. This causes some future knowledge to bleed through in a few places; notably I update the python setup.cfg several times in the middle of the series where it doesn't seem like that should have an effect. - qom-fuse disappears from the tree for a single commit, but that preserves git-blame history. Best I could do. John Snow (15): python/qmp: Add qom script rewrites python/qmp: add qom script entry points scripts/qmp: redirect qom-xxx scripts to python/qemu/qmp/ scripts/qom-fuse: apply isort rules scripts/qom-fuse: apply flake8 rules python: Add 'fh' to known-good variable names scripts/qom-fuse: Apply pylint rules scripts/qom-fuse: Add docstrings scripts/qom-fuse: Convert to QOMCommand scripts/qom-fuse: use QOMCommand.qom_list() scripts/qom-fuse: ensure QOMFuse.read always returns bytes scripts/qom-fuse: add static type hints scripts/qom-fuse: move to python/qemu/qmp/qom_fuse.py scripts/qom-fuse: add redirection shim to python/qemu/qmp/qom-fuse.py python: add fuse command to 'qom' tools python/qemu/qmp/qom.py | 217 ++++++++++++++++++++++++++++++++++ python/qemu/qmp/qom_common.py | 153 ++++++++++++++++++++++++ python/qemu/qmp/qom_fuse.py | 207 ++++++++++++++++++++++++++++++++ python/setup.cfg | 24 +++- scripts/qmp/qom-fuse | 144 +--------------------- scripts/qmp/qom-get | 66 +---------- scripts/qmp/qom-list | 63 +--------- scripts/qmp/qom-set | 63 +--------- scripts/qmp/qom-tree | 74 +----------- 9 files changed, 618 insertions(+), 393 deletions(-) create mode 100644 python/qemu/qmp/qom.py create mode 100644 python/qemu/qmp/qom_common.py create mode 100644 python/qemu/qmp/qom_fuse.py