mbox series

[v5,0/2] util/oslib: qemu_try_memalign() improvements

Message ID 20201021173803.2619054-1-philmd@redhat.com
Headers show
Series util/oslib: qemu_try_memalign() improvements | expand

Message

Philippe Mathieu-Daudé Oct. 21, 2020, 5:38 p.m. UTC
- Use _aligned_malloc for qemu_try_memalign on win32
- Assert qemu_try_memalign() alignment is a power of 2

Since v4:
- Drop superfluous assert (Richard)

Philippe Mathieu-Daudé (1):
  util/oslib: Assert qemu_try_memalign() alignment is a power of 2

Richard Henderson (1):
  util/oslib-win32: Use _aligned_malloc for qemu_try_memalign

 util/oslib-posix.c |  2 ++
 util/oslib-win32.c | 12 +++++-------
 2 files changed, 7 insertions(+), 7 deletions(-)

Comments

Richard Henderson Dec. 16, 2020, 7:24 p.m. UTC | #1
On 10/21/20 12:38 PM, Philippe Mathieu-Daudé wrote:
> - Use _aligned_malloc for qemu_try_memalign on win32
> - Assert qemu_try_memalign() alignment is a power of 2
> 
> Since v4:
> - Drop superfluous assert (Richard)
> 
> Philippe Mathieu-Daudé (1):
>   util/oslib: Assert qemu_try_memalign() alignment is a power of 2
> 
> Richard Henderson (1):
>   util/oslib-win32: Use _aligned_malloc for qemu_try_memalign
> 
>  util/oslib-posix.c |  2 ++
>  util/oslib-win32.c | 12 +++++-------
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 

Ping.


r~
Richard Henderson Jan. 5, 2021, 12:06 a.m. UTC | #2
On 12/16/20 9:24 AM, Richard Henderson wrote:
> On 10/21/20 12:38 PM, Philippe Mathieu-Daudé wrote:
>> - Use _aligned_malloc for qemu_try_memalign on win32
>> - Assert qemu_try_memalign() alignment is a power of 2
>>
>> Since v4:
>> - Drop superfluous assert (Richard)
>>
>> Philippe Mathieu-Daudé (1):
>>   util/oslib: Assert qemu_try_memalign() alignment is a power of 2
>>
>> Richard Henderson (1):
>>   util/oslib-win32: Use _aligned_malloc for qemu_try_memalign
>>
>>  util/oslib-posix.c |  2 ++
>>  util/oslib-win32.c | 12 +++++-------
>>  2 files changed, 7 insertions(+), 7 deletions(-)
>>
> 
> Ping.

Ping2.  Shall I just queue this to tcg-next?


r~
Paolo Bonzini Jan. 5, 2021, 9:56 a.m. UTC | #3
On 05/01/21 01:06, Richard Henderson wrote:
> On 12/16/20 9:24 AM, Richard Henderson wrote:
>> On 10/21/20 12:38 PM, Philippe Mathieu-Daudé wrote:
>>> - Use _aligned_malloc for qemu_try_memalign on win32
>>> - Assert qemu_try_memalign() alignment is a power of 2
>>>
>>> Since v4:
>>> - Drop superfluous assert (Richard)
>>>
>>> Philippe Mathieu-Daudé (1):
>>>    util/oslib: Assert qemu_try_memalign() alignment is a power of 2
>>>
>>> Richard Henderson (1):
>>>    util/oslib-win32: Use _aligned_malloc for qemu_try_memalign
>>>
>>>   util/oslib-posix.c |  2 ++
>>>   util/oslib-win32.c | 12 +++++-------
>>>   2 files changed, 7 insertions(+), 7 deletions(-)
>>>
>>
>> Ping.
> 
> Ping2.  Shall I just queue this to tcg-next?

Yes, just go ahead.  util/ is everybody's land, maintainers are supposed 
to know what they're doing. :)

Paolo