Message ID | 20200714164257.23330-1-f4bug@amsat.org |
---|---|
Headers | show |
Series | misc: Document qemu_find_file and fix memory leak in avr_load_firmware | expand |
Reviewed-by: Michael Rolnik <mrolnik@gmail.com> On Tue, Jul 14, 2020 at 7:42 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > Fix the memory leak reported by Coverity (CID 1430449). > > Philippe Mathieu-Daudé (4): > qemu/osdep: Document os_find_datadir() return value > qemu/osdep: Reword qemu_get_exec_dir() documentation > qemu-common: Document qemu_find_file() > hw/avr/boot: Fix memory leak in avr_load_firmware() > > include/qemu-common.h | 14 ++++++++++++++ > include/qemu/osdep.h | 5 ++++- > hw/avr/boot.c | 2 +- > os-posix.c | 3 +++ > os-win32.c | 7 ++++++- > 5 files changed, 28 insertions(+), 3 deletions(-) > > -- > 2.21.3 > >
Tested-by: Michael Rolnik <mrolnik@gmail.com> I mean I got the patch, built and then ran *make check-qtest-avr* and *make check-acceptance* On Mon, Jul 20, 2020 at 4:24 PM Michael Rolnik <mrolnik@gmail.com> wrote: > Reviewed-by: Michael Rolnik <mrolnik@gmail.com> > > > On Tue, Jul 14, 2020 at 7:42 PM Philippe Mathieu-Daudé <f4bug@amsat.org> > wrote: > >> Fix the memory leak reported by Coverity (CID 1430449). >> >> Philippe Mathieu-Daudé (4): >> qemu/osdep: Document os_find_datadir() return value >> qemu/osdep: Reword qemu_get_exec_dir() documentation >> qemu-common: Document qemu_find_file() >> hw/avr/boot: Fix memory leak in avr_load_firmware() >> >> include/qemu-common.h | 14 ++++++++++++++ >> include/qemu/osdep.h | 5 ++++- >> hw/avr/boot.c | 2 +- >> os-posix.c | 3 +++ >> os-win32.c | 7 ++++++- >> 5 files changed, 28 insertions(+), 3 deletions(-) >> >> -- >> 2.21.3 >> >> > > -- > Best Regards, > Michael Rolnik >
On 7/14/20 6:42 PM, Philippe Mathieu-Daudé wrote: > Fix the memory leak reported by Coverity (CID 1430449). > > Philippe Mathieu-Daudé (4): > qemu/osdep: Document os_find_datadir() return value > qemu/osdep: Reword qemu_get_exec_dir() documentation > qemu-common: Document qemu_find_file() > hw/avr/boot: Fix memory leak in avr_load_firmware() > > include/qemu-common.h | 14 ++++++++++++++ > include/qemu/osdep.h | 5 ++++- > hw/avr/boot.c | 2 +- > os-posix.c | 3 +++ > os-win32.c | 7 ++++++- > 5 files changed, 28 insertions(+), 3 deletions(-) > Thanks to the reviewers. I addressed Daniel's review comments and will send a pull request once the testing succeeds. Phil.