mbox series

[v2,0/1] Add Loongson 2F disassembler

Message ID 20200703104409.6986-1-stefan.brankovic@syrmia.com
Headers show
Series Add Loongson 2F disassembler | expand

Message

Stefan Brankovic July 3, 2020, 10:44 a.m. UTC 
This patch adds disassembler for Loongson 2F architecture.

v2:
Fixed coding style problems.
Added comments related to licence and author.

Stefan Brankovic (1):
  disas: mips: Add Loongson 2F disassembler

 MAINTAINERS             |    1 +
 configure               |    1 +
 disas/Makefile.objs     |    1 +
 disas/loongson2f.cpp    | 8154 +++++++++++++++++++++++++++++++++++++++
 disas/loongson2f.h      | 2562 ++++++++++++
 include/disas/dis-asm.h |    1 +
 include/exec/poison.h   |    1 +
 target/mips/cpu.c       |    4 +
 8 files changed, 10725 insertions(+)
 create mode 100644 disas/loongson2f.cpp
 create mode 100644 disas/loongson2f.h

Comments

no-reply@patchew.org July 3, 2020, 11:04 a.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/20200703104409.6986-1-stefan.brankovic@syrmia.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v2 0/1] Add Loongson 2F disassembler
Type: series
Message-id: 20200703104409.6986-1-stefan.brankovic@syrmia.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20200703104409.6986-1-stefan.brankovic@syrmia.com -> patchew/20200703104409.6986-1-stefan.brankovic@syrmia.com
Switched to a new branch 'test'
5bdca87 disas: mips: Add Loongson 2F disassembler

=== OUTPUT BEGIN ===
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#57: 
new file mode 100644

ERROR: space prohibited between function name and open parenthesis '('
#10792: FILE: include/disas/dis-asm.h:399:
+int print_insn_loongson2f       (bfd_vma, disassemble_info*);

total: 1 errors, 1 warnings, 10761 lines checked

Commit 5bdca876a94b (disas: mips: Add Loongson 2F disassembler) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200703104409.6986-1-stefan.brankovic@syrmia.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com