mbox series

[v5,00/13] iotests: Dump QCOW2 dirty bitmaps metadata

Message ID 20200606081806.23897-1-vsementsov@virtuozzo.com
Headers show
Series iotests: Dump QCOW2 dirty bitmaps metadata | expand

Message

Vladimir Sementsov-Ogievskiy June 6, 2020, 8:17 a.m. UTC 
Hi all!

Here is my suggestion to substitute only first three patches :) of
Andrey's [PATCH v3 0/6] iotests: Dump QCOW2 dirty bitmaps metadata

v5:
01: - typo in commit message
    - fix over-79 lines
02: new, specify GPL license
03: specify GPL license
04-06: add Andrey's r-b
07: - grammar in commit message
    - add Andrey's r-b
08: - add copyright
    - note u8 and u16 in a comment
    - add doc for __init__ of Qcow2Struct
    - add Andrey's r-b
09-10: add Andrey's r-b
11: - note about current fd position in __init__ doc of
      QcowHeaderExtension
    - add Andrey's r-b
12: - keep magic in hex
    - use lower-case for magic constants
13: add Andrey's r-b

Tags up-refactor-qcow2.py-v4 and up-refactor-qcow2.py-v4 may be found
here: https://src.openvz.org/users/vsementsov/repos/qemu/browse
(git remote: https://src.openvz.org/scm/~vsementsov/qemu.git)

Plan for continuation:

- add type hints
- support compression_type field
- dump more about bitmaps

Vladimir Sementsov-Ogievskiy (13):
  qcow2.py: python style fixes
  qcow2.py: add licensing blurb
  qcow2.py: move qcow2 format classes to separate module
  qcow2_format.py: drop new line printing at end of dump()
  qcow2_format.py: use tuples instead of lists for fields
  qcow2_format.py: use modern string formatting
  qcow2_format.py: use strings to specify c-type of struct fields
  qcow2_format.py: separate generic functionality of structure classes
  qcow2_format.py: add field-formatting class
  qcow2_format.py: QcowHeaderExtension: add dump method
  qcow2_format: refactor QcowHeaderExtension as a subclass of
    Qcow2Struct
  qcow2: QcowHeaderExtension print names for extension magics
  qcow2_format.py: dump bitmaps header extension

 tests/qemu-iotests/031.out         |  22 +--
 tests/qemu-iotests/036.out         |   4 +-
 tests/qemu-iotests/061.out         |  14 +-
 tests/qemu-iotests/291             |   4 +
 tests/qemu-iotests/291.out         |  33 ++++
 tests/qemu-iotests/qcow2.py        | 218 +++++-----------------
 tests/qemu-iotests/qcow2_format.py | 286 +++++++++++++++++++++++++++++
 7 files changed, 393 insertions(+), 188 deletions(-)
 create mode 100644 tests/qemu-iotests/qcow2_format.py