| Message ID | 20200605102230.21493-1-philmd@redhat.com |
|---|---|
| Headers | show |
| Series | hw/sd/sdcard: Fix CVE-2020-13253 & cleanups | expand |
Hi Alistair, On 6/5/20 12:22 PM, Philippe Mathieu-Daudé wrote: > Patches 2 & 3 fix CVE-2020-13253. > The rest are (accumulated) cleanups. > > Supersedes: <20200604182502.24228-1-f4bug@amsat.org> > > Philippe Mathieu-Daudé (11): > MAINTAINERS: Cc qemu-block mailing list > hw/sd/sdcard: Update coding style to make checkpatch.pl happy > hw/sd/sdcard: Do not switch to ReceivingData if address is invalid > hw/sd/sdcard: Restrict Class 6 commands to SCSD cards > hw/sd/sdcard: Update the SDState documentation > hw/sd/sdcard: Simplify cmd_valid_while_locked() > hw/sd/sdcard: Constify sd_crc*()'s message argument > hw/sd/sdcard: Make iolen unsigned > hw/sd/sdcard: Correctly display the command name in trace events > hw/sd/sdcard: Display offset in read/write_data() trace events > hw/sd/sdcard: Simplify realize() a bit I forgot to Cc you. Since you already reviewed a bunch of SD patches in the past, do you mind having a look a this series? It should be quite trivial. Thanks! Phil.
On 6/5/20 12:22 PM, Philippe Mathieu-Daudé wrote: > Patches 2 & 3 fix CVE-2020-13253. Ping for the CVE fix?... > The rest are (accumulated) cleanups. > > Supersedes: <20200604182502.24228-1-f4bug@amsat.org> > > Philippe Mathieu-Daudé (11): > MAINTAINERS: Cc qemu-block mailing list > hw/sd/sdcard: Update coding style to make checkpatch.pl happy > hw/sd/sdcard: Do not switch to ReceivingData if address is invalid > hw/sd/sdcard: Restrict Class 6 commands to SCSD cards > hw/sd/sdcard: Update the SDState documentation > hw/sd/sdcard: Simplify cmd_valid_while_locked() > hw/sd/sdcard: Constify sd_crc*()'s message argument > hw/sd/sdcard: Make iolen unsigned > hw/sd/sdcard: Correctly display the command name in trace events > hw/sd/sdcard: Display offset in read/write_data() trace events > hw/sd/sdcard: Simplify realize() a bit > > hw/sd/sd.c | 122 +++++++++++++++++++++++++++++---------------- > MAINTAINERS | 1 + > hw/sd/trace-events | 4 +- > 3 files changed, 83 insertions(+), 44 deletions(-) >
On Mon, Jun 8, 2020 at 10:48 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > Hi Alistair, > > On 6/5/20 12:22 PM, Philippe Mathieu-Daudé wrote: > > Patches 2 & 3 fix CVE-2020-13253. > > The rest are (accumulated) cleanups. > > > > Supersedes: <20200604182502.24228-1-f4bug@amsat.org> > > > > Philippe Mathieu-Daudé (11): > > MAINTAINERS: Cc qemu-block mailing list > > hw/sd/sdcard: Update coding style to make checkpatch.pl happy > > hw/sd/sdcard: Do not switch to ReceivingData if address is invalid > > hw/sd/sdcard: Restrict Class 6 commands to SCSD cards > > hw/sd/sdcard: Update the SDState documentation > > hw/sd/sdcard: Simplify cmd_valid_while_locked() > > hw/sd/sdcard: Constify sd_crc*()'s message argument > > hw/sd/sdcard: Make iolen unsigned > > hw/sd/sdcard: Correctly display the command name in trace events > > hw/sd/sdcard: Display offset in read/write_data() trace events > > hw/sd/sdcard: Simplify realize() a bit > > I forgot to Cc you. > > Since you already reviewed a bunch of SD patches in the > past, do you mind having a look a this series? It should > be quite trivial. Hey, Sorry I took so long but I have reviewed a few. Let me know if there are anymore you want reviewed. Alistair > > Thanks! > > Phil. > >
On 7/6/20 6:31 PM, Alistair Francis wrote: > On Mon, Jun 8, 2020 at 10:48 AM Philippe Mathieu-Daudé > <philmd@redhat.com> wrote: >> >> Hi Alistair, >> >> On 6/5/20 12:22 PM, Philippe Mathieu-Daudé wrote: >>> Patches 2 & 3 fix CVE-2020-13253. >>> The rest are (accumulated) cleanups. >>> >>> Supersedes: <20200604182502.24228-1-f4bug@amsat.org> >>> >>> Philippe Mathieu-Daudé (11): >>> MAINTAINERS: Cc qemu-block mailing list >>> hw/sd/sdcard: Update coding style to make checkpatch.pl happy >>> hw/sd/sdcard: Do not switch to ReceivingData if address is invalid >>> hw/sd/sdcard: Restrict Class 6 commands to SCSD cards >>> hw/sd/sdcard: Update the SDState documentation >>> hw/sd/sdcard: Simplify cmd_valid_while_locked() >>> hw/sd/sdcard: Constify sd_crc*()'s message argument >>> hw/sd/sdcard: Make iolen unsigned >>> hw/sd/sdcard: Correctly display the command name in trace events >>> hw/sd/sdcard: Display offset in read/write_data() trace events >>> hw/sd/sdcard: Simplify realize() a bit >> >> I forgot to Cc you. >> >> Since you already reviewed a bunch of SD patches in the >> past, do you mind having a look a this series? It should >> be quite trivial. > > Hey, > > Sorry I took so long but I have reviewed a few. Let me know if there > are anymore you want reviewed. No problem, just in time :) Thank you a lot for all your reviews! Phil. > > Alistair